[HDFS-10945] Fix the Findbugwaring FSNamesystem#renameTo(String, String, boolean) in branch-2

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Brahma Reddy Battula
• Reporter: Brahma Reddy Battula
• Created: 03/Oct/16 07:59
• Updated: 04/Oct/16 01:24
• Resolved: 03/Oct/16 16:11

Description

Link : https://builds.apache.org/job/PreCommit-HDFS-Build/16972/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html#Warnings_CORRECTNESS

Nullcheck of ret at line 2696 of value previously dereferenced in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean)
Bug type RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE (click for details) 
In class org.apache.hadoop.hdfs.server.namenode.FSNamesystem
In method org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean)
Value loaded from ret
Return value of org.apache.hadoop.hdfs.server.namenode.FSDirRenameOp.renameToInt(FSDirectory, String, String, boolean) of type org.apache.hadoop.hdfs.server.namenode.FSDirRenameOp$RenameResult
At FSNamesystem.java:[line 2696]
Redundant null check at FSNamesystem.java:[line 2700]