Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10945

Fix the Findbugwaring FSNamesystem#renameTo(String, String, boolean) in branch-2

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Link : https://builds.apache.org/job/PreCommit-HDFS-Build/16972/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html#Warnings_CORRECTNESS

      Nullcheck of ret at line 2696 of value previously dereferenced in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean)
      Bug type RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE (click for details) 
      In class org.apache.hadoop.hdfs.server.namenode.FSNamesystem
      In method org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(String, String, boolean)
      Value loaded from ret
      Return value of org.apache.hadoop.hdfs.server.namenode.FSDirRenameOp.renameToInt(FSDirectory, String, String, boolean) of type org.apache.hadoop.hdfs.server.namenode.FSDirRenameOp$RenameResult
      At FSNamesystem.java:[line 2696]
      Redundant null check at FSNamesystem.java:[line 2700]
      
      
      1. HDFS-10945-branch-2.patch
        0.9 kB
        Brahma Reddy Battula

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch to fix the findbug

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch to fix the findbug
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 42s branch-2 passed
        +1 compile 0m 39s branch-2 passed with JDK v1.8.0_101
        +1 compile 0m 42s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 29s branch-2 passed
        +1 mvnsite 0m 51s branch-2 passed
        +1 mvneclipse 0m 15s branch-2 passed
        -1 findbugs 1m 57s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings.
        +1 javadoc 0m 55s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 1m 38s branch-2 passed with JDK v1.7.0_111
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 36s the patch passed with JDK v1.8.0_101
        +1 javac 0m 36s the patch passed
        +1 compile 0m 40s the patch passed with JDK v1.7.0_111
        +1 javac 0m 40s the patch passed
        +1 checkstyle 0m 27s the patch passed
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 7s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
        +1 javadoc 0m 51s the patch passed with JDK v1.8.0_101
        +1 javadoc 1m 31s the patch passed with JDK v1.7.0_111
        +1 unit 46m 37s hadoop-hdfs in the patch passed with JDK v1.7.0_111.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        122m 6s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HDFS-10945
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831281/HDFS-10945-branch-2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 63e653cd1d65 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 04f594d
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16973/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16973/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16973/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 42s branch-2 passed +1 compile 0m 39s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 42s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 29s branch-2 passed +1 mvnsite 0m 51s branch-2 passed +1 mvneclipse 0m 15s branch-2 passed -1 findbugs 1m 57s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings. +1 javadoc 0m 55s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 38s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 45s the patch passed +1 compile 0m 36s the patch passed with JDK v1.8.0_101 +1 javac 0m 36s the patch passed +1 compile 0m 40s the patch passed with JDK v1.7.0_111 +1 javac 0m 40s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 7s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) +1 javadoc 0m 51s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 31s the patch passed with JDK v1.7.0_111 +1 unit 46m 37s hadoop-hdfs in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 122m 6s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-10945 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831281/HDFS-10945-branch-2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 63e653cd1d65 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 04f594d Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16973/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16973/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16973/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        kihwal Kihwal Lee added a comment -

        +1

        Show
        kihwal Kihwal Lee added a comment - +1
        Hide
        kihwal Kihwal Lee added a comment -

        Committed this to branch-2 and branch-2.8. Thanks for fixing this, Brahma Reddy Battula.

        Show
        kihwal Kihwal Lee added a comment - Committed this to branch-2 and branch-2.8. Thanks for fixing this, Brahma Reddy Battula .
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Thanks Kihwal Lee for review and commit.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Thanks Kihwal Lee for review and commit.

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development