Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This ticket is opened to track adding unit tests for Trash.

      1. HDFS-10922-branch-2.8.01.patch
        12 kB
        Weiwei Yang
      2. HDFS-10922-branch-2.01.patch
        14 kB
        Weiwei Yang
      3. HDFS-10922.13.patch
        14 kB
        Weiwei Yang
      4. HDFS-10922.12.patch
        19 kB
        Weiwei Yang
      5. HDFS-10922.11.patch
        15 kB
        Weiwei Yang
      6. HDFS-10922.10.patch
        15 kB
        Weiwei Yang
      7. HDFS-10922.09.patch
        15 kB
        Weiwei Yang
      8. HDFS-10922.08.patch
        14 kB
        Weiwei Yang
      9. HDFS-10922.07.patch
        14 kB
        Weiwei Yang
      10. HDFS-10922.06.patch
        16 kB
        Weiwei Yang
      11. HDFS-10922.05.patch
        16 kB
        Weiwei Yang
      12. HDFS-10922.04.patch
        16 kB
        Weiwei Yang
      13. HDFS-10922.03.patch
        16 kB
        Weiwei Yang
      14. HDFS-10922.02.patch
        10 kB
        Weiwei Yang

        Issue Links

          Activity

          Hide
          xyao Xiaoyu Yao added a comment -

          Propose to add the following test cases:

          1. test users can delete their own trash directory
          2. test users can delete an empty directory and the directory is moved to trash
          3. test fs.trash.interval with invalid values such as 0 or negative
          4. test fs.trash.interval with namenode restart.
          Show
          xyao Xiaoyu Yao added a comment - Propose to add the following test cases: test users can delete their own trash directory test users can delete an empty directory and the directory is moved to trash test fs.trash.interval with invalid values such as 0 or negative test fs.trash.interval with namenode restart.
          Hide
          cheersyang Weiwei Yang added a comment -

          Hello Xiaoyu Yao

          I recently worked on some JIRAs about Trash, I can work on this ticket if you don't mind.

          Show
          cheersyang Weiwei Yang added a comment - Hello Xiaoyu Yao I recently worked on some JIRAs about Trash, I can work on this ticket if you don't mind.
          Hide
          xyao Xiaoyu Yao added a comment -

          Weiwei Yang, Sounds good to me. Thank you!

          Show
          xyao Xiaoyu Yao added a comment - Weiwei Yang , Sounds good to me. Thank you!
          Hide
          cheersyang Weiwei Yang added a comment -

          I just uploaded a patch. Some explanation to the patch

          1. test users can delete their own trash directory

          Added test case in TestDFSPermission#testTrashPermission

          2. test users can delete an empty directory and the directory is moved to trash

          Added test case in TestTrash#testMoveEmptyDirToTrash

          3. test fs.trash.interval with invalid values such as 0 or negative

          Already covered. TestTrash#trashShell tested setting value to 0. TestStateTransitionFailure tested setting a negative value. Namenode will not be started with error "Cannot start trash emptier with negative interval. Set fs.trash.interval to a positive value".

          Now working on #4 about namenode restart. One question, the patch modified both common and hdfs projects, is it OK to use just single 1 patch ?

          Show
          cheersyang Weiwei Yang added a comment - I just uploaded a patch. Some explanation to the patch 1. test users can delete their own trash directory Added test case in TestDFSPermission#testTrashPermission 2. test users can delete an empty directory and the directory is moved to trash Added test case in TestTrash#testMoveEmptyDirToTrash 3. test fs.trash.interval with invalid values such as 0 or negative Already covered. TestTrash#trashShell tested setting value to 0. TestStateTransitionFailure tested setting a negative value. Namenode will not be started with error "Cannot start trash emptier with negative interval. Set fs.trash.interval to a positive value". Now working on #4 about namenode restart. One question, the patch modified both common and hdfs projects, is it OK to use just single 1 patch ?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 1m 36s Maven dependency ordering for branch
          +1 mvninstall 7m 17s trunk passed
          +1 compile 7m 13s trunk passed
          +1 checkstyle 1m 31s trunk passed
          +1 mvnsite 1m 50s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 3m 3s trunk passed
          +1 javadoc 1m 41s trunk passed
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 28s the patch passed
          +1 compile 6m 56s the patch passed
          +1 javac 6m 56s the patch passed
          -0 checkstyle 1m 26s root: The patch generated 2 new + 132 unchanged - 0 fixed = 134 total (was 132)
          +1 mvnsite 1m 44s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 12s the patch passed
          +1 javadoc 1m 40s the patch passed
          -1 unit 18m 52s hadoop-common in the patch failed.
          -1 unit 66m 26s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 25s The patch does not generate ASF License warnings.
          128m 34s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestCrcCorruption
            hadoop.hdfs.TestBlockStoragePolicy
          Timed out junit tests org.apache.hadoop.fs.TestTrash



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10922
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831557/HDFS-10922.03.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e963df38326e 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ef7f06f
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16999/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16999/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16999/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16999/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16999/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 36s Maven dependency ordering for branch +1 mvninstall 7m 17s trunk passed +1 compile 7m 13s trunk passed +1 checkstyle 1m 31s trunk passed +1 mvnsite 1m 50s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 3s trunk passed +1 javadoc 1m 41s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 28s the patch passed +1 compile 6m 56s the patch passed +1 javac 6m 56s the patch passed -0 checkstyle 1m 26s root: The patch generated 2 new + 132 unchanged - 0 fixed = 134 total (was 132) +1 mvnsite 1m 44s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 12s the patch passed +1 javadoc 1m 40s the patch passed -1 unit 18m 52s hadoop-common in the patch failed. -1 unit 66m 26s hadoop-hdfs in the patch failed. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 128m 34s Reason Tests Failed junit tests hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.TestBlockStoragePolicy Timed out junit tests org.apache.hadoop.fs.TestTrash Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831557/HDFS-10922.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e963df38326e 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ef7f06f Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16999/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16999/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16999/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16999/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16999/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 19s Maven dependency ordering for branch
          +1 mvninstall 7m 45s trunk passed
          +1 compile 6m 52s trunk passed
          +1 checkstyle 1m 26s trunk passed
          +1 mvnsite 1m 48s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 2m 58s trunk passed
          +1 javadoc 1m 38s trunk passed
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 24s the patch passed
          +1 compile 6m 46s the patch passed
          +1 javac 6m 46s the patch passed
          -0 checkstyle 1m 27s root: The patch generated 2 new + 132 unchanged - 0 fixed = 134 total (was 132)
          +1 mvnsite 1m 44s the patch passed
          +1 mvneclipse 0m 24s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 11s the patch passed
          +1 javadoc 1m 39s the patch passed
          -1 unit 21m 6s hadoop-common in the patch failed.
          +1 unit 58m 39s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          121m 12s



          Reason Tests
          Timed out junit tests org.apache.hadoop.fs.TestTrash



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10922
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831558/HDFS-10922.04.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 673204f3189d 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ef7f06f
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17000/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17000/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17000/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17000/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 19s Maven dependency ordering for branch +1 mvninstall 7m 45s trunk passed +1 compile 6m 52s trunk passed +1 checkstyle 1m 26s trunk passed +1 mvnsite 1m 48s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 2m 58s trunk passed +1 javadoc 1m 38s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 24s the patch passed +1 compile 6m 46s the patch passed +1 javac 6m 46s the patch passed -0 checkstyle 1m 27s root: The patch generated 2 new + 132 unchanged - 0 fixed = 134 total (was 132) +1 mvnsite 1m 44s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 11s the patch passed +1 javadoc 1m 39s the patch passed -1 unit 21m 6s hadoop-common in the patch failed. +1 unit 58m 39s hadoop-hdfs in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 121m 12s Reason Tests Timed out junit tests org.apache.hadoop.fs.TestTrash Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831558/HDFS-10922.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 673204f3189d 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ef7f06f Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17000/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17000/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17000/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17000/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 19s Maven dependency ordering for branch
          +1 mvninstall 7m 0s trunk passed
          +1 compile 7m 46s trunk passed
          +1 checkstyle 1m 35s trunk passed
          +1 mvnsite 2m 10s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 3m 23s trunk passed
          +1 javadoc 1m 49s trunk passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 41s the patch passed
          +1 compile 8m 3s the patch passed
          +1 javac 8m 3s the patch passed
          +1 checkstyle 1m 33s the patch passed
          +1 mvnsite 1m 59s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 40s the patch passed
          +1 javadoc 1m 48s the patch passed
          -1 unit 19m 30s hadoop-common in the patch failed.
          -1 unit 78m 32s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 44s The patch does not generate ASF License warnings.
          143m 53s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
          Timed out junit tests org.apache.hadoop.fs.TestTrash
            org.apache.hadoop.hdfs.TestLeaseRecovery2



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10922
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831640/HDFS-10922.05.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 106a81be24fe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 44f48ee
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17011/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17011/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17011/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17011/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 19s Maven dependency ordering for branch +1 mvninstall 7m 0s trunk passed +1 compile 7m 46s trunk passed +1 checkstyle 1m 35s trunk passed +1 mvnsite 2m 10s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 23s trunk passed +1 javadoc 1m 49s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 41s the patch passed +1 compile 8m 3s the patch passed +1 javac 8m 3s the patch passed +1 checkstyle 1m 33s the patch passed +1 mvnsite 1m 59s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 40s the patch passed +1 javadoc 1m 48s the patch passed -1 unit 19m 30s hadoop-common in the patch failed. -1 unit 78m 32s hadoop-hdfs in the patch failed. +1 asflicense 0m 44s The patch does not generate ASF License warnings. 143m 53s Reason Tests Failed junit tests hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.hdfs.security.TestDelegationTokenForProxyUser Timed out junit tests org.apache.hadoop.fs.TestTrash   org.apache.hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831640/HDFS-10922.05.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 106a81be24fe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 44f48ee Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17011/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17011/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17011/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17011/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 1m 33s Maven dependency ordering for branch
          +1 mvninstall 6m 54s trunk passed
          +1 compile 6m 58s trunk passed
          +1 checkstyle 1m 37s trunk passed
          +1 mvnsite 1m 54s trunk passed
          +1 mvneclipse 0m 33s trunk passed
          +1 findbugs 4m 3s trunk passed
          +1 javadoc 1m 50s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 41s the patch passed
          +1 compile 7m 36s the patch passed
          +1 javac 7m 36s the patch passed
          +1 checkstyle 1m 26s the patch passed
          +1 mvnsite 1m 43s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 13s the patch passed
          +1 javadoc 1m 39s the patch passed
          -1 unit 7m 24s hadoop-common in the patch failed.
          -1 unit 62m 8s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 25s The patch does not generate ASF License warnings.
          114m 24s



          Reason Tests
          Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.net.TestDNS
            hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10922
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831750/HDFS-10922.06.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8ec4ce885c98 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d6be1e7
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17020/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17020/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17020/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17020/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 33s Maven dependency ordering for branch +1 mvninstall 6m 54s trunk passed +1 compile 6m 58s trunk passed +1 checkstyle 1m 37s trunk passed +1 mvnsite 1m 54s trunk passed +1 mvneclipse 0m 33s trunk passed +1 findbugs 4m 3s trunk passed +1 javadoc 1m 50s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 41s the patch passed +1 compile 7m 36s the patch passed +1 javac 7m 36s the patch passed +1 checkstyle 1m 26s the patch passed +1 mvnsite 1m 43s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 13s the patch passed +1 javadoc 1m 39s the patch passed -1 unit 7m 24s hadoop-common in the patch failed. -1 unit 62m 8s hadoop-hdfs in the patch failed. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 114m 24s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.net.TestDNS   hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831750/HDFS-10922.06.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8ec4ce885c98 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d6be1e7 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17020/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17020/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17020/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17020/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment - - edited

          Now working on #4 about namenode restart. One question, the patch modified both common and hdfs projects, is it OK to use just single 1 patch ?

          Good catch, Weiwei Yang. Let's use this ticket for hdfs only changes in #4. That should be landed in o.a.h.hdfs.TestHDFSTrash

          I opened a new ticket HADOOP-13686 for #1-3. I notice the permission test for #1 is added for only hdfs. Can you move that to hadoop-common and attach the updated patch in HADOOP-13686? This way, we will have better coverage than having the test only for hdfs.

          Show
          xyao Xiaoyu Yao added a comment - - edited Now working on #4 about namenode restart. One question, the patch modified both common and hdfs projects, is it OK to use just single 1 patch ? Good catch, Weiwei Yang . Let's use this ticket for hdfs only changes in #4. That should be landed in o.a.h.hdfs.TestHDFSTrash I opened a new ticket HADOOP-13686 for #1-3. I notice the permission test for #1 is added for only hdfs. Can you move that to hadoop-common and attach the updated patch in HADOOP-13686 ? This way, we will have better coverage than having the test only for hdfs.
          Hide
          cheersyang Weiwei Yang added a comment -

          Sounds good to me, will work on that. I was adding the permission tests for #1 in hdfs, because I was not sure how to test permission in localFS, any hints on that? I will also take a look shortly. Thanks for the suggestions.

          Show
          cheersyang Weiwei Yang added a comment - Sounds good to me, will work on that. I was adding the permission tests for #1 in hdfs, because I was not sure how to test permission in localFS, any hints on that? I will also take a look shortly. Thanks for the suggestions.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 44s trunk passed
          +1 compile 0m 45s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 49s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 39s trunk passed
          +1 javadoc 0m 39s trunk passed
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 41s the patch passed
          +1 javac 0m 41s the patch passed
          -0 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 10 new + 59 unchanged - 0 fixed = 69 total (was 59)
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 47s the patch passed
          +1 javadoc 0m 34s the patch passed
          -1 unit 70m 42s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          88m 55s



          Reason Tests
          Failed junit tests hadoop.hdfs.tools.TestDFSAdmin



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10922
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832608/HDFS-10922.07.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ee4db1e9902a 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 96b1266
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17096/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17096/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17096/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17096/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 44s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 49s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 39s trunk passed +1 javadoc 0m 39s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 41s the patch passed +1 javac 0m 41s the patch passed -0 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 10 new + 59 unchanged - 0 fixed = 69 total (was 59) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 34s the patch passed -1 unit 70m 42s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 88m 55s Reason Tests Failed junit tests hadoop.hdfs.tools.TestDFSAdmin Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832608/HDFS-10922.07.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ee4db1e9902a 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 96b1266 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17096/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17096/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17096/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17096/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 24s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 34s trunk passed
          +1 compile 0m 56s trunk passed
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 54s trunk passed
          +1 javadoc 0m 48s trunk passed
          +1 mvninstall 0m 57s the patch passed
          +1 compile 0m 45s the patch passed
          +1 javac 0m 45s the patch passed
          -0 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 59 unchanged - 0 fixed = 62 total (was 59)
          +1 mvnsite 0m 58s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 59s the patch passed
          +1 javadoc 0m 40s the patch passed
          -1 unit 81m 47s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          103m 52s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10922
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832632/HDFS-10922.08.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6e77769bb5d4 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 96b1266
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17099/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17099/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17099/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17099/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 34s trunk passed +1 compile 0m 56s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 54s trunk passed +1 javadoc 0m 48s trunk passed +1 mvninstall 0m 57s the patch passed +1 compile 0m 45s the patch passed +1 javac 0m 45s the patch passed -0 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 59 unchanged - 0 fixed = 62 total (was 59) +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 59s the patch passed +1 javadoc 0m 40s the patch passed -1 unit 81m 47s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 103m 52s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832632/HDFS-10922.08.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6e77769bb5d4 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 96b1266 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17099/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17099/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17099/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17099/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cheersyang Weiwei Yang added a comment -

          I will add

          1. testHDFSTrashPermission
          2. testMoveEmptyDirToTrash

          in TestHDFSTrash by reusing TestTrash#testTrashPermission and TestTrash#testMoveEmptyDirToTrash once HADOOP-13686 gets done. Locally tested it worked fine.

          The test failure was not related, it is a known issue tracking by HDFS-10499.

          Show
          cheersyang Weiwei Yang added a comment - I will add testHDFSTrashPermission testMoveEmptyDirToTrash in TestHDFSTrash by reusing TestTrash#testTrashPermission and TestTrash#testMoveEmptyDirToTrash once HADOOP-13686 gets done. Locally tested it worked fine. The test failure was not related, it is a known issue tracking by HDFS-10499 .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 49s trunk passed
          +1 compile 0m 44s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 50s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 43s trunk passed
          +1 javadoc 0m 40s trunk passed
          +1 mvninstall 0m 44s the patch passed
          +1 compile 0m 40s the patch passed
          +1 javac 0m 40s the patch passed
          -0 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 7 new + 59 unchanged - 0 fixed = 66 total (was 59)
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 9s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 43s the patch passed
          +1 javadoc 0m 36s the patch passed
          -1 unit 56m 19s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          76m 36s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestErasureCodeBenchmarkThroughput



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10922
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833320/HDFS-10922.09.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6c3ecc1c8bd0 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / dbe663d
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17153/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17153/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17153/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17153/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 49s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 43s trunk passed +1 javadoc 0m 40s trunk passed +1 mvninstall 0m 44s the patch passed +1 compile 0m 40s the patch passed +1 javac 0m 40s the patch passed -0 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 7 new + 59 unchanged - 0 fixed = 66 total (was 59) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 43s the patch passed +1 javadoc 0m 36s the patch passed -1 unit 56m 19s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 76m 36s Reason Tests Failed junit tests hadoop.hdfs.TestErasureCodeBenchmarkThroughput Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833320/HDFS-10922.09.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6c3ecc1c8bd0 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dbe663d Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17153/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17153/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17153/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17153/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cheersyang Weiwei Yang added a comment -

          Attached v10 patch that resolved the checkstyle issues.

          Show
          cheersyang Weiwei Yang added a comment - Attached v10 patch that resolved the checkstyle issues.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 22s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 25s trunk passed
          +1 compile 0m 44s trunk passed
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 0m 51s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 42s trunk passed
          +1 javadoc 0m 42s trunk passed
          +1 mvninstall 0m 53s the patch passed
          +1 compile 0m 49s the patch passed
          +1 javac 0m 49s the patch passed
          -0 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 59 unchanged - 0 fixed = 62 total (was 59)
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 2s the patch passed
          +1 javadoc 0m 41s the patch passed
          -1 unit 78m 26s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          98m 38s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.qjournal.client.TestQuorumJournalManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10922
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833331/HDFS-10922.10.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7b3168cc28d6 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / dbe663d
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17155/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17155/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17155/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17155/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 25s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 42s trunk passed +1 javadoc 0m 42s trunk passed +1 mvninstall 0m 53s the patch passed +1 compile 0m 49s the patch passed +1 javac 0m 49s the patch passed -0 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 59 unchanged - 0 fixed = 62 total (was 59) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 2s the patch passed +1 javadoc 0m 41s the patch passed -1 unit 78m 26s hadoop-hdfs in the patch failed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 98m 38s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.qjournal.client.TestQuorumJournalManager Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833331/HDFS-10922.10.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7b3168cc28d6 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dbe663d Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17155/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17155/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17155/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17155/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 36s trunk passed
          +1 compile 0m 44s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 51s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 39s trunk passed
          +1 javadoc 0m 40s trunk passed
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 42s the patch passed
          +1 javac 0m 42s the patch passed
          +1 checkstyle 0m 23s the patch passed
          +1 mvnsite 0m 49s the patch passed
          +1 mvneclipse 0m 9s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 48s the patch passed
          +1 javadoc 0m 36s the patch passed
          +1 unit 57m 55s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          76m 2s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10922
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833359/HDFS-10922.11.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e5f9c1ddc217 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / dbe663d
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17157/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17157/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 36s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 39s trunk passed +1 javadoc 0m 40s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 36s the patch passed +1 unit 57m 55s hadoop-hdfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 76m 2s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833359/HDFS-10922.11.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e5f9c1ddc217 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dbe663d Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17157/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17157/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cheersyang Weiwei Yang added a comment -

          Hello Xiaoyu Yao

          v11 patch is ready for review now, it contains following changes

          1. Moved an existing permission check test from TestDFSPermission to TestHDFSTrash, renamed to testMoveUnprivilegedDirToTrash
          2. Added a test case testHDFSTrashPermission by reusing the test case in TestTrash
          3. Added a test case testMoveEmptyDirToTrash by reusing the test case in TestTrash
          4. Added a test case testDeleteTrash to verify an user cannot delete other user's trash dir

          Note that I did not add a test for #4 in the original proposal here, because it is already addressed in TestTrash#testTrashRestarts via HADOOP-13686.

          Please let me know if you have any other comments.

          Thanks!

          Show
          cheersyang Weiwei Yang added a comment - Hello Xiaoyu Yao v11 patch is ready for review now, it contains following changes Moved an existing permission check test from TestDFSPermission to TestHDFSTrash, renamed to testMoveUnprivilegedDirToTrash Added a test case testHDFSTrashPermission by reusing the test case in TestTrash Added a test case testMoveEmptyDirToTrash by reusing the test case in TestTrash Added a test case testDeleteTrash to verify an user cannot delete other user's trash dir Note that I did not add a test for #4 in the original proposal here , because it is already addressed in TestTrash#testTrashRestarts via HADOOP-13686 . Please let me know if you have any other comments. Thanks!
          Hide
          xyao Xiaoyu Yao added a comment -

          Weiwei Yang, thanks for the update. It looks good to me overall. Here are my comments:

          1. Can we replace the "import static org.junit.Assert.*" with

          import static org.junit.Assert.assertEquals;
          import static org.junit.Assert.assertFalse;
          import static org.junit.Assert.assertTrue;
          import static org.junit.Assert.fail;
          

          2. NIT: can we replace usage of "DFSConfigKeys.FS_DEFAULT_NAME_KEY" with "CommonConfigurationKeys.FS_TRASH_INTERVAL_KEY" for consistency.

          3. Many of the mergePaths call is not necessary. It can be simplified like below

              Path user1Tmp = Path.mergePaths(TEST_ROOT, new Path("/test-del-u1"));
          

          to

              Path user1Tmp = new Path(TEST_ROOT, "test-del-u1");
          

          4. Can we remove the e.printStackTrace(); from testMoveUnprivilegedDirToTrash()?

          5. TestHDFSTrash#login() can we move it into DFSTestUtil for reusing in both TestHDFSTrash and TestDFSPermission?
          The conf will need to be a parameter as we usually change configuration with a new configuration instance during the test.

          6. TestHDFSTrash#verifyFilePermission can be moved into DFSTestUtil.

          Show
          xyao Xiaoyu Yao added a comment - Weiwei Yang , thanks for the update. It looks good to me overall. Here are my comments: 1. Can we replace the "import static org.junit.Assert.*" with import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; 2. NIT: can we replace usage of "DFSConfigKeys.FS_DEFAULT_NAME_KEY" with "CommonConfigurationKeys.FS_TRASH_INTERVAL_KEY" for consistency. 3. Many of the mergePaths call is not necessary. It can be simplified like below Path user1Tmp = Path.mergePaths(TEST_ROOT, new Path( "/test-del-u1" )); to Path user1Tmp = new Path(TEST_ROOT, "test-del-u1" ); 4. Can we remove the e.printStackTrace(); from testMoveUnprivilegedDirToTrash()? 5. TestHDFSTrash#login() can we move it into DFSTestUtil for reusing in both TestHDFSTrash and TestDFSPermission? The conf will need to be a parameter as we usually change configuration with a new configuration instance during the test. 6. TestHDFSTrash#verifyFilePermission can be moved into DFSTestUtil.
          Hide
          cheersyang Weiwei Yang added a comment -

          Thanks Xiaoyu Yao for your comments. I have addressed all of them in the latest v12 patch.

          Show
          cheersyang Weiwei Yang added a comment - Thanks Xiaoyu Yao for your comments. I have addressed all of them in the latest v12 patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 6m 54s trunk passed
          +1 compile 0m 43s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 50s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 44s trunk passed
          +1 javadoc 0m 41s trunk passed
          +1 mvninstall 0m 57s the patch passed
          +1 compile 0m 48s the patch passed
          +1 javac 0m 48s the patch passed
          +1 checkstyle 0m 27s the patch passed
          +1 mvnsite 0m 57s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 6s the patch passed
          +1 javadoc 0m 38s the patch passed
          -1 unit 64m 6s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          83m 36s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
            hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
            hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10922
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833424/HDFS-10922.12.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 49a44be6fd8e 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 701c27a
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17164/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17164/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17164/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 6m 54s trunk passed +1 compile 0m 43s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 44s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 57s the patch passed +1 compile 0m 48s the patch passed +1 javac 0m 48s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 6s the patch passed +1 javadoc 0m 38s the patch passed -1 unit 64m 6s hadoop-hdfs in the patch failed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 83m 36s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833424/HDFS-10922.12.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 49a44be6fd8e 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 701c27a Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17164/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17164/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17164/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment -

          +1 for v12 patch. I will commit it shortly.

          Show
          xyao Xiaoyu Yao added a comment - +1 for v12 patch. I will commit it shortly.
          Hide
          xyao Xiaoyu Yao added a comment -

          Weiwei Yang, DFSTestUtil#writeFile(FileSystem fs, Path p, byte[] bytes) from HDFS-8517 is not available from branch-2 and branch-2.8.
          Can you post a patch using FileSystemTestWrapper#writeFile(Path path, byte b[]) instead? Thanks!

          Show
          xyao Xiaoyu Yao added a comment - Weiwei Yang , DFSTestUtil#writeFile(FileSystem fs, Path p, byte[] bytes) from HDFS-8517 is not available from branch-2 and branch-2.8. Can you post a patch using FileSystemTestWrapper#writeFile(Path path, byte b[]) instead? Thanks!
          Hide
          cheersyang Weiwei Yang added a comment -

          Hello Xiaoyu Yao

          I need your suggestion about branch-2 and branch-2.8. TestHDFSTrash#testMoveUnprivilegedDirToTrash was added when I fixed HDFS-8312, without that JIRA committed to branch-2 and branch-2.8 (that one is only in 2.9), this case will fail. So there are three options

          1. Commit this one only to 2.9 and trunk
          2. Remove testMoveUnprivilegedDirToTrash and commit the rest of patch to branch-2 and branch-2.8
          3. Back port HDFS-8312 to branch-2 and branch-2.8, then commit this one to both branches

          which one do you prefer, please let me know.

          Show
          cheersyang Weiwei Yang added a comment - Hello Xiaoyu Yao I need your suggestion about branch-2 and branch-2.8. TestHDFSTrash#testMoveUnprivilegedDirToTrash was added when I fixed HDFS-8312 , without that JIRA committed to branch-2 and branch-2.8 (that one is only in 2.9), this case will fail. So there are three options Commit this one only to 2.9 and trunk Remove testMoveUnprivilegedDirToTrash and commit the rest of patch to branch-2 and branch-2.8 Back port HDFS-8312 to branch-2 and branch-2.8, then commit this one to both branches which one do you prefer, please let me know.
          Hide
          liuml07 Mingliang Liu added a comment - - edited

          I always prefer these JIRAs being backported to branch-2.8 if possible. Thanks.

          Show
          liuml07 Mingliang Liu added a comment - - edited I always prefer these JIRAs being backported to branch-2.8 if possible. Thanks.
          Hide
          cheersyang Weiwei Yang added a comment -

          Hi Xiaoyu Yao and Mingliang Liu

          The 3 options, I would like to go with #2 to keep JIRAs independent, the back port, lets use HDFS-8312 to track, how does that work for you? I will create patches for trunk, branch-2 and branch-2.8 for this ticket.

          Show
          cheersyang Weiwei Yang added a comment - Hi Xiaoyu Yao and Mingliang Liu The 3 options, I would like to go with #2 to keep JIRAs independent, the back port, lets use HDFS-8312 to track, how does that work for you? I will create patches for trunk, branch-2 and branch-2.8 for this ticket.
          Hide
          cheersyang Weiwei Yang added a comment -

          Branch-2 is currently broken (compilation error) by HADOOP-13707, I will upload a patch for branch-2 once that is resolved.

          Show
          cheersyang Weiwei Yang added a comment - Branch-2 is currently broken (compilation error) by HADOOP-13707 , I will upload a patch for branch-2 once that is resolved.
          Hide
          cheersyang Weiwei Yang added a comment -

          Patch uploaded.

          Trunk : HDFS-10922.13.patch
          Branch-2 : HDFS-10922-branch-2.01.patch
          Branch-2.8 : HDFS-10922-branch-2.8.01.patch

          Show
          cheersyang Weiwei Yang added a comment - Patch uploaded. Trunk : HDFS-10922 .13.patch Branch-2 : HDFS-10922 -branch-2.01.patch Branch-2.8 : HDFS-10922 -branch-2.8.01.patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 26s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 7m 26s branch-2.8 passed
          +1 compile 0m 39s branch-2.8 passed with JDK v1.8.0_101
          +1 compile 0m 44s branch-2.8 passed with JDK v1.7.0_111
          +1 checkstyle 0m 21s branch-2.8 passed
          +1 mvnsite 0m 56s branch-2.8 passed
          +1 mvneclipse 0m 16s branch-2.8 passed
          +1 findbugs 2m 3s branch-2.8 passed
          +1 javadoc 1m 2s branch-2.8 passed with JDK v1.8.0_101
          +1 javadoc 1m 43s branch-2.8 passed with JDK v1.7.0_111
          +1 mvninstall 0m 47s the patch passed
          +1 compile 0m 39s the patch passed with JDK v1.8.0_101
          +1 javac 0m 39s the patch passed
          +1 compile 0m 41s the patch passed with JDK v1.7.0_111
          +1 javac 0m 41s the patch passed
          +1 checkstyle 0m 18s the patch passed
          +1 mvnsite 0m 55s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 15s the patch passed
          +1 javadoc 1m 2s the patch passed with JDK v1.8.0_101
          +1 javadoc 1m 47s the patch passed with JDK v1.7.0_111
          -1 unit 61m 40s hadoop-hdfs in the patch failed with JDK v1.7.0_111.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          151m 20s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestHDFSTrash
          JDK v1.7.0_111 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeLifeline
            hadoop.hdfs.TestHDFSTrash



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Issue HDFS-10922
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833673/HDFS-10922-branch-2.8.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b1e6f5122099 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / 74782e7
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17178/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17178/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17178/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 7m 26s branch-2.8 passed +1 compile 0m 39s branch-2.8 passed with JDK v1.8.0_101 +1 compile 0m 44s branch-2.8 passed with JDK v1.7.0_111 +1 checkstyle 0m 21s branch-2.8 passed +1 mvnsite 0m 56s branch-2.8 passed +1 mvneclipse 0m 16s branch-2.8 passed +1 findbugs 2m 3s branch-2.8 passed +1 javadoc 1m 2s branch-2.8 passed with JDK v1.8.0_101 +1 javadoc 1m 43s branch-2.8 passed with JDK v1.7.0_111 +1 mvninstall 0m 47s the patch passed +1 compile 0m 39s the patch passed with JDK v1.8.0_101 +1 javac 0m 39s the patch passed +1 compile 0m 41s the patch passed with JDK v1.7.0_111 +1 javac 0m 41s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 15s the patch passed +1 javadoc 1m 2s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 47s the patch passed with JDK v1.7.0_111 -1 unit 61m 40s hadoop-hdfs in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 151m 20s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestHDFSTrash JDK v1.7.0_111 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeLifeline   hadoop.hdfs.TestHDFSTrash Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Issue HDFS-10922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833673/HDFS-10922-branch-2.8.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b1e6f5122099 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 74782e7 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17178/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17178/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17178/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cheersyang Weiwei Yang added a comment -

          The UT failure was because

          The TEST_DIR in TestTrash uses

          private final static Path TEST_DIR =
              new Path(new File(System.getProperty("test.build.data","/tmp")
                    ).toURI().toString().replace(' ', '+'), "testTrash");
          

          instead of (code in branch-2 and trunk)

           private final static Path TEST_DIR = new Path(GenericTestUtils.getTempPath(
                "testTrash"));
          

          this will cause the path starts with schema "file://". This will cause this var can only be used in local file system, and fail when reusing this in other file system. Unfortunately HADOOP-12984 was not committed to branch 2.8. This could be easily fixed, do I need another HADOOP ticket or include the fix in a new patch here?

          Show
          cheersyang Weiwei Yang added a comment - The UT failure was because The TEST_DIR in TestTrash uses private final static Path TEST_DIR = new Path( new File( System .getProperty( "test.build.data" , "/tmp" ) ).toURI().toString().replace(' ', '+'), "testTrash" ); instead of (code in branch-2 and trunk) private final static Path TEST_DIR = new Path(GenericTestUtils.getTempPath( "testTrash" )); this will cause the path starts with schema "file://" . This will cause this var can only be used in local file system, and fail when reusing this in other file system. Unfortunately HADOOP-12984 was not committed to branch 2.8. This could be easily fixed, do I need another HADOOP ticket or include the fix in a new patch here?
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 33s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 7m 39s branch-2 passed
          +1 compile 0m 48s branch-2 passed with JDK v1.8.0_101
          +1 compile 0m 50s branch-2 passed with JDK v1.7.0_111
          +1 checkstyle 0m 31s branch-2 passed
          +1 mvnsite 0m 54s branch-2 passed
          +1 mvneclipse 0m 15s branch-2 passed
          +1 findbugs 1m 55s branch-2 passed
          +1 javadoc 0m 54s branch-2 passed with JDK v1.8.0_101
          +1 javadoc 1m 35s branch-2 passed with JDK v1.7.0_111
          +1 mvninstall 0m 43s the patch passed
          +1 compile 0m 36s the patch passed with JDK v1.8.0_101
          +1 javac 0m 36s the patch passed
          +1 compile 0m 42s the patch passed with JDK v1.7.0_111
          +1 javac 0m 42s the patch passed
          +1 checkstyle 0m 26s the patch passed
          +1 mvnsite 0m 49s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 5s the patch passed
          +1 javadoc 0m 52s the patch passed with JDK v1.8.0_101
          +1 javadoc 1m 34s the patch passed with JDK v1.7.0_111
          +1 unit 60m 58s hadoop-hdfs in the patch passed with JDK v1.7.0_111.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          147m 12s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.hdfs.TestRollingUpgrade



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HDFS-10922
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833690/HDFS-10922-branch-2.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 06ea94b3132d 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / a4356bb
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17180/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17180/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 33s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 7m 39s branch-2 passed +1 compile 0m 48s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 50s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 31s branch-2 passed +1 mvnsite 0m 54s branch-2 passed +1 mvneclipse 0m 15s branch-2 passed +1 findbugs 1m 55s branch-2 passed +1 javadoc 0m 54s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 35s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 43s the patch passed +1 compile 0m 36s the patch passed with JDK v1.8.0_101 +1 javac 0m 36s the patch passed +1 compile 0m 42s the patch passed with JDK v1.7.0_111 +1 javac 0m 42s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 5s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 34s the patch passed with JDK v1.7.0_111 +1 unit 60m 58s hadoop-hdfs in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 147m 12s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.TestRollingUpgrade Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-10922 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833690/HDFS-10922-branch-2.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 06ea94b3132d 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / a4356bb Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17180/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17180/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment - - edited

          I would like to go with #2 to keep JIRAs independent, the back port, lets use HDFS-8312 to track, how does that work for you? I will create patches for trunk, branch-2 and branch-2.8 for this ticket.

          +1 for using HDFS-8312 to track the changes with additional dependency that is missing in branch-2.8. I will review the patches today.

          Show
          xyao Xiaoyu Yao added a comment - - edited I would like to go with #2 to keep JIRAs independent, the back port, lets use HDFS-8312 to track, how does that work for you? I will create patches for trunk, branch-2 and branch-2.8 for this ticket. +1 for using HDFS-8312 to track the changes with additional dependency that is missing in branch-2.8. I will review the patches today.
          Hide
          xyao Xiaoyu Yao added a comment -

          Unfortunately HADOOP-12984 was not committed to branch 2.8. This could be easily fixed, do I need another HADOOP ticket or include the fix in a new patch here?

          I'm proposing to port HADOOP-12984 to branch-2.8.

          Show
          xyao Xiaoyu Yao added a comment - Unfortunately HADOOP-12984 was not committed to branch 2.8. This could be easily fixed, do I need another HADOOP ticket or include the fix in a new patch here? I'm proposing to port HADOOP-12984 to branch-2.8.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Weiwei Yang for the contribution. I've commit the change to trunk and branch-2. I will commit the change to branch-2.8 along with HADOOP-12984 by tomorrow.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Weiwei Yang for the contribution. I've commit the change to trunk and branch-2. I will commit the change to branch-2.8 along with HADOOP-12984 by tomorrow.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10627 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10627/)
          HDFS-10922. Adding additional unit tests for Trash (II). Contributed by (xyao: rev 8fd4c37c45585d761d279f2f6032ff9c6c049895)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10627 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10627/ ) HDFS-10922 . Adding additional unit tests for Trash (II). Contributed by (xyao: rev 8fd4c37c45585d761d279f2f6032ff9c6c049895) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSPermission.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSTrash.java
          Hide
          cheersyang Weiwei Yang added a comment -

          Great thanks a lot Xiaoyu Yao

          Show
          cheersyang Weiwei Yang added a comment - Great thanks a lot Xiaoyu Yao

            People

            • Assignee:
              cheersyang Weiwei Yang
              Reporter:
              xyao Xiaoyu Yao
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development