Details

    • Type: Test
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This ticket is opened to track adding the forllowing unit test in hadoop-common.
      #test users can delete their own trash directory
      #test users can delete an empty directory and the directory is moved to trash
      #test fs.trash.interval with invalid values such as 0 or negative

      1. HADOOP-13686.01.patch
        14 kB
        Weiwei Yang
      2. HADOOP-13686.02.patch
        15 kB
        Weiwei Yang
      3. HADOOP-13686.03.patch
        16 kB
        Weiwei Yang
      4. HADOOP-13686.04.patch
        15 kB
        Weiwei Yang
      5. HADOOP-13686.05.patch
        15 kB
        Weiwei Yang
      6. HADOOP-13686.06.patch
        15 kB
        Weiwei Yang
      7. HADOOP-13686.07.patch
        15 kB
        Weiwei Yang
      8. HADOOP-13686-branch-2.8.01.patch
        15 kB
        Weiwei Yang

        Issue Links

          Activity

          Hide
          cheersyang Weiwei Yang added a comment -

          Added following tests

          1. testCheckpointInterval this test sets multiple values (legal and illegal) to fs.trash.checkpoint.interval and verify the values are set in emptier as expected.
          2. testTrashPermission this test verifies when files moved to trash, file permission is reserved. And user is able to remove their own trash directory.
          3. testMoveEmptyDirToTrash this test user is able to move an empty directory to trash.
          4. testTrashRestarts this tests simulates a restart of the parent process (NN), verifies fs.trash.interval is honoured during restart.

          Some more things

          3. test fs.trash.interval with invalid values such as 0 or negative

          This is already covered so it's not in this patch. TestTrash#trashShell tested setting value to 0. TestStateTransitionFailure tested setting a negative value. Namenode will not be started with error "Cannot start trash emptier with negative interval. Set fs.trash.interval to a positive value".

          And this patch fixed an issue that setting a negative value to fs.trash.checkpoint.interval is not handled in TrashPolicyDefault.

          Show
          cheersyang Weiwei Yang added a comment - Added following tests testCheckpointInterval this test sets multiple values (legal and illegal) to fs.trash.checkpoint.interval and verify the values are set in emptier as expected. testTrashPermission this test verifies when files moved to trash, file permission is reserved. And user is able to remove their own trash directory. testMoveEmptyDirToTrash this test user is able to move an empty directory to trash. testTrashRestarts this tests simulates a restart of the parent process (NN), verifies fs.trash.interval is honoured during restart. Some more things 3. test fs.trash.interval with invalid values such as 0 or negative This is already covered so it's not in this patch. TestTrash#trashShell tested setting value to 0. TestStateTransitionFailure tested setting a negative value. Namenode will not be started with error "Cannot start trash emptier with negative interval. Set fs.trash.interval to a positive value". And this patch fixed an issue that setting a negative value to fs.trash.checkpoint.interval is not handled in TrashPolicyDefault .
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 36s trunk passed
          +1 compile 7m 18s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 1m 8s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 32s trunk passed
          +1 javadoc 0m 45s trunk passed
          +1 mvninstall 0m 42s the patch passed
          +1 compile 8m 23s the patch passed
          +1 javac 8m 23s the patch passed
          +1 checkstyle 0m 25s the patch passed
          +1 mvnsite 1m 6s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 44s the patch passed
          +1 javadoc 0m 45s the patch passed
          +1 unit 9m 14s hadoop-common in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          42m 38s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13686
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832268/HADOOP-13686.01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2251e5b0c0b2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4d10621
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10712/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10712/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 36s trunk passed +1 compile 7m 18s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 1m 8s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 32s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 42s the patch passed +1 compile 8m 23s the patch passed +1 javac 8m 23s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 1m 6s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 44s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 9m 14s hadoop-common in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 42m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13686 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832268/HADOOP-13686.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2251e5b0c0b2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4d10621 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10712/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10712/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cheersyang Weiwei Yang added a comment -

          Hello Xiaoyu Yao

          The patch is ready for review now, can you please help to kindly review? Thanks a lot.

          Show
          cheersyang Weiwei Yang added a comment - Hello Xiaoyu Yao The patch is ready for review now, can you please help to kindly review? Thanks a lot.
          Hide
          xyao Xiaoyu Yao added a comment - - edited

          Thanks WEIWEI YANG for working on this. The patch looks good to me overall. Here are some early feedbacks.

          1. testMoveEmptyDirToTrash

          Can we add a helper method by passing a FileSystem obj as parameter
          so that this test can be used to test Trash with not only raw file system but also
          other HCFS?

          Can we further verify that the only directory under trash is the empty directory?

          verifyDefaultPolicyIntervalValues
          FileSystem fs = null; can be removed.

          2. testTrashPermission
          Can we add a helper method by passing a FileSystem obj as parameter
          so that this test can be used to test Trash with not only raw file system but also
          other HCFS?

          3. NIT: Can we use try with resource to simplify the logic?

          try {
          } finally {
          698	      if(fs != null) {
          699	        fs.close();
          700	      }
          701	    }
          

          4. Let's move AuditableTrashPolicy/AuditableCheckpoints in a separate file for reusing with HDFS-10922.

          5. NIT: AuditableCheckpoints: can be a static class. But I would suggest we
          declare the members var/methods to be non-static. This can avoid issues when
          running multiple AuditableTrashPolicy instances.

          Show
          xyao Xiaoyu Yao added a comment - - edited Thanks WEIWEI YANG for working on this. The patch looks good to me overall. Here are some early feedbacks. 1. testMoveEmptyDirToTrash Can we add a helper method by passing a FileSystem obj as parameter so that this test can be used to test Trash with not only raw file system but also other HCFS? Can we further verify that the only directory under trash is the empty directory? verifyDefaultPolicyIntervalValues FileSystem fs = null; can be removed. 2. testTrashPermission Can we add a helper method by passing a FileSystem obj as parameter so that this test can be used to test Trash with not only raw file system but also other HCFS? 3. NIT: Can we use try with resource to simplify the logic? try { } finally { 698 if (fs != null ) { 699 fs.close(); 700 } 701 } 4. Let's move AuditableTrashPolicy/AuditableCheckpoints in a separate file for reusing with HDFS-10922 . 5. NIT: AuditableCheckpoints: can be a static class. But I would suggest we declare the members var/methods to be non-static. This can avoid issues when running multiple AuditableTrashPolicy instances.
          Hide
          cheersyang Weiwei Yang added a comment -

          Hello Xiaoyu Yao

          Thanks for your comments, it's helpful. I have addressed #1, #2 and #3 in v2 patch. But I am a little hesitated to do #4 and #5. I don't think HDFS-10922 will use AuditableTrashPolicy/AuditableCheckpoints, they are helper classes to verify trash intervals in testTrashRestarts, I can't see how to reuse it in HDFS trash tests. Regarding to #5, I used static AuditableCheckpoints and static vars, because I need to share checkpoint states between multiple instances of trash policies while simulating restart, I used atom integer to avoid thread safety problem.

          Once this one is committed, I will add test case in HDFS-10922 to call TestTrash#testMoveEmptyDirToTrash and TestTrash#testTrashPermission, so that to reuse these tests in HDFS. I already tried locally and it worked fine.

          Please let me know how v2 looks, appreciate your help.

          Show
          cheersyang Weiwei Yang added a comment - Hello Xiaoyu Yao Thanks for your comments, it's helpful. I have addressed #1, #2 and #3 in v2 patch. But I am a little hesitated to do #4 and #5. I don't think HDFS-10922 will use AuditableTrashPolicy/AuditableCheckpoints, they are helper classes to verify trash intervals in testTrashRestarts , I can't see how to reuse it in HDFS trash tests. Regarding to #5, I used static AuditableCheckpoints and static vars, because I need to share checkpoint states between multiple instances of trash policies while simulating restart, I used atom integer to avoid thread safety problem. Once this one is committed, I will add test case in HDFS-10922 to call TestTrash#testMoveEmptyDirToTrash and TestTrash#testTrashPermission , so that to reuse these tests in HDFS. I already tried locally and it worked fine. Please let me know how v2 looks, appreciate your help.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 44s trunk passed
          +1 compile 6m 55s trunk passed
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 0m 58s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 20s trunk passed
          +1 javadoc 0m 44s trunk passed
          +1 mvninstall 0m 36s the patch passed
          +1 compile 6m 52s the patch passed
          +1 javac 6m 52s the patch passed
          +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 0 new + 75 unchanged - 1 fixed = 75 total (was 76)
          +1 mvnsite 0m 54s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 29s the patch passed
          +1 javadoc 0m 42s the patch passed
          -1 unit 7m 51s hadoop-common in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          38m 31s



          Reason Tests
          Failed junit tests hadoop.fs.TestTrash



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13686
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832627/HADOOP-13686.02.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 25f6325b0db7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 96b1266
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10730/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10730/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10730/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 44s trunk passed +1 compile 6m 55s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 20s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 6m 52s the patch passed +1 javac 6m 52s the patch passed +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 0 new + 75 unchanged - 1 fixed = 75 total (was 76) +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 29s the patch passed +1 javadoc 0m 42s the patch passed -1 unit 7m 51s hadoop-common in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 38m 31s Reason Tests Failed junit tests hadoop.fs.TestTrash Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13686 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832627/HADOOP-13686.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 25f6325b0db7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 96b1266 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10730/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10730/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10730/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 1m 33s Maven dependency ordering for branch
          +1 mvninstall 6m 43s trunk passed
          +1 compile 6m 48s trunk passed
          +1 checkstyle 1m 26s trunk passed
          +1 mvnsite 1m 49s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 3m 4s trunk passed
          +1 javadoc 1m 27s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 28s the patch passed
          +1 compile 8m 31s the patch passed
          +1 javac 8m 31s the patch passed
          +1 checkstyle 1m 33s root: The patch generated 0 new + 78 unchanged - 1 fixed = 78 total (was 79)
          +1 mvnsite 1m 59s the patch passed
          +1 mvneclipse 0m 32s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 41s the patch passed
          +1 javadoc 1m 32s the patch passed
          -1 unit 8m 3s hadoop-common in the patch failed.
          +1 unit 59m 22s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          134m 22s



          Reason Tests
          Failed junit tests hadoop.fs.TestTrash



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13686
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832685/HADOOP-13686.03.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7dbfce05169c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ecb51b8
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10732/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10732/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10732/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 33s Maven dependency ordering for branch +1 mvninstall 6m 43s trunk passed +1 compile 6m 48s trunk passed +1 checkstyle 1m 26s trunk passed +1 mvnsite 1m 49s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 4s trunk passed +1 javadoc 1m 27s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 28s the patch passed +1 compile 8m 31s the patch passed +1 javac 8m 31s the patch passed +1 checkstyle 1m 33s root: The patch generated 0 new + 78 unchanged - 1 fixed = 78 total (was 79) +1 mvnsite 1m 59s the patch passed +1 mvneclipse 0m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 41s the patch passed +1 javadoc 1m 32s the patch passed -1 unit 8m 3s hadoop-common in the patch failed. +1 unit 59m 22s hadoop-hdfs in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 134m 22s Reason Tests Failed junit tests hadoop.fs.TestTrash Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13686 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832685/HADOOP-13686.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7dbfce05169c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ecb51b8 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10732/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10732/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10732/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Weiwei Yang for the update. patch v3 looks good to me. Two remaining issues:
          1. We need leave the change of TestHDFSTrash.java in HDFS-10922.
          2. Address the Jenkins failures in testTrashPermission.

          I don't think HDFS-10922 will use AuditableTrashPolicy/AuditableCheckpoints, they are helper classes to verify trash intervals in testTrashRestarts, I can't see how to reuse it in HDFS trash tests.

          You are right. I proposed to reuse AuditableTrashPolicy/AuditableCheckpoints because the patch v06 in HDFS-10922 has duplicated code at the time when I review this one. Now that you've updated HDFS-10922. We don't need to address #4 now.

          Regarding to #5, I used static AuditableCheckpoints and static vars, because I need to share checkpoint states between multiple instances of trash policies while simulating restart, I used atom integer to avoid thread safety problem.

          Make sense to me.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Weiwei Yang for the update. patch v3 looks good to me. Two remaining issues: 1. We need leave the change of TestHDFSTrash.java in HDFS-10922 . 2. Address the Jenkins failures in testTrashPermission. I don't think HDFS-10922 will use AuditableTrashPolicy/AuditableCheckpoints, they are helper classes to verify trash intervals in testTrashRestarts, I can't see how to reuse it in HDFS trash tests. You are right. I proposed to reuse AuditableTrashPolicy/AuditableCheckpoints because the patch v06 in HDFS-10922 has duplicated code at the time when I review this one. Now that you've updated HDFS-10922 . We don't need to address #4 now. Regarding to #5, I used static AuditableCheckpoints and static vars, because I need to share checkpoint states between multiple instances of trash policies while simulating restart, I used atom integer to avoid thread safety problem. Make sense to me.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 6s trunk passed
          +1 compile 7m 47s trunk passed
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 1m 9s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 40s trunk passed
          +1 javadoc 0m 50s trunk passed
          -1 mvninstall 0m 43s hadoop-common in the patch failed.
          -1 compile 1m 2s root in the patch failed.
          -1 javac 1m 2s root in the patch failed.
          +1 checkstyle 0m 26s hadoop-common-project/hadoop-common: The patch generated 0 new + 76 unchanged - 1 fixed = 76 total (was 77)
          -1 mvnsite 0m 42s hadoop-common in the patch failed.
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 25s hadoop-common in the patch failed.
          +1 javadoc 0m 42s the patch passed
          -1 unit 0m 44s hadoop-common in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          26m 8s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13686
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832843/HADOOP-13686.04.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 06945d86cbbd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6476934
          Default Java 1.8.0_101
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10740/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/10740/artifact/patchprocess/patch-compile-root.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10740/artifact/patchprocess/patch-compile-root.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/10740/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10740/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10740/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10740/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10740/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 6s trunk passed +1 compile 7m 47s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 9s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 40s trunk passed +1 javadoc 0m 50s trunk passed -1 mvninstall 0m 43s hadoop-common in the patch failed. -1 compile 1m 2s root in the patch failed. -1 javac 1m 2s root in the patch failed. +1 checkstyle 0m 26s hadoop-common-project/hadoop-common: The patch generated 0 new + 76 unchanged - 1 fixed = 76 total (was 77) -1 mvnsite 0m 42s hadoop-common in the patch failed. +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 25s hadoop-common in the patch failed. +1 javadoc 0m 42s the patch passed -1 unit 0m 44s hadoop-common in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 26m 8s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13686 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832843/HADOOP-13686.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 06945d86cbbd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6476934 Default Java 1.8.0_101 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/10740/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/10740/artifact/patchprocess/patch-compile-root.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/10740/artifact/patchprocess/patch-compile-root.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/10740/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10740/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10740/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10740/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10740/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 47s trunk passed
          +1 compile 8m 1s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 26s trunk passed
          +1 javadoc 0m 44s trunk passed
          +1 mvninstall 0m 45s the patch passed
          +1 compile 7m 56s the patch passed
          +1 javac 7m 56s the patch passed
          +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 0 new + 76 unchanged - 1 fixed = 76 total (was 77)
          +1 mvnsite 1m 4s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 34s the patch passed
          +1 javadoc 0m 46s the patch passed
          -1 unit 8m 3s hadoop-common in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          42m 28s



          Reason Tests
          Failed junit tests hadoop.fs.TestTrash



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13686
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832856/HADOOP-13686.05.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 21ef0e91e1c3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6476934
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10741/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10741/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10741/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 47s trunk passed +1 compile 8m 1s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 26s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 7m 56s the patch passed +1 javac 7m 56s the patch passed +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 0 new + 76 unchanged - 1 fixed = 76 total (was 77) +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 34s the patch passed +1 javadoc 0m 46s the patch passed -1 unit 8m 3s hadoop-common in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 42m 28s Reason Tests Failed junit tests hadoop.fs.TestTrash Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13686 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832856/HADOOP-13686.05.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 21ef0e91e1c3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6476934 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10741/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10741/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10741/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 8s trunk passed
          +1 compile 7m 11s trunk passed
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 1m 2s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 25s trunk passed
          +1 javadoc 0m 44s trunk passed
          +1 mvninstall 0m 39s the patch passed
          +1 compile 7m 22s the patch passed
          +1 javac 7m 22s the patch passed
          +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 0 new + 76 unchanged - 1 fixed = 76 total (was 77)
          +1 mvnsite 0m 55s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 30s the patch passed
          +1 javadoc 0m 42s the patch passed
          -1 unit 17m 1s hadoop-common in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          48m 54s



          Reason Tests
          Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13686
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832885/HADOOP-13686.06.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f1648a2ae91f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6476934
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10743/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10743/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10743/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 8s trunk passed +1 compile 7m 11s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 25s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 39s the patch passed +1 compile 7m 22s the patch passed +1 javac 7m 22s the patch passed +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 0 new + 76 unchanged - 1 fixed = 76 total (was 77) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 30s the patch passed +1 javadoc 0m 42s the patch passed -1 unit 17m 1s hadoop-common in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 48m 54s Reason Tests Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13686 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832885/HADOOP-13686.06.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f1648a2ae91f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6476934 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10743/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10743/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10743/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          cheersyang Weiwei Yang added a comment -

          Hello Xiaoyu Yao

          1. I have fixed UT failure in v8 patch, it was because the test gets an old FileSystem instance from cache. So I added FileSystem.closeAll() to fix this problem. It will ensure each test gets a new instance, it should be stable now.
          2. The code change in TestHDFSTrash was added by mistake, I have removed, sorry about that .
          3. The failure TestHttpServerLifecycle in latest jenkins run was not related to this patch, it is a known issue and tracked by HADOOP-13471.

          Please help to review this patch and let know if you have further comments.

          Thank you

          Show
          cheersyang Weiwei Yang added a comment - Hello Xiaoyu Yao I have fixed UT failure in v8 patch, it was because the test gets an old FileSystem instance from cache. So I added FileSystem.closeAll() to fix this problem. It will ensure each test gets a new instance, it should be stable now. The code change in TestHDFSTrash was added by mistake, I have removed, sorry about that . The failure TestHttpServerLifecycle in latest jenkins run was not related to this patch, it is a known issue and tracked by HADOOP-13471 . Please help to review this patch and let know if you have further comments. Thank you
          Hide
          xyao Xiaoyu Yao added a comment -

          Weiwei Yang, can you rebase the patch v06 with the latest trunk changes from HADOOP-13700? Otherwise, looks good to me.

          Show
          xyao Xiaoyu Yao added a comment - Weiwei Yang , can you rebase the patch v06 with the latest trunk changes from HADOOP-13700 ? Otherwise, looks good to me.
          Hide
          cheersyang Weiwei Yang added a comment -

          V7 patch removed the throws IOException in AuditableTrashPolicy#initialize function according to the change of HADOOP-13700. No functional change.

          Show
          cheersyang Weiwei Yang added a comment - V7 patch removed the throws IOException in AuditableTrashPolicy#initialize function according to the change of HADOOP-13700 . No functional change.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 41s trunk passed
          +1 compile 6m 48s trunk passed
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 23s trunk passed
          +1 javadoc 0m 45s trunk passed
          +1 mvninstall 0m 37s the patch passed
          +1 compile 7m 23s the patch passed
          +1 javac 7m 23s the patch passed
          +1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 0 new + 76 unchanged - 1 fixed = 76 total (was 77)
          +1 mvnsite 0m 57s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 32s the patch passed
          +1 javadoc 0m 44s the patch passed
          +1 unit 8m 39s hadoop-common in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          39m 44s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13686
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833276/HADOOP-13686.07.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f621f4f2914b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0a85d07
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10783/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10783/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 41s trunk passed +1 compile 6m 48s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 23s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 7m 23s the patch passed +1 javac 7m 23s the patch passed +1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 0 new + 76 unchanged - 1 fixed = 76 total (was 77) +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 32s the patch passed +1 javadoc 0m 44s the patch passed +1 unit 8m 39s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 39m 44s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13686 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833276/HADOOP-13686.07.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f621f4f2914b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0a85d07 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10783/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10783/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Weiwei Yang for the update. +1 for v7 patch and I will commit it shortly.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Weiwei Yang for the update. +1 for v7 patch and I will commit it shortly.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Weiwei Yang for the contribution. I've commit the patch to trunk, branch-2 and brach-2.8.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Weiwei Yang for the contribution. I've commit the patch to trunk, branch-2 and brach-2.8.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10610 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10610/)
          HADOOP-13686. Adding additional unit test for Trash (I). Contributed by (xyao: rev dbe663d5241feea0c88a3a9391ad48a029001d94)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10610 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10610/ ) HADOOP-13686 . Adding additional unit test for Trash (I). Contributed by (xyao: rev dbe663d5241feea0c88a3a9391ad48a029001d94) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          Hide
          cheersyang Weiwei Yang added a comment - - edited

          Thanks a lot Xiaoyu Yao .

          Show
          cheersyang Weiwei Yang added a comment - - edited Thanks a lot Xiaoyu Yao .
          Hide
          xyao Xiaoyu Yao added a comment -

          Weiwei Yang, can you attach a branch-2.8 patch without using GenericTestUtils.getTempPath()? Thanks!

          Show
          xyao Xiaoyu Yao added a comment - Weiwei Yang , can you attach a branch-2.8 patch without using GenericTestUtils.getTempPath()? Thanks!
          Hide
          cheersyang Weiwei Yang added a comment -

          Sure, attached a patch for branch-2.8. Replaced GenericTestUtils.getTempPath() with TEST_DIR.

          Show
          cheersyang Weiwei Yang added a comment - Sure, attached a patch for branch-2.8. Replaced GenericTestUtils.getTempPath() with TEST_DIR.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Weiwei Yang for the branch-2.8 patch. I've tested it and commit it to branch-2.8.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Weiwei Yang for the branch-2.8 patch. I've tested it and commit it to branch-2.8.

            People

            • Assignee:
              cheersyang Weiwei Yang
              Reporter:
              xyao Xiaoyu Yao
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development