[HDFS-10749] Log refactoring: method invocation should be replaced by variable

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.7.2
• Assignee: Unassigned
• Reporter: Nemo Chen
• Created: 11/Aug/16 14:57
• Updated: 26/Jul/19 11:50
• Resolved: 26/Jul/19 11:50

Description

Similar to the fix for HDFS-409. In file:

hadoop-rel-release-2.7.2/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java

In code block:

lastQueuedSeqno = currentPacket.getSeqno();
if (DFSClient.LOG.isDebugEnabled()) {
    DFSClient.LOG.debug("Queued packet " + currentPacket.getSeqno());
}

currentPacket.getSeqno() is better to be replaced by variable lastQueuedSeqno.

Issue Links

• is superceded by: HDFS-10752 Several log refactoring/improvement suggestion in HDFS