Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10707

Replace org.apache.commons.io.Charsets with java.nio.charset.StandardCharsets

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      org.apache.commons.io.Charsets is deprecated in favor of java.nio.charset.StandardCharsets

      1. HDFS-10707.2.patch
        16 kB
        Vincent Poon
      2. HDFS-10707.3.patch
        18 kB
        Vincent Poon
      3. HDFS-10707.branch-2.patch
        18 kB
        Vincent Poon
      4. HDFS-10707.patch
        17 kB
        Vincent Poon

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 32s Maven dependency ordering for branch
          +1 mvninstall 7m 31s trunk passed
          +1 compile 1m 32s trunk passed
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 2m 1s trunk passed
          +1 mvneclipse 0m 37s trunk passed
          +1 findbugs 3m 45s trunk passed
          +1 javadoc 1m 30s trunk passed
          0 mvndep 0m 6s Maven dependency ordering for patch
          +1 mvninstall 1m 50s the patch passed
          +1 compile 1m 25s the patch passed
          +1 javac 1m 25s the patch passed
          -0 checkstyle 0m 29s hadoop-hdfs-project: The patch generated 8 new + 117 unchanged - 2 fixed = 125 total (was 119)
          +1 mvnsite 1m 48s the patch passed
          +1 mvneclipse 0m 29s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 5s the patch passed
          +1 javadoc 1m 25s the patch passed
          +1 unit 0m 55s hadoop-hdfs-client in the patch passed.
          -1 unit 60m 14s hadoop-hdfs in the patch failed.
          +1 unit 3m 36s hadoop-hdfs-httpfs in the patch passed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          96m 26s



          Reason Tests
          Failed junit tests hadoop.tracing.TestTracing
            hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821092/HDFS-10707.patch
          JIRA Issue HDFS-10707
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3df53e8d0405 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 95f2b98
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16260/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16260/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16260/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16260/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 32s Maven dependency ordering for branch +1 mvninstall 7m 31s trunk passed +1 compile 1m 32s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 2m 1s trunk passed +1 mvneclipse 0m 37s trunk passed +1 findbugs 3m 45s trunk passed +1 javadoc 1m 30s trunk passed 0 mvndep 0m 6s Maven dependency ordering for patch +1 mvninstall 1m 50s the patch passed +1 compile 1m 25s the patch passed +1 javac 1m 25s the patch passed -0 checkstyle 0m 29s hadoop-hdfs-project: The patch generated 8 new + 117 unchanged - 2 fixed = 125 total (was 119) +1 mvnsite 1m 48s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 5s the patch passed +1 javadoc 1m 25s the patch passed +1 unit 0m 55s hadoop-hdfs-client in the patch passed. -1 unit 60m 14s hadoop-hdfs in the patch failed. +1 unit 3m 36s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 96m 26s Reason Tests Failed junit tests hadoop.tracing.TestTracing   hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821092/HDFS-10707.patch JIRA Issue HDFS-10707 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3df53e8d0405 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 95f2b98 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16260/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16260/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16260/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16260/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 8s Maven dependency ordering for branch
          +1 mvninstall 8m 41s trunk passed
          +1 compile 1m 49s trunk passed
          +1 checkstyle 0m 39s trunk passed
          +1 mvnsite 2m 21s trunk passed
          +1 mvneclipse 0m 47s trunk passed
          +1 findbugs 4m 27s trunk passed
          +1 javadoc 1m 48s trunk passed
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 2m 24s the patch passed
          +1 compile 1m 45s the patch passed
          +1 javac 1m 45s the patch passed
          +1 checkstyle 0m 37s hadoop-hdfs-project: The patch generated 0 new + 117 unchanged - 2 fixed = 117 total (was 119)
          +1 mvnsite 2m 19s the patch passed
          +1 mvneclipse 0m 34s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 58s the patch passed
          +1 javadoc 1m 29s the patch passed
          +1 unit 0m 54s hadoop-hdfs-client in the patch passed.
          -1 unit 76m 16s hadoop-hdfs in the patch failed.
          +1 unit 3m 35s hadoop-hdfs-httpfs in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          118m 19s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.TestFileTruncate



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821150/HDFS-10707.2.patch
          JIRA Issue HDFS-10707
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ca63f3460bf8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8d32bd8
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16266/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16266/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16266/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 8m 41s trunk passed +1 compile 1m 49s trunk passed +1 checkstyle 0m 39s trunk passed +1 mvnsite 2m 21s trunk passed +1 mvneclipse 0m 47s trunk passed +1 findbugs 4m 27s trunk passed +1 javadoc 1m 48s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 2m 24s the patch passed +1 compile 1m 45s the patch passed +1 javac 1m 45s the patch passed +1 checkstyle 0m 37s hadoop-hdfs-project: The patch generated 0 new + 117 unchanged - 2 fixed = 117 total (was 119) +1 mvnsite 2m 19s the patch passed +1 mvneclipse 0m 34s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 58s the patch passed +1 javadoc 1m 29s the patch passed +1 unit 0m 54s hadoop-hdfs-client in the patch passed. -1 unit 76m 16s hadoop-hdfs in the patch failed. +1 unit 3m 35s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 118m 19s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821150/HDFS-10707.2.patch JIRA Issue HDFS-10707 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ca63f3460bf8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8d32bd8 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/16266/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16266/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16266/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vincentpoon Vincent Poon added a comment -

          test failure appears to be unrelated

          Show
          vincentpoon Vincent Poon added a comment - test failure appears to be unrelated
          Hide
          busbey Sean Busbey added a comment -

          I agree that the failure looks unrelated. What branches are we targeting? branch-2.8, branch-2, and trunk?

          Show
          busbey Sean Busbey added a comment - I agree that the failure looks unrelated. What branches are we targeting? branch-2.8, branch-2, and trunk?
          Hide
          vincentpoon Vincent Poon added a comment -

          maintain order of imports

          Show
          vincentpoon Vincent Poon added a comment - maintain order of imports
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 50s Maven dependency ordering for branch
          +1 mvninstall 7m 27s trunk passed
          +1 compile 1m 29s trunk passed
          +1 checkstyle 0m 31s trunk passed
          +1 mvnsite 1m 51s trunk passed
          +1 mvneclipse 0m 37s trunk passed
          +1 findbugs 3m 31s trunk passed
          +1 javadoc 1m 30s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 44s the patch passed
          +1 compile 1m 22s the patch passed
          +1 javac 1m 22s the patch passed
          +1 checkstyle 0m 28s hadoop-hdfs-project: The patch generated 0 new + 117 unchanged - 2 fixed = 117 total (was 119)
          +1 mvnsite 1m 43s the patch passed
          +1 mvneclipse 0m 29s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 46s the patch passed
          +1 javadoc 1m 21s the patch passed
          +1 unit 0m 53s hadoop-hdfs-client in the patch passed.
          -1 unit 57m 37s hadoop-hdfs in the patch failed.
          +1 unit 3m 24s hadoop-hdfs-httpfs in the patch passed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          92m 46s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.TestDFSShell



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821254/HDFS-10707.3.patch
          JIRA Issue HDFS-10707
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 96db7713aeba 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 34ccaa8
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16272/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16272/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16272/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 50s Maven dependency ordering for branch +1 mvninstall 7m 27s trunk passed +1 compile 1m 29s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 1m 51s trunk passed +1 mvneclipse 0m 37s trunk passed +1 findbugs 3m 31s trunk passed +1 javadoc 1m 30s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 44s the patch passed +1 compile 1m 22s the patch passed +1 javac 1m 22s the patch passed +1 checkstyle 0m 28s hadoop-hdfs-project: The patch generated 0 new + 117 unchanged - 2 fixed = 117 total (was 119) +1 mvnsite 1m 43s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 46s the patch passed +1 javadoc 1m 21s the patch passed +1 unit 0m 53s hadoop-hdfs-client in the patch passed. -1 unit 57m 37s hadoop-hdfs in the patch failed. +1 unit 3m 24s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 92m 46s Reason Tests Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.TestDFSShell Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821254/HDFS-10707.3.patch JIRA Issue HDFS-10707 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 96db7713aeba 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 34ccaa8 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/16272/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16272/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16272/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I ran all the failed tests locally and they passed. Committing this.

          Show
          ajisakaa Akira Ajisaka added a comment - I ran all the failed tests locally and they passed. Committing this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk. Hi Vincent Poon, would you rebase the patch for branch-2 and branch-2.8?

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Hi Vincent Poon , would you rebase the patch for branch-2 and branch-2.8?
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #10191 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10191/)
          HDFS-10707. Replace org.apache.commons.io.Charsets with (aajisaka: rev a5fb298e56220a35d61b8d2bda716d8fb8ef8bb7)

          • hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSAuthenticationFilter.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirMkdirOp.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/webhdfs/ParameterParser.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestGetBlockLocations.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
          • hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/wsrs/JSONMapProvider.java
          • hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/wsrs/JSONProvider.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/webhdfs/WebHdfsHandler.java
          • hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/client/HttpFSUtils.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10191 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10191/ ) HDFS-10707 . Replace org.apache.commons.io.Charsets with (aajisaka: rev a5fb298e56220a35d61b8d2bda716d8fb8ef8bb7) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSAuthenticationFilter.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageUtil.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirMkdirOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/webhdfs/ParameterParser.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestGetBlockLocations.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/wsrs/JSONMapProvider.java hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/lib/wsrs/JSONProvider.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/webhdfs/WebHdfsHandler.java hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/client/HttpFSUtils.java
          Hide
          vincentpoon Vincent Poon added a comment -

          rebase for branch-2

          Show
          vincentpoon Vincent Poon added a comment - rebase for branch-2
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 14m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 2m 29s Maven dependency ordering for branch
          +1 mvninstall 8m 4s branch-2 passed
          +1 compile 1m 21s branch-2 passed with JDK v1.8.0_101
          +1 compile 1m 31s branch-2 passed with JDK v1.7.0_101
          +1 checkstyle 0m 40s branch-2 passed
          +1 mvnsite 2m 23s branch-2 passed
          +1 mvneclipse 0m 49s branch-2 passed
          -1 findbugs 1m 57s hadoop-hdfs-project/hadoop-hdfs-client in branch-2 has 7 extant Findbugs warnings.
          +1 javadoc 1m 32s branch-2 passed with JDK v1.8.0_101
          +1 javadoc 2m 23s branch-2 passed with JDK v1.7.0_101
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 43s the patch passed
          +1 compile 1m 19s the patch passed with JDK v1.8.0_101
          +1 javac 1m 19s the patch passed
          +1 compile 1m 26s the patch passed with JDK v1.7.0_101
          +1 javac 1m 26s the patch passed
          -0 checkstyle 0m 33s hadoop-hdfs-project: The patch generated 1 new + 115 unchanged - 2 fixed = 116 total (was 117)
          +1 mvnsite 2m 7s the patch passed
          +1 mvneclipse 0m 38s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 5m 15s the patch passed
          +1 javadoc 1m 28s the patch passed with JDK v1.8.0_101
          +1 javadoc 2m 15s the patch passed with JDK v1.7.0_101
          +1 unit 1m 5s hadoop-hdfs-client in the patch passed with JDK v1.7.0_101.
          +1 unit 51m 23s hadoop-hdfs in the patch passed with JDK v1.7.0_101.
          +1 unit 3m 44s hadoop-hdfs-httpfs in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          182m 35s



          Reason Tests
          JDK v1.8.0_101 Timed out junit tests org.apache.hadoop.hdfs.TestReplication



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821675/HDFS-10707.branch-2.patch
          JIRA Issue HDFS-10707
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux af1064a4aa5b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 7e21384
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16294/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16294/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16294/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16294/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 14m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 2m 29s Maven dependency ordering for branch +1 mvninstall 8m 4s branch-2 passed +1 compile 1m 21s branch-2 passed with JDK v1.8.0_101 +1 compile 1m 31s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 0m 40s branch-2 passed +1 mvnsite 2m 23s branch-2 passed +1 mvneclipse 0m 49s branch-2 passed -1 findbugs 1m 57s hadoop-hdfs-project/hadoop-hdfs-client in branch-2 has 7 extant Findbugs warnings. +1 javadoc 1m 32s branch-2 passed with JDK v1.8.0_101 +1 javadoc 2m 23s branch-2 passed with JDK v1.7.0_101 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 43s the patch passed +1 compile 1m 19s the patch passed with JDK v1.8.0_101 +1 javac 1m 19s the patch passed +1 compile 1m 26s the patch passed with JDK v1.7.0_101 +1 javac 1m 26s the patch passed -0 checkstyle 0m 33s hadoop-hdfs-project: The patch generated 1 new + 115 unchanged - 2 fixed = 116 total (was 117) +1 mvnsite 2m 7s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 15s the patch passed +1 javadoc 1m 28s the patch passed with JDK v1.8.0_101 +1 javadoc 2m 15s the patch passed with JDK v1.7.0_101 +1 unit 1m 5s hadoop-hdfs-client in the patch passed with JDK v1.7.0_101. +1 unit 51m 23s hadoop-hdfs in the patch passed with JDK v1.7.0_101. +1 unit 3m 44s hadoop-hdfs-httpfs in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 182m 35s Reason Tests JDK v1.8.0_101 Timed out junit tests org.apache.hadoop.hdfs.TestReplication Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821675/HDFS-10707.branch-2.patch JIRA Issue HDFS-10707 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux af1064a4aa5b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 7e21384 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16294/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16294/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16294/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16294/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Vincent Poon for rebasing the patch! Minor nit:

          FSDirStatAndListingOp.java
          -    final String startAfterString = new String(startAfter, Charsets.UTF_8);
          +    final String startAfterString = new String(startAfter, StandardCharsets.UTF_8);
          

          Would you render the line within 80 chars to fix the checkstyle warning? I'm +1 if that is addressed.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Vincent Poon for rebasing the patch! Minor nit: FSDirStatAndListingOp.java - final String startAfterString = new String (startAfter, Charsets.UTF_8); + final String startAfterString = new String (startAfter, StandardCharsets.UTF_8); Would you render the line within 80 chars to fix the checkstyle warning? I'm +1 if that is addressed.
          Hide
          vincentpoon Vincent Poon added a comment -

          fix style

          Show
          vincentpoon Vincent Poon added a comment - fix style
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 36s Maven dependency ordering for branch
          +1 mvninstall 6m 45s branch-2 passed
          +1 compile 1m 20s branch-2 passed with JDK v1.8.0_101
          +1 compile 1m 25s branch-2 passed with JDK v1.7.0_101
          +1 checkstyle 0m 33s branch-2 passed
          +1 mvnsite 2m 11s branch-2 passed
          +1 mvneclipse 0m 45s branch-2 passed
          -1 findbugs 1m 41s hadoop-hdfs-project/hadoop-hdfs-client in branch-2 has 7 extant Findbugs warnings.
          +1 javadoc 1m 26s branch-2 passed with JDK v1.8.0_101
          +1 javadoc 2m 13s branch-2 passed with JDK v1.7.0_101
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 1m 39s the patch passed
          +1 compile 1m 12s the patch passed with JDK v1.8.0_101
          +1 javac 1m 12s the patch passed
          +1 compile 1m 22s the patch passed with JDK v1.7.0_101
          +1 javac 1m 22s the patch passed
          +1 checkstyle 0m 30s hadoop-hdfs-project: The patch generated 0 new + 115 unchanged - 2 fixed = 115 total (was 117)
          +1 mvnsite 1m 59s the patch passed
          +1 mvneclipse 0m 35s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 44s the patch passed
          +1 javadoc 1m 22s the patch passed with JDK v1.8.0_101
          +1 javadoc 2m 9s the patch passed with JDK v1.7.0_101
          +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_101.
          +1 unit 46m 25s hadoop-hdfs in the patch passed with JDK v1.7.0_101.
          +1 unit 3m 26s hadoop-hdfs-httpfs in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          144m 57s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821895/HDFS-10707.branch-2.patch
          JIRA Issue HDFS-10707
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1cbacf8bedb3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 9a0ac56
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16312/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16312/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16312/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 36s Maven dependency ordering for branch +1 mvninstall 6m 45s branch-2 passed +1 compile 1m 20s branch-2 passed with JDK v1.8.0_101 +1 compile 1m 25s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 0m 33s branch-2 passed +1 mvnsite 2m 11s branch-2 passed +1 mvneclipse 0m 45s branch-2 passed -1 findbugs 1m 41s hadoop-hdfs-project/hadoop-hdfs-client in branch-2 has 7 extant Findbugs warnings. +1 javadoc 1m 26s branch-2 passed with JDK v1.8.0_101 +1 javadoc 2m 13s branch-2 passed with JDK v1.7.0_101 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 39s the patch passed +1 compile 1m 12s the patch passed with JDK v1.8.0_101 +1 javac 1m 12s the patch passed +1 compile 1m 22s the patch passed with JDK v1.7.0_101 +1 javac 1m 22s the patch passed +1 checkstyle 0m 30s hadoop-hdfs-project: The patch generated 0 new + 115 unchanged - 2 fixed = 115 total (was 117) +1 mvnsite 1m 59s the patch passed +1 mvneclipse 0m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 44s the patch passed +1 javadoc 1m 22s the patch passed with JDK v1.8.0_101 +1 javadoc 2m 9s the patch passed with JDK v1.7.0_101 +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_101. +1 unit 46m 25s hadoop-hdfs in the patch passed with JDK v1.7.0_101. +1 unit 3m 26s hadoop-hdfs-httpfs in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 144m 57s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821895/HDFS-10707.branch-2.patch JIRA Issue HDFS-10707 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1cbacf8bedb3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 9a0ac56 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16312/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16312/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16312/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          kihwal Kihwal Lee added a comment -

          +1 for the branch-2 patch. It looks like the checkstyle issue is fixed.

          Show
          kihwal Kihwal Lee added a comment - +1 for the branch-2 patch. It looks like the checkstyle issue is fixed.
          Hide
          kihwal Kihwal Lee added a comment -

          Just committed the rebased patch to branch-2 and branch-2.8.

          Show
          kihwal Kihwal Lee added a comment - Just committed the rebased patch to branch-2 and branch-2.8.

            People

            • Assignee:
              vincentpoon Vincent Poon
              Reporter:
              vincentpoon Vincent Poon
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development