Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13444

Replace org.apache.commons.io.Charsets with java.nio.charset.StandardCharsets

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      org.apache.commons.io.Charsets is deprecated in favor of java.nio.charset.StandardCharsets

      1. HADOOP-13444.2.patch
        45 kB
        Vincent Poon
      2. HADOOP-13444.3.patch
        46 kB
        Vincent Poon
      3. HADOOP-13444.4.patch
        50 kB
        Vincent Poon
      4. HADOOP-13444.5.patch
        50 kB
        Vincent Poon
      5. HADOOP-13444.branch-2.patch
        50 kB
        Vincent Poon
      6. HADOOP-13444.patch
        48 kB
        Vincent Poon

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 8s Maven dependency ordering for branch
          +1 mvninstall 6m 38s trunk passed
          +1 compile 6m 47s trunk passed
          +1 checkstyle 0m 37s trunk passed
          +1 mvnsite 1m 25s trunk passed
          +1 mvneclipse 0m 35s trunk passed
          +1 findbugs 1m 58s trunk passed
          +1 javadoc 1m 10s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 12s the patch passed
          +1 compile 8m 13s the patch passed
          +1 javac 8m 13s the patch passed
          -0 checkstyle 0m 41s hadoop-common-project: The patch generated 18 new + 912 unchanged - 12 fixed = 930 total (was 924)
          +1 mvnsite 1m 35s the patch passed
          +1 mvneclipse 0m 37s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 42s the patch passed
          +1 javadoc 1m 15s the patch passed
          +1 unit 0m 21s hadoop-minikdc in the patch passed.
          -1 unit 16m 50s hadoop-common in the patch failed.
          +1 unit 0m 23s hadoop-nfs in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          58m 20s



          Reason Tests
          Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.ipc.TestRPCWaitForProxy
            hadoop.security.TestGroupsCaching
          Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821088/HADOOP-13444.patch
          JIRA Issue HADOOP-13444
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2b5277e328e7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 95f2b98
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10124/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10124/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10124/testReport/
          modules C: hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10124/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 6m 38s trunk passed +1 compile 6m 47s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 1m 25s trunk passed +1 mvneclipse 0m 35s trunk passed +1 findbugs 1m 58s trunk passed +1 javadoc 1m 10s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 12s the patch passed +1 compile 8m 13s the patch passed +1 javac 8m 13s the patch passed -0 checkstyle 0m 41s hadoop-common-project: The patch generated 18 new + 912 unchanged - 12 fixed = 930 total (was 924) +1 mvnsite 1m 35s the patch passed +1 mvneclipse 0m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 42s the patch passed +1 javadoc 1m 15s the patch passed +1 unit 0m 21s hadoop-minikdc in the patch passed. -1 unit 16m 50s hadoop-common in the patch failed. +1 unit 0m 23s hadoop-nfs in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 58m 20s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.ipc.TestRPCWaitForProxy   hadoop.security.TestGroupsCaching Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821088/HADOOP-13444.patch JIRA Issue HADOOP-13444 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2b5277e328e7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 95f2b98 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10124/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10124/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10124/testReport/ modules C: hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10124/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 27s Maven dependency ordering for branch
          +1 mvninstall 6m 59s trunk passed
          +1 compile 6m 46s trunk passed
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 1m 23s trunk passed
          +1 mvneclipse 0m 35s trunk passed
          +1 findbugs 1m 58s trunk passed
          +1 javadoc 1m 11s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 2s the patch passed
          +1 compile 6m 50s the patch passed
          +1 javac 6m 50s the patch passed
          -0 checkstyle 0m 39s hadoop-common-project: The patch generated 5 new + 913 unchanged - 12 fixed = 918 total (was 925)
          +1 mvnsite 1m 27s the patch passed
          +1 mvneclipse 0m 36s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 33s the patch passed
          +1 javadoc 1m 10s the patch passed
          +1 unit 0m 19s hadoop-minikdc in the patch passed.
          +1 unit 8m 20s hadoop-common in the patch passed.
          +1 unit 0m 24s hadoop-nfs in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          48m 15s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821149/HADOOP-13444.2.patch
          JIRA Issue HADOOP-13444
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 58959d68d014 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3f0bffe
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10127/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10127/testReport/
          modules C: hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10127/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 27s Maven dependency ordering for branch +1 mvninstall 6m 59s trunk passed +1 compile 6m 46s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 1m 23s trunk passed +1 mvneclipse 0m 35s trunk passed +1 findbugs 1m 58s trunk passed +1 javadoc 1m 11s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 2s the patch passed +1 compile 6m 50s the patch passed +1 javac 6m 50s the patch passed -0 checkstyle 0m 39s hadoop-common-project: The patch generated 5 new + 913 unchanged - 12 fixed = 918 total (was 925) +1 mvnsite 1m 27s the patch passed +1 mvneclipse 0m 36s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 33s the patch passed +1 javadoc 1m 10s the patch passed +1 unit 0m 19s hadoop-minikdc in the patch passed. +1 unit 8m 20s hadoop-common in the patch passed. +1 unit 0m 24s hadoop-nfs in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 48m 15s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821149/HADOOP-13444.2.patch JIRA Issue HADOOP-13444 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 58959d68d014 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3f0bffe Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10127/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10127/testReport/ modules C: hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10127/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          busbey Sean Busbey added a comment -

          +1 (non-binding). The checkstyle warnings aren't actually new. It'd be nice to clean up the constant names while we're altering things, but NBD.

          Show
          busbey Sean Busbey added a comment - +1 (non-binding). The checkstyle warnings aren't actually new. It'd be nice to clean up the constant names while we're altering things, but NBD.
          Hide
          busbey Sean Busbey added a comment -

          Doesn't look like I can set target versions. this should go in branch-2, branch-2.8, and trunk (to match up with MAPREDUCE-6746)

          Show
          busbey Sean Busbey added a comment - Doesn't look like I can set target versions. this should go in branch-2, branch-2.8, and trunk (to match up with MAPREDUCE-6746 )
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 8s Maven dependency ordering for branch
          +1 mvninstall 7m 51s trunk passed
          +1 compile 7m 56s trunk passed
          +1 checkstyle 0m 40s trunk passed
          +1 mvnsite 1m 38s trunk passed
          +1 mvneclipse 0m 37s trunk passed
          +1 findbugs 2m 20s trunk passed
          +1 javadoc 1m 18s trunk passed
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 1m 10s the patch passed
          +1 compile 7m 21s the patch passed
          +1 javac 7m 21s the patch passed
          +1 checkstyle 0m 40s hadoop-common-project: The patch generated 0 new + 913 unchanged - 12 fixed = 913 total (was 925)
          +1 mvnsite 1m 23s the patch passed
          +1 mvneclipse 0m 36s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 34s the patch passed
          +1 javadoc 1m 12s the patch passed
          +1 unit 0m 21s hadoop-minikdc in the patch passed.
          -1 unit 7m 42s hadoop-common in the patch failed.
          +1 unit 0m 22s hadoop-nfs in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          51m 3s



          Reason Tests
          Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821226/HADOOP-13444.3.patch
          JIRA Issue HADOOP-13444
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1ef7d076a1ab 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3d191cc
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10133/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10133/testReport/
          modules C: hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10133/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 7m 51s trunk passed +1 compile 7m 56s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 1m 38s trunk passed +1 mvneclipse 0m 37s trunk passed +1 findbugs 2m 20s trunk passed +1 javadoc 1m 18s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 10s the patch passed +1 compile 7m 21s the patch passed +1 javac 7m 21s the patch passed +1 checkstyle 0m 40s hadoop-common-project: The patch generated 0 new + 913 unchanged - 12 fixed = 913 total (was 925) +1 mvnsite 1m 23s the patch passed +1 mvneclipse 0m 36s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 34s the patch passed +1 javadoc 1m 12s the patch passed +1 unit 0m 21s hadoop-minikdc in the patch passed. -1 unit 7m 42s hadoop-common in the patch failed. +1 unit 0m 22s hadoop-nfs in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 51m 3s Reason Tests Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821226/HADOOP-13444.3.patch JIRA Issue HADOOP-13444 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1ef7d076a1ab 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3d191cc Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10133/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10133/testReport/ modules C: hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10133/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vincentpoon Vincent Poon added a comment -

          Fixed the unrelated style issues. Failed test is unrelated.

          Show
          vincentpoon Vincent Poon added a comment - Fixed the unrelated style issues. Failed test is unrelated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Vincent Poon for updating the patch! Mostly looks good to me.
          Minor comment: Would you keep the order of import statements? For example, the following statements

          KeyProvider.java
            import com.google.gson.stream.JsonWriter;
          + import java.nio.charset.StandardCharsets;
            import org.apache.hadoop.classification.InterfaceAudience;
          

          can be replaced as follows:

          KeyProvider.java
            import java.io.OutputStreamWriter;
          + import java.nio.charset.StandardCharsets;
            import java.security.NoSuchAlgorithmException;
          
          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Vincent Poon for updating the patch! Mostly looks good to me. Minor comment: Would you keep the order of import statements? For example, the following statements KeyProvider.java import com.google.gson.stream.JsonWriter; + import java.nio.charset.StandardCharsets; import org.apache.hadoop.classification.InterfaceAudience; can be replaced as follows: KeyProvider.java import java.io.OutputStreamWriter; + import java.nio.charset.StandardCharsets; import java.security.NoSuchAlgorithmException;
          Hide
          vincentpoon Vincent Poon added a comment -

          Maintain order of imports

          Show
          vincentpoon Vincent Poon added a comment - Maintain order of imports
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thank you for the quick response. +1 pending Jenkins.

          Show
          ajisakaa Akira Ajisaka added a comment - Thank you for the quick response. +1 pending Jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 21s Maven dependency ordering for branch
          +1 mvninstall 7m 22s trunk passed
          +1 compile 6m 56s trunk passed
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 1m 37s trunk passed
          +1 mvneclipse 0m 35s trunk passed
          +1 findbugs 2m 1s trunk passed
          +1 javadoc 1m 9s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 0s the patch passed
          +1 compile 6m 45s the patch passed
          +1 javac 6m 45s the patch passed
          -0 checkstyle 0m 38s hadoop-common-project: The patch generated 2 new + 910 unchanged - 15 fixed = 912 total (was 925)
          +1 mvnsite 1m 24s the patch passed
          +1 mvneclipse 0m 36s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 21s the patch passed
          +1 javadoc 1m 11s the patch passed
          +1 unit 0m 21s hadoop-minikdc in the patch passed.
          +1 unit 8m 0s hadoop-common in the patch passed.
          +1 unit 0m 23s hadoop-nfs in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          48m 28s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821250/HADOOP-13444.4.patch
          JIRA Issue HADOOP-13444
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux fcac75845dec 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 34ccaa8
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10134/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10134/testReport/
          modules C: hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10134/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 21s Maven dependency ordering for branch +1 mvninstall 7m 22s trunk passed +1 compile 6m 56s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 1m 37s trunk passed +1 mvneclipse 0m 35s trunk passed +1 findbugs 2m 1s trunk passed +1 javadoc 1m 9s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 0s the patch passed +1 compile 6m 45s the patch passed +1 javac 6m 45s the patch passed -0 checkstyle 0m 38s hadoop-common-project: The patch generated 2 new + 910 unchanged - 15 fixed = 912 total (was 925) +1 mvnsite 1m 24s the patch passed +1 mvneclipse 0m 36s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 21s the patch passed +1 javadoc 1m 11s the patch passed +1 unit 0m 21s hadoop-minikdc in the patch passed. +1 unit 8m 0s hadoop-common in the patch passed. +1 unit 0m 23s hadoop-nfs in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 48m 28s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821250/HADOOP-13444.4.patch JIRA Issue HADOOP-13444 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fcac75845dec 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 34ccaa8 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10134/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10134/testReport/ modules C: hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10134/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 7s Maven dependency ordering for branch
          +1 mvninstall 6m 33s trunk passed
          +1 compile 6m 44s trunk passed
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 1m 25s trunk passed
          +1 mvneclipse 0m 34s trunk passed
          +1 findbugs 1m 56s trunk passed
          +1 javadoc 1m 9s trunk passed
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 0m 59s the patch passed
          +1 compile 7m 51s the patch passed
          +1 javac 7m 51s the patch passed
          +1 checkstyle 0m 41s hadoop-common-project: The patch generated 0 new + 910 unchanged - 15 fixed = 910 total (was 925)
          +1 mvnsite 1m 30s the patch passed
          +1 mvneclipse 0m 38s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 49s the patch passed
          +1 javadoc 1m 14s the patch passed
          +1 unit 0m 21s hadoop-minikdc in the patch passed.
          -1 unit 8m 26s hadoop-common in the patch failed.
          +1 unit 0m 24s hadoop-nfs in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          49m 9s



          Reason Tests
          Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821261/HADOOP-13444.5.patch
          JIRA Issue HADOOP-13444
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 78bfadf134e6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 34ccaa8
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10135/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10135/testReport/
          modules C: hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10135/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 7s Maven dependency ordering for branch +1 mvninstall 6m 33s trunk passed +1 compile 6m 44s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 1m 25s trunk passed +1 mvneclipse 0m 34s trunk passed +1 findbugs 1m 56s trunk passed +1 javadoc 1m 9s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 59s the patch passed +1 compile 7m 51s the patch passed +1 javac 7m 51s the patch passed +1 checkstyle 0m 41s hadoop-common-project: The patch generated 0 new + 910 unchanged - 15 fixed = 910 total (was 925) +1 mvnsite 1m 30s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 49s the patch passed +1 javadoc 1m 14s the patch passed +1 unit 0m 21s hadoop-minikdc in the patch passed. -1 unit 8m 26s hadoop-common in the patch failed. +1 unit 0m 24s hadoop-nfs in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 49m 9s Reason Tests Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821261/HADOOP-13444.5.patch JIRA Issue HADOOP-13444 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 78bfadf134e6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 34ccaa8 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10135/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10135/testReport/ modules C: hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10135/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, checking this in.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, checking this in.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk. Hi Vincent Poon, would you rebase the patch for branch-2 and branch-2.8?

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Hi Vincent Poon , would you rebase the patch for branch-2 and branch-2.8?
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #10186 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10186/)
          HADOOP-13444. Replace org.apache.commons.io.Charsets with (aajisaka: rev 770b5eb2db686275df445be9280e76cc3710ffdc)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcServer.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedIdMapping.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/KMSClientProvider.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/UserProvider.java
          • hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/MiniKdc.java
          • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/MKDIR3Request.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HtmlQuoting.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/LOOKUP3Request.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/BZip2Codec.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
          • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/CREATE3Request.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/Credentials.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestGangliaMetrics.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java
          • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/SYMLINK3Request.java
          • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/REMOVE3Request.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/FileBasedIPList.java
          • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/mount/MountResponse.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/ganglia/AbstractGangliaSink.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Display.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/TableMapping.java
          • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/LINK3Request.java
          • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/oncrpc/XDR.java
          • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/MKNOD3Request.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/DefaultStringifier.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/StreamPumper.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HostsFileReader.java
          • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/FileHandle.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcConstants.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceAdmin.java
          • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/oncrpc/security/CredentialsSys.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/GraphiteSink.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/KeyProvider.java
          • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/RENAME3Request.java
          • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/RMDIR3Request.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10186 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10186/ ) HADOOP-13444 . Replace org.apache.commons.io.Charsets with (aajisaka: rev 770b5eb2db686275df445be9280e76cc3710ffdc) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcServer.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedIdMapping.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/KMSClientProvider.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/UserProvider.java hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/MiniKdc.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/MKDIR3Request.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HtmlQuoting.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/LOOKUP3Request.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/BZip2Codec.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/CREATE3Request.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/Credentials.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/impl/TestGangliaMetrics.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFileDumper.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/SYMLINK3Request.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/REMOVE3Request.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/FileBasedIPList.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/mount/MountResponse.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/ganglia/AbstractGangliaSink.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Display.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/TableMapping.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/LINK3Request.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/oncrpc/XDR.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/MKNOD3Request.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/DefaultStringifier.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/StreamPumper.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HostsFileReader.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/FileHandle.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcConstants.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceAdmin.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/oncrpc/security/CredentialsSys.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/GraphiteSink.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/KeyProvider.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/RENAME3Request.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/RMDIR3Request.java
          Hide
          vincentpoon Vincent Poon added a comment -

          rebased for branch-2 and branch-2.8

          Show
          vincentpoon Vincent Poon added a comment - rebased for branch-2 and branch-2.8
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 7s HADOOP-13444 does not apply to branch-2.5. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821370/HADOOP-13444.branch-2.5.patch
          JIRA Issue HADOOP-13444
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10143/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 7s HADOOP-13444 does not apply to branch-2.5. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821370/HADOOP-13444.branch-2.5.patch JIRA Issue HADOOP-13444 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10143/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vincentpoon Vincent Poon added a comment -

          rebased for branch-2

          Show
          vincentpoon Vincent Poon added a comment - rebased for branch-2
          Hide
          vincentpoon Vincent Poon added a comment -

          rebased for branch-2.8

          Show
          vincentpoon Vincent Poon added a comment - rebased for branch-2.8
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 8m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 3m 24s Maven dependency ordering for branch
          +1 mvninstall 8m 29s branch-2.8 passed
          +1 compile 5m 50s branch-2.8 passed with JDK v1.8.0_101
          +1 compile 6m 54s branch-2.8 passed with JDK v1.7.0_101
          +1 checkstyle 0m 41s branch-2.8 passed
          +1 mvnsite 1m 38s branch-2.8 passed
          +1 mvneclipse 0m 46s branch-2.8 passed
          +1 findbugs 2m 45s branch-2.8 passed
          +1 javadoc 1m 11s branch-2.8 passed with JDK v1.8.0_101
          +1 javadoc 1m 25s branch-2.8 passed with JDK v1.7.0_101
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 10s the patch passed
          +1 compile 5m 53s the patch passed with JDK v1.8.0_101
          +1 javac 5m 53s the patch passed
          +1 compile 6m 57s the patch passed with JDK v1.7.0_101
          +1 javac 6m 57s the patch passed
          -0 checkstyle 0m 39s hadoop-common-project: The patch generated 2 new + 975 unchanged - 15 fixed = 977 total (was 990)
          +1 mvnsite 1m 40s the patch passed
          +1 mvneclipse 0m 44s the patch passed
          -1 whitespace 0m 1s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 findbugs 3m 18s the patch passed
          +1 javadoc 1m 10s the patch passed with JDK v1.8.0_101
          +1 javadoc 1m 28s the patch passed with JDK v1.7.0_101
          +1 unit 0m 35s hadoop-minikdc in the patch passed with JDK v1.7.0_101.
          +1 unit 8m 24s hadoop-common in the patch passed with JDK v1.7.0_101.
          +1 unit 0m 25s hadoop-nfs in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          89m 5s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821374/HADOOP-13444.branch-2.8.patch
          JIRA Issue HADOOP-13444
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8faf68865c2b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / ecb143e
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10144/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10144/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10144/testReport/
          modules C: hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10144/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 8m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 3m 24s Maven dependency ordering for branch +1 mvninstall 8m 29s branch-2.8 passed +1 compile 5m 50s branch-2.8 passed with JDK v1.8.0_101 +1 compile 6m 54s branch-2.8 passed with JDK v1.7.0_101 +1 checkstyle 0m 41s branch-2.8 passed +1 mvnsite 1m 38s branch-2.8 passed +1 mvneclipse 0m 46s branch-2.8 passed +1 findbugs 2m 45s branch-2.8 passed +1 javadoc 1m 11s branch-2.8 passed with JDK v1.8.0_101 +1 javadoc 1m 25s branch-2.8 passed with JDK v1.7.0_101 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 10s the patch passed +1 compile 5m 53s the patch passed with JDK v1.8.0_101 +1 javac 5m 53s the patch passed +1 compile 6m 57s the patch passed with JDK v1.7.0_101 +1 javac 6m 57s the patch passed -0 checkstyle 0m 39s hadoop-common-project: The patch generated 2 new + 975 unchanged - 15 fixed = 977 total (was 990) +1 mvnsite 1m 40s the patch passed +1 mvneclipse 0m 44s the patch passed -1 whitespace 0m 1s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 3m 18s the patch passed +1 javadoc 1m 10s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 28s the patch passed with JDK v1.7.0_101 +1 unit 0m 35s hadoop-minikdc in the patch passed with JDK v1.7.0_101. +1 unit 8m 24s hadoop-common in the patch passed with JDK v1.7.0_101. +1 unit 0m 25s hadoop-nfs in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 89m 5s Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821374/HADOOP-13444.branch-2.8.patch JIRA Issue HADOOP-13444 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8faf68865c2b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / ecb143e Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10144/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10144/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10144/testReport/ modules C: hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10144/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vincentpoon Vincent Poon added a comment -

          rebase for branch-2

          Show
          vincentpoon Vincent Poon added a comment - rebase for branch-2
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 14m 32s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 2m 7s Maven dependency ordering for branch
          +1 mvninstall 7m 56s branch-2 passed
          +1 compile 5m 29s branch-2 passed with JDK v1.8.0_101
          +1 compile 6m 49s branch-2 passed with JDK v1.7.0_101
          +1 checkstyle 0m 43s branch-2 passed
          +1 mvnsite 1m 40s branch-2 passed
          +1 mvneclipse 0m 42s branch-2 passed
          +1 findbugs 2m 48s branch-2 passed
          +1 javadoc 1m 16s branch-2 passed with JDK v1.8.0_101
          +1 javadoc 1m 21s branch-2 passed with JDK v1.7.0_101
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 9s the patch passed
          +1 compile 7m 41s the patch passed with JDK v1.8.0_101
          +1 javac 7m 41s the patch passed
          +1 compile 6m 30s the patch passed with JDK v1.7.0_101
          +1 javac 6m 30s the patch passed
          +1 checkstyle 0m 40s hadoop-common-project: The patch generated 0 new + 928 unchanged - 15 fixed = 928 total (was 943)
          +1 mvnsite 1m 38s the patch passed
          +1 mvneclipse 0m 42s the patch passed
          -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 findbugs 3m 19s the patch passed
          +1 javadoc 1m 10s the patch passed with JDK v1.8.0_101
          +1 javadoc 1m 26s the patch passed with JDK v1.7.0_101
          +1 unit 0m 36s hadoop-minikdc in the patch passed with JDK v1.7.0_101.
          +1 unit 7m 56s hadoop-common in the patch passed with JDK v1.7.0_101.
          +1 unit 0m 26s hadoop-nfs in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 25s The patch does not generate ASF License warnings.
          93m 15s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821427/HADOOP-13444.branch-2.patch
          JIRA Issue HADOOP-13444
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux cf3a98e2147e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 4ad2a73
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10145/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10145/testReport/
          modules C: hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10145/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 14m 32s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 2m 7s Maven dependency ordering for branch +1 mvninstall 7m 56s branch-2 passed +1 compile 5m 29s branch-2 passed with JDK v1.8.0_101 +1 compile 6m 49s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 0m 43s branch-2 passed +1 mvnsite 1m 40s branch-2 passed +1 mvneclipse 0m 42s branch-2 passed +1 findbugs 2m 48s branch-2 passed +1 javadoc 1m 16s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 21s branch-2 passed with JDK v1.7.0_101 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 9s the patch passed +1 compile 7m 41s the patch passed with JDK v1.8.0_101 +1 javac 7m 41s the patch passed +1 compile 6m 30s the patch passed with JDK v1.7.0_101 +1 javac 6m 30s the patch passed +1 checkstyle 0m 40s hadoop-common-project: The patch generated 0 new + 928 unchanged - 15 fixed = 928 total (was 943) +1 mvnsite 1m 38s the patch passed +1 mvneclipse 0m 42s the patch passed -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 3m 19s the patch passed +1 javadoc 1m 10s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 26s the patch passed with JDK v1.7.0_101 +1 unit 0m 36s hadoop-minikdc in the patch passed with JDK v1.7.0_101. +1 unit 7m 56s hadoop-common in the patch passed with JDK v1.7.0_101. +1 unit 0m 26s hadoop-nfs in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 93m 15s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821427/HADOOP-13444.branch-2.patch JIRA Issue HADOOP-13444 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cf3a98e2147e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 4ad2a73 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10145/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10145/testReport/ modules C: hadoop-common-project/hadoop-minikdc hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs U: hadoop-common-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10145/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, thanks Vincent.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, thanks Vincent.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to branch-2 and branch-2.8. Thanks Vincent Poon for the contribution. I'll review HDFS-10707 next.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to branch-2 and branch-2.8. Thanks Vincent Poon for the contribution. I'll review HDFS-10707 next.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          and thanks Sean Busbey for the review.

          Show
          ajisakaa Akira Ajisaka added a comment - and thanks Sean Busbey for the review.

            People

            • Assignee:
              vincentpoon Vincent Poon
              Reporter:
              vincentpoon Vincent Poon
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development