Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha1
    • Component/s: hdfs
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      DFSUtil.bytes2ByteArray does not always properly handle runs of multiple separators, nor does it handle relative paths correctly.

      DFSUtil.byteArray2PathString does not rebuild the path correctly unless the specified range is the entire component array.

      1. HDFS-10655.patch
        9 kB
        Daryn Sharp
      2. HDFS-10655.patch
        8 kB
        Daryn Sharp
      3. HDFS-10655-branch-2.7.patch
        10 kB
        Zhe Zhang

        Issue Links

          Activity

          Hide
          daryn Daryn Sharp added a comment -

          Other than fixing bugs, reuses an empty byte array for the root component.

          Show
          daryn Daryn Sharp added a comment - Other than fixing bugs, reuses an empty byte array for the root component.
          Hide
          daryn Daryn Sharp added a comment -

          Changes overlap so this patch is based on integration of HDFS-10653.

          Show
          daryn Daryn Sharp added a comment - Changes overlap so this patch is based on integration of HDFS-10653 .
          Hide
          daryn Daryn Sharp added a comment -

          Needed a 1-line change to TestFsLimits.

          Show
          daryn Daryn Sharp added a comment - Needed a 1-line change to TestFsLimits.
          Hide
          daryn Daryn Sharp added a comment -

          kicking pre-commit

          Show
          daryn Daryn Sharp added a comment - kicking pre-commit
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 32s trunk passed
          +1 compile 0m 49s trunk passed
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 49s trunk passed
          +1 javadoc 0m 56s trunk passed
          +1 mvninstall 0m 52s the patch passed
          +1 compile 0m 49s the patch passed
          +1 javac 0m 49s the patch passed
          -0 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 67 unchanged - 1 fixed = 68 total (was 68)
          +1 mvnsite 0m 53s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 55s the patch passed
          +1 javadoc 0m 53s the patch passed
          -1 unit 63m 50s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          84m 19s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestFileCorruption
            hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs
            hadoop.cli.TestHDFSCLI



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819453/HDFS-10655.patch
          JIRA Issue HDFS-10655
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f8761aca89b1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / da6adf5
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16193/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16193/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16193/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16193/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 32s trunk passed +1 compile 0m 49s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 49s trunk passed +1 javadoc 0m 56s trunk passed +1 mvninstall 0m 52s the patch passed +1 compile 0m 49s the patch passed +1 javac 0m 49s the patch passed -0 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 67 unchanged - 1 fixed = 68 total (was 68) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 55s the patch passed +1 javadoc 0m 53s the patch passed -1 unit 63m 50s hadoop-hdfs in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 84m 19s Reason Tests Failed junit tests hadoop.hdfs.TestFileCorruption   hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs   hadoop.cli.TestHDFSCLI Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819453/HDFS-10655.patch JIRA Issue HDFS-10655 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f8761aca89b1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / da6adf5 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16193/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16193/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16193/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16193/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jingzhao Jing Zhao added a comment -

          The patch looks good to me overall. One comment about the change on byteArray2PathString:

          -      if (i < pathComponents.length - 1) {
          +      if (i < lastIndex) {
                   result.append(Path.SEPARATOR_CHAR);
                 }
          

          This change actually changes the original semantic, and I do not think the original implementation is a bug. For the byte[][] derived from path like "/foo/bar/baz", when calling byteArray2PathString(bytes, 0, 3), the original implementation returns /foo/bar/, while the new implementation returns /foo/bar. The original semantic is, if i is less than pathComponents.length - 1, we know the last component must be a directory, thus we can append a /.

          Show
          jingzhao Jing Zhao added a comment - The patch looks good to me overall. One comment about the change on byteArray2PathString : - if (i < pathComponents.length - 1) { + if (i < lastIndex) { result.append(Path.SEPARATOR_CHAR); } This change actually changes the original semantic, and I do not think the original implementation is a bug. For the byte[][] derived from path like "/foo/bar/baz", when calling byteArray2PathString(bytes, 0, 3) , the original implementation returns /foo/bar/ , while the new implementation returns /foo/bar . The original semantic is, if i is less than pathComponents.length - 1 , we know the last component must be a directory, thus we can append a / .
          Hide
          daryn Daryn Sharp added a comment -

          The only caller of the method with less than the full component length is verifyFsLimitsForRename, and then only used for exception messages. I'm not sure the trailing slash was intended, or if it was, that it matters? Adding the trailing slash will make it less useful for the general use-case to more extensively use this method. I can add a boolean to preserve this dubious behavior if you'd like.

          Show
          daryn Daryn Sharp added a comment - The only caller of the method with less than the full component length is verifyFsLimitsForRename , and then only used for exception messages. I'm not sure the trailing slash was intended, or if it was, that it matters? Adding the trailing slash will make it less useful for the general use-case to more extensively use this method. I can add a boolean to preserve this dubious behavior if you'd like.
          Hide
          jingzhao Jing Zhao added a comment -

          Thanks for the response, Daryn Sharp. I agree in the current code base whether to append "/" does not matter. So I'll leave it to you to decide whether to keep the original behavior. Other than this +1.

          Show
          jingzhao Jing Zhao added a comment - Thanks for the response, Daryn Sharp . I agree in the current code base whether to append "/" does not matter. So I'll leave it to you to decide whether to keep the original behavior. Other than this +1.
          Hide
          daryn Daryn Sharp added a comment -

          Thanks Jing!

          Show
          daryn Daryn Sharp added a comment - Thanks Jing!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #10188 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10188/)
          HDFS-10655. Fix path related byte array conversion bugs. (daryn) (daryn: rev 9f473cf903e586c556154abd56b3a3d820c6b028)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestPathComponents.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsLimits.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10188 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10188/ ) HDFS-10655 . Fix path related byte array conversion bugs. (daryn) (daryn: rev 9f473cf903e586c556154abd56b3a3d820c6b028) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestPathComponents.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsLimits.java
          Hide
          zhz Zhe Zhang added a comment -

          Sorry to reopen it, I want to backport it to branch-2.7 and have a full Jenkins run before doing that.

          Show
          zhz Zhe Zhang added a comment - Sorry to reopen it, I want to backport it to branch-2.7 and have a full Jenkins run before doing that.
          Hide
          zhz Zhe Zhang added a comment -

          branch-2.7 patch attached.

          Show
          zhz Zhe Zhang added a comment - branch-2.7 patch attached.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 12m 36s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 55s branch-2.7 passed
          +1 compile 1m 7s branch-2.7 passed with JDK v1.8.0_101
          +1 compile 1m 6s branch-2.7 passed with JDK v1.7.0_111
          +1 checkstyle 0m 26s branch-2.7 passed
          +1 mvnsite 1m 12s branch-2.7 passed
          +1 mvneclipse 0m 16s branch-2.7 passed
          +1 findbugs 3m 15s branch-2.7 passed
          +1 javadoc 1m 2s branch-2.7 passed with JDK v1.8.0_101
          +1 javadoc 1m 48s branch-2.7 passed with JDK v1.7.0_111
          +1 mvninstall 0m 56s the patch passed
          +1 compile 1m 5s the patch passed with JDK v1.8.0_101
          +1 javac 1m 5s the patch passed
          +1 compile 1m 7s the patch passed with JDK v1.7.0_111
          +1 javac 1m 7s the patch passed
          +1 checkstyle 0m 24s the patch passed
          +1 mvnsite 1m 4s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 whitespace 0m 0s The patch has 1650 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 43s The patch 77 line(s) with tabs.
          +1 findbugs 3m 33s the patch passed
          +1 javadoc 1m 2s the patch passed with JDK v1.8.0_101
          +1 javadoc 1m 44s the patch passed with JDK v1.7.0_111
          -1 unit 46m 25s hadoop-hdfs in the patch failed with JDK v1.7.0_111.
          -1 asflicense 0m 18s The patch generated 3 ASF License warnings.
          142m 35s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
            hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
          JDK v1.7.0_111 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
            hadoop.hdfs.server.balancer.TestBalancer



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Issue HDFS-10655
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826266/HDFS-10655-branch-2.7.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f81dc093a7ce 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / 85a067f
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16580/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16580/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16580/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16580/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16580/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16580/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 36s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 55s branch-2.7 passed +1 compile 1m 7s branch-2.7 passed with JDK v1.8.0_101 +1 compile 1m 6s branch-2.7 passed with JDK v1.7.0_111 +1 checkstyle 0m 26s branch-2.7 passed +1 mvnsite 1m 12s branch-2.7 passed +1 mvneclipse 0m 16s branch-2.7 passed +1 findbugs 3m 15s branch-2.7 passed +1 javadoc 1m 2s branch-2.7 passed with JDK v1.8.0_101 +1 javadoc 1m 48s branch-2.7 passed with JDK v1.7.0_111 +1 mvninstall 0m 56s the patch passed +1 compile 1m 5s the patch passed with JDK v1.8.0_101 +1 javac 1m 5s the patch passed +1 compile 1m 7s the patch passed with JDK v1.7.0_111 +1 javac 1m 7s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 1650 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 43s The patch 77 line(s) with tabs. +1 findbugs 3m 33s the patch passed +1 javadoc 1m 2s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 44s the patch passed with JDK v1.7.0_111 -1 unit 46m 25s hadoop-hdfs in the patch failed with JDK v1.7.0_111. -1 asflicense 0m 18s The patch generated 3 ASF License warnings. 142m 35s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes JDK v1.7.0_111 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.balancer.TestBalancer Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue HDFS-10655 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826266/HDFS-10655-branch-2.7.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f81dc093a7ce 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 85a067f Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16580/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16580/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16580/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16580/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16580/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16580/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 33s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 4s branch-2.7 passed
          +1 compile 0m 59s branch-2.7 passed with JDK v1.8.0_101
          +1 compile 1m 3s branch-2.7 passed with JDK v1.7.0_111
          +1 checkstyle 0m 25s branch-2.7 passed
          +1 mvnsite 1m 1s branch-2.7 passed
          +1 mvneclipse 0m 14s branch-2.7 passed
          +1 findbugs 2m 59s branch-2.7 passed
          +1 javadoc 0m 58s branch-2.7 passed with JDK v1.8.0_101
          +1 javadoc 1m 41s branch-2.7 passed with JDK v1.7.0_111
          +1 mvninstall 0m 54s the patch passed
          +1 compile 1m 0s the patch passed with JDK v1.8.0_101
          +1 javac 1m 0s the patch passed
          +1 compile 1m 1s the patch passed with JDK v1.7.0_111
          +1 javac 1m 1s the patch passed
          +1 checkstyle 0m 22s the patch passed
          +1 mvnsite 1m 5s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          -1 whitespace 0m 0s The patch has 1650 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 43s The patch 77 line(s) with tabs.
          +1 findbugs 3m 23s the patch passed
          +1 javadoc 1m 8s the patch passed with JDK v1.8.0_101
          +1 javadoc 1m 43s the patch passed with JDK v1.7.0_111
          -1 unit 58m 36s hadoop-hdfs in the patch failed with JDK v1.7.0_111.
          -1 asflicense 0m 19s The patch generated 3 ASF License warnings.
          148m 4s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts
            hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength
            hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
          JDK v1.7.0_111 Failed junit tests hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
            hadoop.hdfs.server.namenode.ha.TestHAStateTransitions
            hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
          JDK v1.7.0_111 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Issue HDFS-10655
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826266/HDFS-10655-branch-2.7.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4d9d10c6cdfa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / 85a067f
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16579/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16579/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16579/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16579/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16579/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16579/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 33s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 4s branch-2.7 passed +1 compile 0m 59s branch-2.7 passed with JDK v1.8.0_101 +1 compile 1m 3s branch-2.7 passed with JDK v1.7.0_111 +1 checkstyle 0m 25s branch-2.7 passed +1 mvnsite 1m 1s branch-2.7 passed +1 mvneclipse 0m 14s branch-2.7 passed +1 findbugs 2m 59s branch-2.7 passed +1 javadoc 0m 58s branch-2.7 passed with JDK v1.8.0_101 +1 javadoc 1m 41s branch-2.7 passed with JDK v1.7.0_111 +1 mvninstall 0m 54s the patch passed +1 compile 1m 0s the patch passed with JDK v1.8.0_101 +1 javac 1m 0s the patch passed +1 compile 1m 1s the patch passed with JDK v1.7.0_111 +1 javac 1m 1s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 15s the patch passed -1 whitespace 0m 0s The patch has 1650 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 43s The patch 77 line(s) with tabs. +1 findbugs 3m 23s the patch passed +1 javadoc 1m 8s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 43s the patch passed with JDK v1.7.0_111 -1 unit 58m 36s hadoop-hdfs in the patch failed with JDK v1.7.0_111. -1 asflicense 0m 19s The patch generated 3 ASF License warnings. 148m 4s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes JDK v1.7.0_111 Failed junit tests hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.server.namenode.ha.TestHAStateTransitions   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot JDK v1.7.0_111 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue HDFS-10655 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826266/HDFS-10655-branch-2.7.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4d9d10c6cdfa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 85a067f Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16579/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16579/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16579/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16579/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16579/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16579/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          zhz Zhe Zhang added a comment -

          I just committed to branch-2.7.

          Show
          zhz Zhe Zhang added a comment - I just committed to branch-2.7.

            People

            • Assignee:
              daryn Daryn Sharp
              Reporter:
              daryn Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development