Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.8.0, 2.6.5, 2.7.4, 3.0.0-alpha1
    • Component/s: hdfs
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Converting a path String to a byte[][] currently requires an unnecessary intermediate conversion from String to String[]. Removing this will reduce excessive object allocation and byte copying.

      1. HDFS-10653.patch
        9 kB
        Daryn Sharp
      2. HDFS-10653-branch-2.6.00.patch
        10 kB
        Zhe Zhang
      3. HDFS-10653-branch-2.6.01.patch
        11 kB
        Zhe Zhang
      4. HDFS-10653-branch-2.6.02.patch
        11 kB
        Zhe Zhang
      5. HDFS-10653-branch-2.6.03.patch
        11 kB
        Zhe Zhang

        Issue Links

          Activity

          Hide
          zhz Zhe Zhang added a comment -

          Local test-patch shows 2 failures but those tests fail even without the patch. I'll create a JIRA to address.

          Just committed v03 branch-2.6 patch. Thanks Allen and Daryn for the review and comments.

          Show
          zhz Zhe Zhang added a comment - Local test-patch shows 2 failures but those tests fail even without the patch. I'll create a JIRA to address. Just committed v03 branch-2.6 patch. Thanks Allen and Daryn for the review and comments.
          Hide
          zhz Zhe Zhang added a comment -

          Thanks Daryn Sharp for the suggestion. Good point. Updating patch to address.

          Allen Wittenauer Thanks for explaining pre-commit. I'll run test-patch locally for 2.6 patches then.

          Will commit v03 patch after local test-patch run.

          Show
          zhz Zhe Zhang added a comment - Thanks Daryn Sharp for the suggestion. Good point. Updating patch to address. Allen Wittenauer Thanks for explaining pre-commit. I'll run test-patch locally for 2.6 patches then. Will commit v03 patch after local test-patch run.
          Hide
          daryn Daryn Sharp added a comment -

          Arrays.toString(components[i]) is going to place square brackets, ie. "[component]" around the name. DFSUtil.bytes2String(int,int) will let you avoid using a StringBuilder entirely - which has been part of the goal of my patches. +1 after you change it. Bonus points for not constructing the path unless required but not that concerned about 2.6.

          Show
          daryn Daryn Sharp added a comment - Arrays.toString(components[i]) is going to place square brackets, ie. "[component]" around the name. DFSUtil.bytes2String(int,int) will let you avoid using a StringBuilder entirely - which has been part of the goal of my patches. +1 after you change it. Bonus points for not constructing the path unless required but not that concerned about 2.6.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 10s branch-2.6 passed
          -1 compile 0m 50s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_101.
          -1 compile 0m 50s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101.
          +1 checkstyle 0m 22s branch-2.6 passed
          +1 mvnsite 1m 3s branch-2.6 passed
          +1 mvneclipse 0m 16s branch-2.6 passed
          -1 findbugs 3m 23s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 272 extant Findbugs warnings.
          +1 javadoc 1m 12s branch-2.6 passed with JDK v1.8.0_101
          +1 javadoc 1m 58s branch-2.6 passed with JDK v1.7.0_101
          +1 mvninstall 1m 0s the patch passed
          -1 compile 0m 45s hadoop-hdfs in the patch failed with JDK v1.8.0_101.
          -1 javac 0m 45s hadoop-hdfs in the patch failed with JDK v1.8.0_101.
          -1 compile 0m 50s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          -1 javac 0m 50s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          +1 checkstyle 0m 22s the patch passed
          +1 mvnsite 1m 3s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          -1 whitespace 0m 0s The patch has 2618 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 1m 5s The patch 77 line(s) with tabs.
          +1 findbugs 3m 36s the patch passed
          +1 javadoc 1m 18s the patch passed with JDK v1.8.0_101
          +1 javadoc 2m 4s the patch passed with JDK v1.7.0_101
          -1 unit 0m 51s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          -1 asflicense 0m 33s The patch generated 75 ASF License warnings.
          33m 52s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:44eef0e
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819508/HDFS-10653-branch-2.6.02.patch
          JIRA Issue HDFS-10653
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 48bae45cbbae 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.6 / 2f54675
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          findbugs v1.3.9
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16149/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16149/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 10s branch-2.6 passed -1 compile 0m 50s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_101. -1 compile 0m 50s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101. +1 checkstyle 0m 22s branch-2.6 passed +1 mvnsite 1m 3s branch-2.6 passed +1 mvneclipse 0m 16s branch-2.6 passed -1 findbugs 3m 23s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 272 extant Findbugs warnings. +1 javadoc 1m 12s branch-2.6 passed with JDK v1.8.0_101 +1 javadoc 1m 58s branch-2.6 passed with JDK v1.7.0_101 +1 mvninstall 1m 0s the patch passed -1 compile 0m 45s hadoop-hdfs in the patch failed with JDK v1.8.0_101. -1 javac 0m 45s hadoop-hdfs in the patch failed with JDK v1.8.0_101. -1 compile 0m 50s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 javac 0m 50s hadoop-hdfs in the patch failed with JDK v1.7.0_101. +1 checkstyle 0m 22s the patch passed +1 mvnsite 1m 3s the patch passed +1 mvneclipse 0m 16s the patch passed -1 whitespace 0m 0s The patch has 2618 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 1m 5s The patch 77 line(s) with tabs. +1 findbugs 3m 36s the patch passed +1 javadoc 1m 18s the patch passed with JDK v1.8.0_101 +1 javadoc 2m 4s the patch passed with JDK v1.7.0_101 -1 unit 0m 51s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 asflicense 0m 33s The patch generated 75 ASF License warnings. 33m 52s Subsystem Report/Notes Docker Image:yetus/hadoop:44eef0e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819508/HDFS-10653-branch-2.6.02.patch JIRA Issue HDFS-10653 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 48bae45cbbae 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6 / 2f54675 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 compile https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt findbugs v1.3.9 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html compile https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16149/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16149/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16149/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 14m 14s branch-2.6 passed
          -1 compile 0m 49s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_101.
          -1 compile 0m 46s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101.
          +1 checkstyle 0m 23s branch-2.6 passed
          +1 mvnsite 0m 58s branch-2.6 passed
          +1 mvneclipse 0m 17s branch-2.6 passed
          -1 findbugs 2m 56s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 273 extant Findbugs warnings.
          +1 javadoc 1m 15s branch-2.6 passed with JDK v1.8.0_101
          +1 javadoc 1m 56s branch-2.6 passed with JDK v1.7.0_101
          +1 mvninstall 0m 55s the patch passed
          -1 compile 0m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_101.
          -1 javac 0m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_101.
          -1 compile 0m 42s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          -1 javac 0m 42s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          +1 checkstyle 0m 19s the patch passed
          +1 mvnsite 0m 54s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 whitespace 0m 0s The patch has 2292 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 56s The patch 77 line(s) with tabs.
          +1 findbugs 3m 7s the patch passed
          +1 javadoc 1m 7s the patch passed with JDK v1.8.0_101
          +1 javadoc 1m 49s the patch passed with JDK v1.7.0_101
          -1 unit 0m 43s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          -1 asflicense 0m 35s The patch generated 75 ASF License warnings.
          39m 34s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:44eef0e
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819508/HDFS-10653-branch-2.6.02.patch
          JIRA Issue HDFS-10653
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 549787752e92 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.6 / 2f54675
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          findbugs v1.3.9
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16148/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16148/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 14m 14s branch-2.6 passed -1 compile 0m 49s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_101. -1 compile 0m 46s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101. +1 checkstyle 0m 23s branch-2.6 passed +1 mvnsite 0m 58s branch-2.6 passed +1 mvneclipse 0m 17s branch-2.6 passed -1 findbugs 2m 56s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 273 extant Findbugs warnings. +1 javadoc 1m 15s branch-2.6 passed with JDK v1.8.0_101 +1 javadoc 1m 56s branch-2.6 passed with JDK v1.7.0_101 +1 mvninstall 0m 55s the patch passed -1 compile 0m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_101. -1 javac 0m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_101. -1 compile 0m 42s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 javac 0m 42s hadoop-hdfs in the patch failed with JDK v1.7.0_101. +1 checkstyle 0m 19s the patch passed +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 2292 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 56s The patch 77 line(s) with tabs. +1 findbugs 3m 7s the patch passed +1 javadoc 1m 7s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 49s the patch passed with JDK v1.7.0_101 -1 unit 0m 43s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 asflicense 0m 35s The patch generated 75 ASF License warnings. 39m 34s Subsystem Report/Notes Docker Image:yetus/hadoop:44eef0e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819508/HDFS-10653-branch-2.6.02.patch JIRA Issue HDFS-10653 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 549787752e92 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6 / 2f54675 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 compile https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt findbugs v1.3.9 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html compile https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16148/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16148/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16148/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          Do you have a clue why test results page is not available for the branch-2.6 patches?

          TL;DR: branch-2.6 support was removed from precommit.

          Longer:

           /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 
          

          As mentioned months and months ago on common-dev, JDK6 was jettisoned in favor of JDK8 until Apache Yetus can support different settings per branch. In addition, I have no idea what JDKs are in the branch-2.6 dockerfile, but given that jdk8 is available, I'm guessing someone blindly backported a trunk patch without considering the consequences.

          Show
          aw Allen Wittenauer added a comment - Do you have a clue why test results page is not available for the branch-2.6 patches? TL;DR: branch-2.6 support was removed from precommit. Longer: /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 As mentioned months and months ago on common-dev, JDK6 was jettisoned in favor of JDK8 until Apache Yetus can support different settings per branch. In addition, I have no idea what JDKs are in the branch-2.6 dockerfile, but given that jdk8 is available, I'm guessing someone blindly backported a trunk patch without considering the consequences.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 12m 35s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 21m 38s branch-2.6 passed
          -1 compile 0m 49s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_101.
          -1 compile 0m 51s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101.
          +1 checkstyle 0m 28s branch-2.6 passed
          +1 mvnsite 1m 4s branch-2.6 passed
          +1 mvneclipse 0m 21s branch-2.6 passed
          -1 findbugs 3m 35s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 272 extant Findbugs warnings.
          +1 javadoc 1m 16s branch-2.6 passed with JDK v1.8.0_101
          +1 javadoc 2m 7s branch-2.6 passed with JDK v1.7.0_101
          +1 mvninstall 1m 6s the patch passed
          -1 compile 0m 44s hadoop-hdfs in the patch failed with JDK v1.8.0_101.
          -1 javac 0m 44s hadoop-hdfs in the patch failed with JDK v1.8.0_101.
          -1 compile 0m 46s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          -1 javac 0m 46s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          +1 checkstyle 0m 20s the patch passed
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 whitespace 0m 0s The patch has 1952 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 46s The patch 77 line(s) with tabs.
          -1 findbugs 3m 14s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 272 unchanged - 0 fixed = 273 total (was 272)
          +1 javadoc 1m 8s the patch passed with JDK v1.8.0_101
          +1 javadoc 1m 55s the patch passed with JDK v1.7.0_101
          -1 unit 0m 47s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          -1 asflicense 0m 42s The patch generated 75 ASF License warnings.
          60m 57s



          Reason Tests
          FindBugs module:hadoop-hdfs-project/hadoop-hdfs
            Invocation of toString on an unnamed array in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.mkdirsRecursively(String, PermissionStatus, boolean, long) At FSNamesystem.java:unnamed array in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.mkdirsRecursively(String, PermissionStatus, boolean, long) At FSNamesystem.java:[line 4346]



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:44eef0e
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819484/HDFS-10653-branch-2.6.01.patch
          JIRA Issue HDFS-10653
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 55711c2908c5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.6 / 2f54675
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          findbugs v1.3.9
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/whitespace-tabs.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16147/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16147/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 35s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 21m 38s branch-2.6 passed -1 compile 0m 49s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_101. -1 compile 0m 51s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101. +1 checkstyle 0m 28s branch-2.6 passed +1 mvnsite 1m 4s branch-2.6 passed +1 mvneclipse 0m 21s branch-2.6 passed -1 findbugs 3m 35s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 272 extant Findbugs warnings. +1 javadoc 1m 16s branch-2.6 passed with JDK v1.8.0_101 +1 javadoc 2m 7s branch-2.6 passed with JDK v1.7.0_101 +1 mvninstall 1m 6s the patch passed -1 compile 0m 44s hadoop-hdfs in the patch failed with JDK v1.8.0_101. -1 javac 0m 44s hadoop-hdfs in the patch failed with JDK v1.8.0_101. -1 compile 0m 46s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 javac 0m 46s hadoop-hdfs in the patch failed with JDK v1.7.0_101. +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 1952 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 46s The patch 77 line(s) with tabs. -1 findbugs 3m 14s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 272 unchanged - 0 fixed = 273 total (was 272) +1 javadoc 1m 8s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 55s the patch passed with JDK v1.7.0_101 -1 unit 0m 47s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 asflicense 0m 42s The patch generated 75 ASF License warnings. 60m 57s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs   Invocation of toString on an unnamed array in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.mkdirsRecursively(String, PermissionStatus, boolean, long) At FSNamesystem.java:unnamed array in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.mkdirsRecursively(String, PermissionStatus, boolean, long) At FSNamesystem.java: [line 4346] Subsystem Report/Notes Docker Image:yetus/hadoop:44eef0e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819484/HDFS-10653-branch-2.6.01.patch JIRA Issue HDFS-10653 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 55711c2908c5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6 / 2f54675 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 compile https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt findbugs v1.3.9 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html compile https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_101.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/whitespace-tabs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16147/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16147/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16147/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          zhz Zhe Zhang added a comment -

          Updating patch to address Findbugs issue.

          Allen Wittenauer Do you have a clue why test results page is not available for the branch-2.6 patches? Thanks much.

          Show
          zhz Zhe Zhang added a comment - Updating patch to address Findbugs issue. Allen Wittenauer Do you have a clue why test results page is not available for the branch-2.6 patches? Thanks much.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 31s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 5m 50s branch-2.6 passed
          -1 compile 0m 52s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_91.
          -1 compile 0m 46s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101.
          +1 checkstyle 0m 22s branch-2.6 passed
          +1 mvnsite 1m 0s branch-2.6 passed
          +1 mvneclipse 0m 15s branch-2.6 passed
          -1 findbugs 2m 58s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 273 extant Findbugs warnings.
          +1 javadoc 1m 11s branch-2.6 passed with JDK v1.8.0_91
          +1 javadoc 1m 50s branch-2.6 passed with JDK v1.7.0_101
          +1 mvninstall 0m 58s the patch passed
          -1 compile 0m 49s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
          -1 javac 0m 49s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
          -1 compile 0m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          -1 javac 0m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          +1 checkstyle 0m 20s the patch passed
          +1 mvnsite 0m 57s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 whitespace 0m 1s The patch has 1953 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 43s The patch 77 line(s) with tabs.
          -1 findbugs 3m 20s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 273 unchanged - 0 fixed = 274 total (was 273)
          +1 javadoc 1m 6s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 48s the patch passed with JDK v1.7.0_101
          -1 unit 0m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          -1 asflicense 0m 34s The patch generated 75 ASF License warnings.
          31m 22s



          Reason Tests
          FindBugs module:hadoop-hdfs-project/hadoop-hdfs
            Invocation of toString on an unnamed array in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.mkdirsRecursively(String, PermissionStatus, boolean, long) At FSNamesystem.java:unnamed array in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.mkdirsRecursively(String, PermissionStatus, boolean, long) At FSNamesystem.java:[line 4346]



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:44eef0e
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819484/HDFS-10653-branch-2.6.01.patch
          JIRA Issue HDFS-10653
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0d83bb64db22 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.6 / 2f54675
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          findbugs v1.3.9
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/whitespace-tabs.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16146/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16146/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 31s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 5m 50s branch-2.6 passed -1 compile 0m 52s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_91. -1 compile 0m 46s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101. +1 checkstyle 0m 22s branch-2.6 passed +1 mvnsite 1m 0s branch-2.6 passed +1 mvneclipse 0m 15s branch-2.6 passed -1 findbugs 2m 58s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 273 extant Findbugs warnings. +1 javadoc 1m 11s branch-2.6 passed with JDK v1.8.0_91 +1 javadoc 1m 50s branch-2.6 passed with JDK v1.7.0_101 +1 mvninstall 0m 58s the patch passed -1 compile 0m 49s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 javac 0m 49s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 compile 0m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 javac 0m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_101. +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 1s The patch has 1953 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 43s The patch 77 line(s) with tabs. -1 findbugs 3m 20s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 273 unchanged - 0 fixed = 274 total (was 273) +1 javadoc 1m 6s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 48s the patch passed with JDK v1.7.0_101 -1 unit 0m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 asflicense 0m 34s The patch generated 75 ASF License warnings. 31m 22s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs   Invocation of toString on an unnamed array in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.mkdirsRecursively(String, PermissionStatus, boolean, long) At FSNamesystem.java:unnamed array in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.mkdirsRecursively(String, PermissionStatus, boolean, long) At FSNamesystem.java: [line 4346] Subsystem Report/Notes Docker Image:yetus/hadoop:44eef0e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819484/HDFS-10653-branch-2.6.01.patch JIRA Issue HDFS-10653 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0d83bb64db22 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6 / 2f54675 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 compile https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt findbugs v1.3.9 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html compile https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/whitespace-tabs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16146/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16146/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16146/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          zhz Zhe Zhang added a comment -

          Thanks for the suggestion Daryn Sharp. Attaching new 2.6 patch to avoid resolving twice.

          Show
          zhz Zhe Zhang added a comment - Thanks for the suggestion Daryn Sharp . Attaching new 2.6 patch to avoid resolving twice.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 29s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 29m 15s branch-2.6 passed
          -1 compile 1m 6s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_91.
          -1 compile 0m 57s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101.
          +1 checkstyle 0m 29s branch-2.6 passed
          +1 mvnsite 1m 19s branch-2.6 passed
          +1 mvneclipse 0m 21s branch-2.6 passed
          -1 findbugs 3m 32s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 273 extant Findbugs warnings.
          +1 javadoc 1m 9s branch-2.6 passed with JDK v1.8.0_91
          +1 javadoc 1m 51s branch-2.6 passed with JDK v1.7.0_101
          +1 mvninstall 1m 1s the patch passed
          -1 compile 0m 49s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
          -1 javac 0m 49s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
          -1 compile 0m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          -1 javac 0m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          +1 checkstyle 0m 21s the patch passed
          +1 mvnsite 1m 1s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          -1 whitespace 0m 0s The patch has 1634 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 38s The patch 77 line(s) with tabs.
          +1 findbugs 3m 11s the patch passed
          +1 javadoc 1m 11s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 54s the patch passed with JDK v1.7.0_101
          -1 unit 0m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          -1 asflicense 0m 37s The patch generated 75 ASF License warnings.
          56m 34s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:44eef0e
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819446/HDFS-10653-branch-2.6.00.patch
          JIRA Issue HDFS-10653
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1a2284bbe1ff 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.6 / 2f54675
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          findbugs v1.3.9
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16142/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16142/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 29s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 29m 15s branch-2.6 passed -1 compile 1m 6s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_91. -1 compile 0m 57s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_101. +1 checkstyle 0m 29s branch-2.6 passed +1 mvnsite 1m 19s branch-2.6 passed +1 mvneclipse 0m 21s branch-2.6 passed -1 findbugs 3m 32s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 273 extant Findbugs warnings. +1 javadoc 1m 9s branch-2.6 passed with JDK v1.8.0_91 +1 javadoc 1m 51s branch-2.6 passed with JDK v1.7.0_101 +1 mvninstall 1m 1s the patch passed -1 compile 0m 49s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 javac 0m 49s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 compile 0m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 javac 0m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_101. +1 checkstyle 0m 21s the patch passed +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 15s the patch passed -1 whitespace 0m 0s The patch has 1634 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 38s The patch 77 line(s) with tabs. +1 findbugs 3m 11s the patch passed +1 javadoc 1m 11s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 54s the patch passed with JDK v1.7.0_101 -1 unit 0m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_101. -1 asflicense 0m 37s The patch generated 75 ASF License warnings. 56m 34s Subsystem Report/Notes Docker Image:yetus/hadoop:44eef0e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12819446/HDFS-10653-branch-2.6.00.patch JIRA Issue HDFS-10653 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1a2284bbe1ff 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6 / 2f54675 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 compile https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt findbugs v1.3.9 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html compile https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16142/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16142/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16142/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          zhz Zhe Zhang added a comment -

          Sorry, have to reopen the issue otherwise Jenkins won't run.

          Show
          zhz Zhe Zhang added a comment - Sorry, have to reopen the issue otherwise Jenkins won't run.
          Hide
          daryn Daryn Sharp added a comment -

          Thanks Jing and Zhe! Zhe, +1 looks fine but you may want to try and eliminate "String[] names = INode.getPathNames(src)".

          Show
          daryn Daryn Sharp added a comment - Thanks Jing and Zhe! Zhe, +1 looks fine but you may want to try and eliminate "String[] names = INode.getPathNames(src)".
          Hide
          zhz Zhe Zhang added a comment -

          Attaching branch-2.6 patch to trigger Jenkins and also ping Daryn Sharp to review the following conflict resolution:

          // FSNamesystem#mkdirsRecursively
              String[] names = INode.getPathNames(src);
              byte[][] components = INode.getPathComponents(src); // used to be getPathComponents(names)
          
          Show
          zhz Zhe Zhang added a comment - Attaching branch-2.6 patch to trigger Jenkins and also ping Daryn Sharp to review the following conflict resolution: // FSNamesystem#mkdirsRecursively String [] names = INode.getPathNames(src); byte [][] components = INode.getPathComponents(src); // used to be getPathComponents(names)
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #10130 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10130/)
          HDFS-10653. Optimize conversion from path string to components. (jing9: rev bd3dcf46e263b6e6aa3fca6a5d9936cc49e3280f)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSnapshotPathINodes.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10130 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10130/ ) HDFS-10653 . Optimize conversion from path string to components. (jing9: rev bd3dcf46e263b6e6aa3fca6a5d9936cc49e3280f) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSnapshotPathINodes.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
          Hide
          zhz Zhe Zhang added a comment -

          Thanks Daryn for the patch and Jing for the review. I quickly tried and there's only a minor conflict to 2.6. I'll try to backport now.

          Show
          zhz Zhe Zhang added a comment - Thanks Daryn for the patch and Jing for the review. I quickly tried and there's only a minor conflict to 2.6. I'll try to backport now.
          Hide
          jingzhao Jing Zhao added a comment -

          I've committed this to trunk and branch-2.

          Show
          jingzhao Jing Zhao added a comment - I've committed this to trunk and branch-2.
          Hide
          jingzhao Jing Zhao added a comment -

          The patch looks good to me. +1.

          Show
          jingzhao Jing Zhao added a comment - The patch looks good to me. +1.
          Hide
          daryn Daryn Sharp added a comment -

          May I have a review please? It's going to become harder for me to post more patches until the outstanding ones under the umbrella are integrated.

          Show
          daryn Daryn Sharp added a comment - May I have a review please? It's going to become harder for me to post more patches until the outstanding ones under the umbrella are integrated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 25s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 27s trunk passed
          +1 compile 0m 48s trunk passed
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 41s trunk passed
          +1 javadoc 0m 58s trunk passed
          +1 mvninstall 0m 51s the patch passed
          +1 compile 0m 44s the patch passed
          +1 javac 0m 44s the patch passed
          +1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 114 unchanged - 1 fixed = 114 total (was 115)
          +1 mvnsite 0m 51s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 50s the patch passed
          +1 javadoc 0m 53s the patch passed
          -1 unit 68m 18s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          88m 26s



          Reason Tests
          Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818828/HDFS-10653.patch
          JIRA Issue HDFS-10653
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 900ebfe0bcc5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / dc2f4b6
          Default Java 1.8.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16092/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16092/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16092/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 27s trunk passed +1 compile 0m 48s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 41s trunk passed +1 javadoc 0m 58s trunk passed +1 mvninstall 0m 51s the patch passed +1 compile 0m 44s the patch passed +1 javac 0m 44s the patch passed +1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 114 unchanged - 1 fixed = 114 total (was 115) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 53s the patch passed -1 unit 68m 18s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 88m 26s Reason Tests Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12818828/HDFS-10653.patch JIRA Issue HDFS-10653 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 900ebfe0bcc5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dc2f4b6 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/16092/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16092/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16092/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

            People

            • Assignee:
              daryn Daryn Sharp
              Reporter:
              daryn Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development