Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10455

Logging the username when deny the setOwner operation

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: namenode
    • Labels:
      None

      Description

      The attached patch appends the user name in the logging when the setOwner operation is denied due to insufficient permissions on this user (based on his/her name).

      The same practice is used in FSPermissionChecker such as checkOwner() and checkSuperuserPrivilege().

      FSDirAttrOp.java
             if (!pc.isSuperUser()) {
               if (username != null && !pc.getUser().equals(username)) {
      -          throw new AccessControlException("Non-super user cannot change owner");
      +          throw new AccessControlException("User " + pc.getUser()
      +              + " is not a super user (non-super user cannot change owner).");
               }
               if (group != null && !pc.containsGroup(group)) {
      -          throw new AccessControlException("User does not belong to " + group);
      +          throw new AccessControlException("User " + pc.getUser()
      +              + " does not belong to " + group);
               }
      
      
      1. HDFS-10455.000.patch
        1 kB
        Tianyin Xu
      2. HDFS-10455.002.patch
        2 kB
        Rakesh R
      3. HDFS-10455-003.patch
        3 kB
        Rakesh R
      4. HDFS-10455-branch-2.000.patch
        2 kB
        Rakesh R

        Activity

        Hide
        tianyin Tianyin Xu added a comment -

        Patch against trunk

        Show
        tianyin Tianyin Xu added a comment - Patch against trunk
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 2s trunk passed
        +1 compile 0m 42s trunk passed
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 0m 50s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 findbugs 1m 37s trunk passed
        +1 javadoc 1m 4s trunk passed
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 40s the patch passed
        +1 javac 0m 40s the patch passed
        +1 checkstyle 0m 22s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 12 unchanged - 1 fixed = 12 total (was 13)
        +1 mvnsite 0m 47s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 42s the patch passed
        +1 javadoc 1m 0s the patch passed
        -1 unit 59m 46s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        77m 41s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestAsyncDFSRename



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806012/HDFS-10455.000.patch
        JIRA Issue HDFS-10455
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 5c83e5fefcb1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / edd716e
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15550/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15550/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15550/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15550/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 2s trunk passed +1 compile 0m 42s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 37s trunk passed +1 javadoc 1m 4s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 40s the patch passed +1 javac 0m 40s the patch passed +1 checkstyle 0m 22s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 12 unchanged - 1 fixed = 12 total (was 13) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 42s the patch passed +1 javadoc 1m 0s the patch passed -1 unit 59m 46s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 77m 41s Reason Tests Failed junit tests hadoop.hdfs.TestAsyncDFSRename Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806012/HDFS-10455.000.patch JIRA Issue HDFS-10455 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5c83e5fefcb1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / edd716e Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15550/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15550/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15550/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15550/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Tianyin Xu for the work.

        +1(non-binding). Rebased patch in latest trunk code.
        cc/Vinayakumar B

        Show
        rakeshr Rakesh R added a comment - Thanks Tianyin Xu for the work. +1(non-binding). Rebased patch in latest trunk code. cc/ Vinayakumar B
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        +1, will commit soon.

        Show
        brahmareddy Brahma Reddy Battula added a comment - +1, will commit soon.
        Hide
        rakeshr Rakesh R added a comment -
        Show
        rakeshr Rakesh R added a comment - Thank you Brahma Reddy Battula
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Committed to trunk,branch-2 and branch-2.8..Tianyin Xu thanks for reporting and contribution and thanks to Rakesh R for additional review and rebasing the patch.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Committed to trunk,branch-2 and branch-2.8.. Tianyin Xu thanks for reporting and contribution and thanks to Rakesh R for additional review and rebasing the patch.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10707 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10707/)
        HDFS-10455. Logging the username when deny the setOwner operation. (brahma: rev ac35ee9393e0afce9fede1d2052e7bf4032312fd)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10707 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10707/ ) HDFS-10455 . Logging the username when deny the setOwner operation. (brahma: rev ac35ee9393e0afce9fede1d2052e7bf4032312fd) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
        Hide
        kihwal Kihwal Lee added a comment -

        It broke TestPermission

        Running org.apache.hadoop.security.TestPermission
        Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.996 sec <<< FAILURE! - in org.apache.hadoop.security.TestPermission
        testFilePermission(org.apache.hadoop.security.TestPermission)  Time elapsed: 5.926 sec  <<< FAILURE!
        java.lang.AssertionError: 
        Expected: a string starting with "User does not belong to"
             but: was "User user-1375012529 does not belong to nogroup
        	at org.apache.hadoop.hdfs.server.namenode.FSDirAttrOp.setOwner(FSDirAttrOp.java:92)
        	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.setOwner(FSNamesystem.java:1727)
        	at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.setOwner(NameNodeRpcServer.java:834)
        	at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.setOwner(ClientNamenodeProtocolServerSideTranslatorPB.java:488)
        	at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
        	at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:467)
        	at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:990)
        	at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:845)
        	at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:788)
        	at java.security.AccessController.doPrivileged(Native Method)
        	at javax.security.auth.Subject.doAs(Subject.java:422)
        	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1795)
        	at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2535)
        "
        	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
        	at org.junit.Assert.assertThat(Assert.java:865)
        	at org.junit.Assert.assertThat(Assert.java:832)
        	at org.apache.hadoop.security.TestPermission.testNonSuperCannotChangeToOtherGroup(TestPermission.java:340)
        	at org.apache.hadoop.security.TestPermission.testFilePermission(TestPermission.java:305)
        
        Show
        kihwal Kihwal Lee added a comment - It broke TestPermission Running org.apache.hadoop.security.TestPermission Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.996 sec <<< FAILURE! - in org.apache.hadoop.security.TestPermission testFilePermission(org.apache.hadoop.security.TestPermission) Time elapsed: 5.926 sec <<< FAILURE! java.lang.AssertionError: Expected: a string starting with "User does not belong to" but: was "User user-1375012529 does not belong to nogroup at org.apache.hadoop.hdfs.server.namenode.FSDirAttrOp.setOwner(FSDirAttrOp.java:92) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.setOwner(FSNamesystem.java:1727) at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.setOwner(NameNodeRpcServer.java:834) at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.setOwner(ClientNamenodeProtocolServerSideTranslatorPB.java:488) at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java) at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:467) at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:990) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:845) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:788) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1795) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2535) " at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:865) at org.junit.Assert.assertThat(Assert.java:832) at org.apache.hadoop.security.TestPermission.testNonSuperCannotChangeToOtherGroup(TestPermission.java:340) at org.apache.hadoop.security.TestPermission.testFilePermission(TestPermission.java:305)
        Hide
        kihwal Kihwal Lee added a comment -

        The precommit was from May. You should have re-run it.

        Show
        kihwal Kihwal Lee added a comment - The precommit was from May. You should have re-run it.
        Hide
        kihwal Kihwal Lee added a comment -

        Reverted the commits.

        Show
        kihwal Kihwal Lee added a comment - Reverted the commits.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10708 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10708/)
        Revert "HDFS-10455. Logging the username when deny the setOwner (kihwal: rev db41965996630c8f8c48618c5a0bc24321320c52)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10708 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10708/ ) Revert " HDFS-10455 . Logging the username when deny the setOwner (kihwal: rev db41965996630c8f8c48618c5a0bc24321320c52) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Kihwal Lee for pointing out the failures, I will fix this asap.

        BTW, in the latest trunk code, am getting few compilation errors and broken building.

        [ERROR] Failed to execute goal org.apache.hadoop:hadoop-maven-plugins:3.0.0-alpha2-SNAPSHOT:resource-gz (resource-gz) on project hadoop-hdfs: org.apache.maven.plugin.MojoExecutionException: java.util.
        regex.PatternSyntaxException: Unknown character property name {r} near index 4
        [ERROR] C:\Projects\Hdp\t1\hadoop-hdfs-project\hadoop-hdfs\src\main\webapps\static
        [ERROR] ^
        [ERROR] -> [Help 1]
        
        Show
        rakeshr Rakesh R added a comment - Thanks Kihwal Lee for pointing out the failures, I will fix this asap. BTW, in the latest trunk code, am getting few compilation errors and broken building. [ERROR] Failed to execute goal org.apache.hadoop:hadoop-maven-plugins:3.0.0-alpha2-SNAPSHOT:resource-gz (resource-gz) on project hadoop-hdfs: org.apache.maven.plugin.MojoExecutionException: java.util. regex.PatternSyntaxException: Unknown character property name {r} near index 4 [ERROR] C:\Projects\Hdp\t1\hadoop-hdfs-project\hadoop-hdfs\src\main\webapps\ static [ERROR] ^ [ERROR] -> [Help 1]
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Rakesh R, compilation error is because of HADOOP-10075 , I already commented there. about testcase , we need to add the user to assertion TestPermission.. and I missed the pre-commit build on this..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Rakesh R , compilation error is because of HADOOP-10075 , I already commented there. about testcase , we need to add the user to assertion TestPermission .. and I missed the pre-commit build on this..
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Brahma Reddy Battula for the details. I will upload new patch fixing test failure.

        Show
        rakeshr Rakesh R added a comment - Thanks Brahma Reddy Battula for the details. I will upload new patch fixing test failure.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 35s trunk passed
        +1 compile 0m 44s trunk passed
        +1 checkstyle 0m 25s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 43s trunk passed
        +1 javadoc 0m 41s trunk passed
        +1 mvninstall 0m 50s the patch passed
        +1 compile 0m 48s the patch passed
        +1 javac 0m 48s the patch passed
        +1 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 24 unchanged - 1 fixed = 24 total (was 25)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 56s the patch passed
        +1 javadoc 0m 40s the patch passed
        -1 unit 55m 55s hadoop-hdfs in the patch failed.
        -1 asflicense 14m 34s The patch generated 4 ASF License warnings.
        89m 58s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10455
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835737/HDFS-10455-003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e1bc3756473c 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8fa2195
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17341/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17341/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/17341/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17341/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 35s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 43s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 50s the patch passed +1 compile 0m 48s the patch passed +1 javac 0m 48s the patch passed +1 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 24 unchanged - 1 fixed = 24 total (was 25) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 56s the patch passed +1 javadoc 0m 40s the patch passed -1 unit 55m 55s hadoop-hdfs in the patch failed. -1 asflicense 14m 34s The patch generated 4 ASF License warnings. 89m 58s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10455 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835737/HDFS-10455-003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e1bc3756473c 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8fa2195 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17341/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17341/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/17341/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17341/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 3s trunk passed
        +1 compile 0m 45s trunk passed
        +1 checkstyle 0m 25s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 41s trunk passed
        +1 javadoc 0m 38s trunk passed
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 42s the patch passed
        +1 javac 0m 42s the patch passed
        +1 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 24 unchanged - 1 fixed = 24 total (was 25)
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 47s the patch passed
        +1 javadoc 0m 37s the patch passed
        -1 unit 76m 48s hadoop-hdfs in the patch failed.
        -1 asflicense 15m 35s The patch generated 4 ASF License warnings.
        110m 47s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10455
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835737/HDFS-10455-003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 5d2227ada9ea 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8fa2195
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17340/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17340/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/17340/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17340/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 3s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 41s trunk passed +1 javadoc 0m 38s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed +1 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 24 unchanged - 1 fixed = 24 total (was 25) +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 37s the patch passed -1 unit 76m 48s hadoop-hdfs in the patch failed. -1 asflicense 15m 35s The patch generated 4 ASF License warnings. 110m 47s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10455 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835737/HDFS-10455-003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5d2227ada9ea 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8fa2195 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17340/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17340/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/17340/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17340/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        It looks like the test case failure is unrelated, please ignore Failed junit tests- hadoop.hdfs.server.datanode.TestFsDatasetCache. Also, the license warning is unrelated, YARN-5794 addresses the same.

        Show
        rakeshr Rakesh R added a comment - It looks like the test case failure is unrelated, please ignore Failed junit tests- hadoop.hdfs.server.datanode.TestFsDatasetCache . Also, the license warning is unrelated, YARN-5794 addresses the same.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Rakesh R thanks for updating the patch.. Committed to trunk.
        testNonSuperCannotChangeToOtherGroup is not there in branch-2, can you please update branch-2 patch..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Rakesh R thanks for updating the patch.. Committed to trunk. testNonSuperCannotChangeToOtherGroup is not there in branch-2, can you please update branch-2 patch..?
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10729 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10729/)
        HDFS-10455. Logging the username when deny the setOwner operation. (brahma: rev e9c7a97089dd1234a7f1782f79b1b0b190b98f39)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10729 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10729/ ) HDFS-10455 . Logging the username when deny the setOwner operation. (brahma: rev e9c7a97089dd1234a7f1782f79b1b0b190b98f39) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
        Hide
        rakeshr Rakesh R added a comment -

        Thank you Brahma Reddy Battula for the commits. I've attached patch for branch-2.

        Show
        rakeshr Rakesh R added a comment - Thank you Brahma Reddy Battula for the commits. I've attached patch for branch-2 .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 29s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 46s branch-2 passed
        +1 compile 0m 46s branch-2 passed with JDK v1.8.0_101
        +1 compile 0m 45s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 27s branch-2 passed
        +1 mvnsite 0m 57s branch-2 passed
        +1 mvneclipse 0m 16s branch-2 passed
        +1 findbugs 2m 4s branch-2 passed
        +1 javadoc 0m 58s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 1m 45s branch-2 passed with JDK v1.7.0_111
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 45s the patch passed with JDK v1.8.0_101
        +1 javac 0m 45s the patch passed
        +1 compile 0m 48s the patch passed with JDK v1.7.0_111
        +1 javac 0m 48s the patch passed
        +1 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 11 unchanged - 1 fixed = 11 total (was 12)
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 13s the patch passed
        +1 javadoc 1m 8s the patch passed with JDK v1.8.0_101
        +1 javadoc 1m 48s the patch passed with JDK v1.7.0_111
        +1 unit 60m 31s hadoop-hdfs in the patch passed with JDK v1.7.0_111.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        164m 3s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HDFS-10455
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836121/HDFS-10455-branch-2.000.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 85fbcf7abc9d 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / ef13a5e
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17350/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17350/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 29s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 46s branch-2 passed +1 compile 0m 46s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 45s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 27s branch-2 passed +1 mvnsite 0m 57s branch-2 passed +1 mvneclipse 0m 16s branch-2 passed +1 findbugs 2m 4s branch-2 passed +1 javadoc 0m 58s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 45s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 46s the patch passed +1 compile 0m 45s the patch passed with JDK v1.8.0_101 +1 javac 0m 45s the patch passed +1 compile 0m 48s the patch passed with JDK v1.7.0_111 +1 javac 0m 48s the patch passed +1 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 11 unchanged - 1 fixed = 11 total (was 12) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 13s the patch passed +1 javadoc 1m 8s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 48s the patch passed with JDK v1.7.0_111 +1 unit 60m 31s hadoop-hdfs in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 164m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-10455 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836121/HDFS-10455-branch-2.000.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 85fbcf7abc9d 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / ef13a5e Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17350/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17350/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Committed to branch-2 and branch-2.8.. Rakesh R thanks for your contribution.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Committed to branch-2 and branch-2.8.. Rakesh R thanks for your contribution.

          People

          • Assignee:
            rakeshr Rakesh R
            Reporter:
            tianyin Tianyin Xu
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development