[HDFS-10455] Logging the username when deny the setOwner operation

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.7.2
• Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha2
• Component/s: namenode
• Target Version/s: 2.8.0, 3.0.0-alpha2
• Hadoop Flags: Reviewed
• Assignee: Rakesh Radhakrishnan
• Reporter: Tianyin Xu
• Created: 24/May/16 23:17
• Updated: 30/May/18 07:46
• Resolved: 01/Nov/16 05:29

Description

The attached patch appends the user name in the logging when the setOwner operation is denied due to insufficient permissions on this user (based on his/her name).

The same practice is used in FSPermissionChecker such as checkOwner() and checkSuperuserPrivilege().

FSDirAttrOp.java

       if (!pc.isSuperUser()) {
         if (username != null && !pc.getUser().equals(username)) {
-          throw new AccessControlException("Non-super user cannot change owner");
+          throw new AccessControlException("User " + pc.getUser()
+              + " is not a super user (non-super user cannot change owner).");
         }
         if (group != null && !pc.containsGroup(group)) {
-          throw new AccessControlException("User does not belong to " + group);
+          throw new AccessControlException("User " + pc.getUser()
+              + " does not belong to " + group);
         }

Issue Links

• is related to: HDFS-13626 Fix incorrect username when deny the setOwner operation