[HDFS-10189] PacketResponder#toString should include the downstreams for PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.7.1
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: datanode
• Target Version/s: 2.8.0
• Assignee: Joe Pallas
• Reporter: Joe Pallas
• Created: 21/Mar/16 19:51
• Updated: 30/Aug/16 01:18
• Resolved: 23/Mar/16 00:21

Description

The constructor for BlockReceiver.PacketResponder says

      final StringBuilder b = new StringBuilder(getClass().getSimpleName())
          .append(": ").append(block).append(", type=").append(type);
      if (type != PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE) {
        b.append(", downstreams=").append(downstreams.length)
            .append(":").append(Arrays.asList(downstreams));
      }

So it includes the list of downstreams only when it has no downstreams. The if test should be for equality.