Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10189

PacketResponder#toString should include the downstreams for PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.7.1
    • 2.8.0, 3.0.0-alpha1
    • datanode
    • None

    Description

      The constructor for BlockReceiver.PacketResponder says

            final StringBuilder b = new StringBuilder(getClass().getSimpleName())
                .append(": ").append(block).append(", type=").append(type);
            if (type != PacketResponderType.HAS_DOWNSTREAM_IN_PIPELINE) {
              b.append(", downstreams=").append(downstreams.length)
                  .append(":").append(Arrays.asList(downstreams));
            }
      

      So it includes the list of downstreams only when it has no downstreams. The if test should be for equality.

      Attachments

        1. HDFS-10189.patch
          0.9 kB
          Joe Pallas

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jpallas Joe Pallas
            jpallas Joe Pallas
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment