Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1006

getImage/putImage http requests should be https for the case of security enabled.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      should use https:// and port 50475

      1. HDFS-1006-trunk-2.patch
        15 kB
        Jakob Homan
      2. HDFS-1006-trunk.patch
        15 kB
        Jakob Homan
      3. hdfs-1006-bugfix-1.patch
        3 kB
        Devaraj Das
      4. HDFS-1006-Y20.1.patch
        14 kB
        Devaraj Das
      5. HDFS-1006-Y20.patch
        14 kB
        Jakob Homan
      6. HDFS-1006-BP20.patch
        1 kB
        Boris Shkolnik

        Issue Links

          Activity

          Hide
          Boris Shkolnik added a comment -

          for previous version of hadoop. Not for commit.

          Show
          Boris Shkolnik added a comment - for previous version of hadoop. Not for commit.
          Hide
          Jakob Homan added a comment -

          New patch for Y20 branch, not to be committed.

          Show
          Jakob Homan added a comment - New patch for Y20 branch, not to be committed.
          Hide
          Devaraj Das added a comment -

          Minor updates to the previous patch.

          Show
          Devaraj Das added a comment - Minor updates to the previous patch.
          Hide
          Devaraj Das added a comment -

          Patch that removes unnecessary logins (for Y20s)

          Show
          Devaraj Das added a comment - Patch that removes unnecessary logins (for Y20s)
          Hide
          Jakob Homan added a comment -

          Trunk for patch, pretty much. The bugfix that was added depends on HDFS-1045, which itself depended on the original 1006. This patch doesn't include the bugfix, which will be included as part of 1045, which is probably the more correct place for it. Forward port is straight-forward and, due to the Kerberos, not unit testable, but has been manually tested at Y!....

          Show
          Jakob Homan added a comment - Trunk for patch, pretty much. The bugfix that was added depends on HDFS-1045 , which itself depended on the original 1006. This patch doesn't include the bugfix, which will be included as part of 1045, which is probably the more correct place for it. Forward port is straight-forward and, due to the Kerberos, not unit testable, but has been manually tested at Y!....
          Hide
          Jakob Homan added a comment -

          submitting patch.

          Show
          Jakob Homan added a comment - submitting patch.
          Hide
          Devaraj Das added a comment -

          You missed setting:

          infoServer.setAttribute("secondary.name.node", this);

          You switched from using StringBuilder to StringBuffer in TransferFsImager.java. Is that deliberate?

          I am not sure whether the SecondaryNameNode->PrimaryNameNode communication will work if security is enabled and the configured address (accessed in SecondaryNameNode.getInfoServer) is a wildcard address. If not, should we throw an error?

          Show
          Devaraj Das added a comment - You missed setting: infoServer.setAttribute("secondary.name.node", this); You switched from using StringBuilder to StringBuffer in TransferFsImager.java. Is that deliberate? I am not sure whether the SecondaryNameNode->PrimaryNameNode communication will work if security is enabled and the configured address (accessed in SecondaryNameNode.getInfoServer) is a wildcard address. If not, should we throw an error?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12448939/HDFS-1006-trunk.patch
          against trunk revision 961495.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/425/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/425/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/425/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/425/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12448939/HDFS-1006-trunk.patch against trunk revision 961495. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/425/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/425/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/425/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/425/console This message is automatically generated.
          Hide
          Jakob Homan added a comment -

          Updated patch for Devaraj's comments. Now throw an exception if using wildcard addr with security, although once we have a unit testing framework for Kerberos - please, please, please - we'll need to come up with a good way of dealing with this.

          Show
          Jakob Homan added a comment - Updated patch for Devaraj's comments. Now throw an exception if using wildcard addr with security, although once we have a unit testing framework for Kerberos - please, please, please - we'll need to come up with a good way of dealing with this.
          Hide
          Jakob Homan added a comment -

          Re-submitting to Hudson.

          Show
          Jakob Homan added a comment - Re-submitting to Hudson.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12449009/HDFS-1006-trunk-2.patch
          against trunk revision 961495.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/426/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/426/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/426/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/426/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12449009/HDFS-1006-trunk-2.patch against trunk revision 961495. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/426/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/426/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/426/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/426/console This message is automatically generated.
          Hide
          Jakob Homan added a comment -

          Test failures are unrelated and have been on-going, such as in HDFS-1005 : http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/210/testReport

          Show
          Jakob Homan added a comment - Test failures are unrelated and have been on-going, such as in HDFS-1005 : http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/210/testReport
          Hide
          Devaraj Das added a comment -

          +1

          Show
          Devaraj Das added a comment - +1
          Hide
          Jakob Homan added a comment -

          I've committed this. Resolving as fixed.

          Show
          Jakob Homan added a comment - I've committed this. Resolving as fixed.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #335 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/335/)
          HDFS-1006. getImage/putImage http requests should be https for the case of security enabled.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #335 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/335/ ) HDFS-1006 . getImage/putImage http requests should be https for the case of security enabled.

            People

            • Assignee:
              Boris Shkolnik
              Reporter:
              Boris Shkolnik
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development