Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-9927

ReplicationLogCleaner#stop() calls HConnectionManager#deleteConnection() unnecessarily

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.15
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When inspecting log, I found the following:

      2013-11-08 18:23:48,472 ERROR [M:0;kiyo:42380.oldLogCleaner] client.HConnectionManager(468): Connection not found in the list, can't delete it (connection key=HConnectionKey{properties={hbase.rpc.timeout=60000, hbase.zookeeper.property.clientPort=59832, hbase.client.pause=100, zookeeper.znode.parent=/hbase, hbase.client.retries.number=350, hbase.zookeeper.quorum=localhost}, username='zy'}). May be the key was modified?
      java.lang.Exception
              at org.apache.hadoop.hbase.client.HConnectionManager.deleteConnection(HConnectionManager.java:468)
              at org.apache.hadoop.hbase.client.HConnectionManager.deleteConnection(HConnectionManager.java:404)
              at org.apache.hadoop.hbase.replication.master.ReplicationLogCleaner.stop(ReplicationLogCleaner.java:141)
              at org.apache.hadoop.hbase.master.cleaner.CleanerChore.cleanup(CleanerChore.java:276)
      

      The call to HConnectionManager#deleteConnection() is not needed.
      Here is related code which has a comment for this effect:

          // Not sure why we're deleting a connection that we never acquired or used
          HConnectionManager.deleteConnection(this.getConf());
      

        Attachments

        1. 9927.txt
          0.7 kB
          Ted Yu

          Activity

            People

            • Assignee:
              yuzhihong@gmail.com Ted Yu
              Reporter:
              yuzhihong@gmail.com Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: