[HBASE-9927] ReplicationLogCleaner#stop() calls HConnectionManager#deleteConnection() unnecessarily

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.94.15
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 08/Nov/13 19:30
• Updated: 30/Dec/13 04:11
• Resolved: 16/Dec/13 23:49

Description

When inspecting log, I found the following:

2013-11-08 18:23:48,472 ERROR [M:0;kiyo:42380.oldLogCleaner] client.HConnectionManager(468): Connection not found in the list, can't delete it (connection key=HConnectionKey{properties={hbase.rpc.timeout=60000, hbase.zookeeper.property.clientPort=59832, hbase.client.pause=100, zookeeper.znode.parent=/hbase, hbase.client.retries.number=350, hbase.zookeeper.quorum=localhost}, username='zy'}). May be the key was modified?
java.lang.Exception
        at org.apache.hadoop.hbase.client.HConnectionManager.deleteConnection(HConnectionManager.java:468)
        at org.apache.hadoop.hbase.client.HConnectionManager.deleteConnection(HConnectionManager.java:404)
        at org.apache.hadoop.hbase.replication.master.ReplicationLogCleaner.stop(ReplicationLogCleaner.java:141)
        at org.apache.hadoop.hbase.master.cleaner.CleanerChore.cleanup(CleanerChore.java:276)

The call to HConnectionManager#deleteConnection() is not needed.
Here is related code which has a comment for this effect:

    // Not sure why we're deleting a connection that we never acquired or used
    HConnectionManager.deleteConnection(this.getConf());