[HBASE-8806] Row locks are acquired repeatedly in HRegion.doMiniBatchMutation for duplicate rows. - ASF JIRA

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 0.94.5
Fix Version/s: 0.94.10
Component/s: regionserver
Labels:
None

Description

If we already have the lock in the doMiniBatchMutation we don't need to re-acquire it. The solution would be to keep a cache of the rowKeys already locked for a miniBatchMutation and If we already have the
rowKey in the cache, we don't repeatedly try and acquire the lock. A fix to this problem would be to keep a set of rows we already locked and not try to acquire the lock for these rows.

We have tested this fix in our production environment and has improved replication performance quite a bit. We saw a replication batch go from 3+ minutes to less than 10 seconds for batches with duplicate row keys.

static final int ACQUIRE_LOCK_COUNT = 0;

  @Test
  public void testRedundantRowKeys() throws Exception {

    final int batchSize = 100000;
    
    String tableName = getClass().getSimpleName();
    Configuration conf = HBaseConfiguration.create();
    conf.setClass(HConstants.REGION_IMPL, MockHRegion.class, HeapSize.class);
    MockHRegion region = (MockHRegion) TestHRegion.initHRegion(Bytes.toBytes(tableName), tableName, conf, Bytes.toBytes("a"));

    List<Pair<Mutation, Integer>> someBatch = Lists.newArrayList();
    int i = 0;
    while (i < batchSize) {
      if (i % 2 == 0) {
        someBatch.add(new Pair<Mutation, Integer>(new Put(Bytes.toBytes(0)), null));
      } else {
        someBatch.add(new Pair<Mutation, Integer>(new Put(Bytes.toBytes(1)), null));
      }
      i++;
    }
    long startTime = System.currentTimeMillis();
    region.batchMutate(someBatch.toArray(new Pair[0]));
    long endTime = System.currentTimeMillis();
    long duration = endTime - startTime;
    System.out.println("duration: " + duration + " ms");
    assertEquals(2, ACQUIRE_LOCK_COUNT);
  }

  @Override
  public Integer getLock(Integer lockid, byte[] row, boolean waitForLock) throws IOException {
    ACQUIRE_LOCK_COUNT++;
    return super.getLock(lockid, row, waitForLock);
  }