Details

    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Changed the coprocessor RegionObserver methods preBatchMutate and postBatchMutate to remove the lock ids from the methods as lock ids are not longer used.
    • Tags:
      0.96notable

      Description

      HBASE-8806 revealed performance problems with batch mutations failing to reacquire the same row locks. It looks like HBASE-8806 will use a less intrusive change for 0.94 to have batch mutations track their own row locks and not attempt to reacquire them. Another approach will be to support reentrant row locks directly. This allows simplifying a great deal of calling code to no longer track and pass around lock ids.

      One affect this change will have is changing the RegionObserver coprocessor's methods preBatchMutate and postBatchMutate from taking a MiniBatchOperationInProgress<Pair<Mutation, Integer>> miniBatchOp to taking a MiniBatchOperationInProgress<Mutation> miniBatchOp. I don't believe CPs should be relying on these lock ids, but that's a potential incompatibility.

      1. HBASE-8877-v7.patch
        49 kB
        Dave Latham
      2. HBASE-8877-v6.patch
        46 kB
        Dave Latham
      3. HBASE-8877-v5.patch
        45 kB
        Dave Latham
      4. hbase-8877-v4-microbenchmark.txt
        4 kB
        Dave Latham
      5. HBASE-8877-v4.patch
        45 kB
        Dave Latham
      6. HBASE-8877-v3.patch
        45 kB
        Dave Latham
      7. HBASE-8877-v2.patch
        45 kB
        Dave Latham
      8. HBASE-8877-refCounts-v5.patch
        69 kB
        Dave Latham
      9. HBASE-8877-refCounts-v4.patch
        69 kB
        Dave Latham
      10. HBASE-8877-refCounts-v3.patch
        71 kB
        Dave Latham
      11. HBASE-8877-refCounts-v2.patch
        71 kB
        Dave Latham
      12. hbase-8877-refCounts-microbenchmarks.txt
        6 kB
        Dave Latham
      13. HBASE-8877-refCounts.patch
        71 kB
        Dave Latham
      14. HBASE-8877-0.94-v2.patch
        8 kB
        Dave Latham
      15. hbase-8877-0.94-microbenchmark.txt
        3 kB
        Dave Latham
      16. HBASE-8877-0.94.patch
        8 kB
        Dave Latham
      17. HBASE-8877.patch
        45 kB
        Dave Latham

        Issue Links

          Activity

          stack made changes -
          Tags 0.96notable
          stack made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Dave Latham made changes -
          Release Note Changed the coprocessor RegionObserver methods preBatchMutate and postBatchMutate to remove the lock ids from the methods as lock ids are not longer used.
          Environment Changed the coprocessor RegionObserver methods preBatchMutate and postBatchMutate to remove the lock ids from the methods as lock ids are not longer used.
          Dave Latham made changes -
          Environment Changed the coprocessor RegionObserver methods preBatchMutate and postBatchMutate to remove the lock ids from the methods as lock ids are not longer used.
          Lars Hofhansl made changes -
          Hadoop Flags Reviewed [ 10343 ] Incompatible change,Reviewed [ 10342, 10343 ]
          Lars Hofhansl made changes -
          Hadoop Flags Reviewed [ 10343 ]
          Lars Hofhansl made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Lars Hofhansl made changes -
          Fix Version/s 0.98.0 [ 12323143 ]
          Dave Latham made changes -
          Attachment HBASE-8877-refCounts-v5.patch [ 12592549 ]
          Dave Latham made changes -
          Attachment HBASE-8877-refCounts-v4.patch [ 12592477 ]
          Dave Latham made changes -
          Attachment HBASE-8877-refCounts-v3.patch [ 12592445 ]
          Dave Latham made changes -
          Attachment HBASE-8877-refCounts-v2.patch [ 12592442 ]
          Dave Latham made changes -
          Attachment HBASE-8877-refCounts.patch [ 12592439 ]
          Dave Latham made changes -
          Attachment HBASE-8877-refCounts.patch [ 12592434 ]
          Dave Latham made changes -
          Dave Latham made changes -
          Attachment HBASE-8877-refCounts.patch [ 12592434 ]
          Dave Latham made changes -
          Attachment HBASE-8877-v7.patch [ 12592355 ]
          Dave Latham made changes -
          Attachment HBASE-8877-0.94-v2.patch [ 12592195 ]
          Dave Latham made changes -
          Attachment HBASE-8877-0.94-v2.patch [ 12592194 ]
          Dave Latham made changes -
          Attachment HBASE-8877-0.94-v2.patch [ 12592194 ]
          Dave Latham made changes -
          Attachment HBASE-8877-v6.patch [ 12592154 ]
          Dave Latham made changes -
          Attachment HBASE-8877-v5.patch [ 12592151 ]
          Dave Latham made changes -
          Attachment HBASE-8877-v4.patch [ 12592150 ]
          Dave Latham made changes -
          Attachment HBASE-8877-v4.patch [ 12592081 ]
          Dave Latham made changes -
          Attachment hbase-8877-v4-microbenchmark.txt [ 12592108 ]
          Dave Latham made changes -
          Attachment hbase-8807-v4-microbenchmark.txt [ 12592082 ]
          Dave Latham made changes -
          Attachment HBASE-8877-0.94.patch [ 12592106 ]
          Attachment hbase-8877-0.94-microbenchmark.txt [ 12592107 ]
          Dave Latham made changes -
          Attachment HBASE-8877-v4.patch [ 12592081 ]
          Attachment hbase-8807-v4-microbenchmark.txt [ 12592082 ]
          Dave Latham made changes -
          Attachment HBASE-8877-v3.patch [ 12591212 ]
          Dave Latham made changes -
          Attachment HBASE-8877-v2.patch [ 12591094 ]
          Dave Latham made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Dave Latham made changes -
          Attachment HBASE-8877.patch [ 12591013 ]
          Dave Latham made changes -
          Field Original Value New Value
          Link This issue relates to HBASE-8806 [ HBASE-8806 ]
          Dave Latham created issue -

            People

            • Assignee:
              Dave Latham
              Reporter:
              Dave Latham
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development