HBase
  1. HBase
  2. HBASE-8642

[Snapshot] List and delete snapshot by table

    Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 0.98.0, 0.95.0, 0.95.1, 0.95.2
    • Fix Version/s: 2.0.0, 1.2.0
    • Component/s: snapshots
    • Labels:
      None

      Description

      Support list and delete snapshot by table name.

      1. 8642-trunk-0.95-v2.patch
        13 kB
        Julian Zhou
      2. 8642-trunk-0.95-v1.patch
        13 kB
        Julian Zhou
      3. 8642-trunk-0.95-v0.patch
        6 kB
        Julian Zhou

        Issue Links

          Activity

          Hide
          Matteo Bertozzi added a comment -

          overall looks good to me...
          Inside deleteSnapshotsByTable() you can use the SnapshotDescription of the for loop, instead of building a new one.
          Do you want also add the shell support?

          Show
          Matteo Bertozzi added a comment - overall looks good to me... Inside deleteSnapshotsByTable() you can use the SnapshotDescription of the for loop, instead of building a new one. Do you want also add the shell support?
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12585227/8642-trunk-0.95-v0.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12585227/8642-trunk-0.95-v0.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5866//console This message is automatically generated.
          Hide
          Jesse Yates added a comment -

          nit:

          Delete existing snapshots of the given table.

          to

          Delete all exisiting snapshots of a table

          Just want to call out more pointedly that it deletes all of them.

          +1, even without the above.

          Show
          Jesse Yates added a comment - nit: Delete existing snapshots of the given table. to Delete all exisiting snapshots of a table Just want to call out more pointedly that it deletes all of them. +1, even without the above.
          Hide
          Julian Zhou added a comment -

          Thanks for review, Matteo Bertozzi and Jesse Yates.
          1) for the logic inside deleteSnapshotsByTable(), I was just copying from #deleteSnapshots(final Pattern pattern), is it ok?
          2) locally applied the comment changes;
          3) for shell support, I just studied the 6353. Seems there are 2 options:
          a) add new "list_snapshots_by_table.rb" and "delete_snapshot_by_table.rb" to separate the case from regex based operation;
          b) still in "list_snapshots.rb" and "delete_snapshot.rb", but add "-table" option to branch out from regex based operation path.
          seems that "delete_snapshot.rb" has no logic for regex based operation currently, will we also support it in this stream?

          Show
          Julian Zhou added a comment - Thanks for review, Matteo Bertozzi and Jesse Yates . 1) for the logic inside deleteSnapshotsByTable(), I was just copying from #deleteSnapshots(final Pattern pattern), is it ok? 2) locally applied the comment changes; 3) for shell support, I just studied the 6353. Seems there are 2 options: a) add new "list_snapshots_by_table.rb" and "delete_snapshot_by_table.rb" to separate the case from regex based operation; b) still in "list_snapshots.rb" and "delete_snapshot.rb", but add "-table" option to branch out from regex based operation path. seems that "delete_snapshot.rb" has no logic for regex based operation currently, will we also support it in this stream?
          Hide
          Matteo Bertozzi added a comment -

          1) for the logic inside deleteSnapshotsByTable(), I was just copying from #deleteSnapshots(final Pattern pattern), is it ok?

          No is not ok, your new code should be better than the existent one
          It's not wrong, but it's just an extra copy... should be fixed also in deleteSnapshots()

          3) for shell support, I just studied the 6353. Seems there are 2 options:
          a) add new "list_snapshots_by_table.rb" and "delete_snapshot_by_table.rb" to separate the case from regex based operation;
          b) still in "list_snapshots.rb" and "delete_snapshot.rb", but add "-table" option to branch out from regex based operation path.

          Having a -table option don't seems to be inline with the current shell, I think that stuff like {{TABLE => 'name*' }} is used elsewhere (see create).. but I will pick the easy way with a new .rb

          seems that "delete_snapshot.rb" has no logic for regex based operation currently, will we also support it in this stream?

          yeah the delete snapshots is not in the shell at the moment.. I think there's a jira or a mention to open a new jira for the shell support.

          Jonathan Hsieh was against the regex delete. not sure what he thinks about this one... but at least this doesn't contain a regex for the table name.

          Show
          Matteo Bertozzi added a comment - 1) for the logic inside deleteSnapshotsByTable(), I was just copying from #deleteSnapshots(final Pattern pattern), is it ok? No is not ok, your new code should be better than the existent one It's not wrong, but it's just an extra copy... should be fixed also in deleteSnapshots() 3) for shell support, I just studied the 6353. Seems there are 2 options: a) add new "list_snapshots_by_table.rb" and "delete_snapshot_by_table.rb" to separate the case from regex based operation; b) still in "list_snapshots.rb" and "delete_snapshot.rb", but add "-table" option to branch out from regex based operation path. Having a -table option don't seems to be inline with the current shell, I think that stuff like {{TABLE => 'name*' }} is used elsewhere (see create).. but I will pick the easy way with a new .rb seems that "delete_snapshot.rb" has no logic for regex based operation currently, will we also support it in this stream? yeah the delete snapshots is not in the shell at the moment.. I think there's a jira or a mention to open a new jira for the shell support. Jonathan Hsieh was against the regex delete. not sure what he thinks about this one... but at least this doesn't contain a regex for the table name.
          Hide
          Julian Zhou added a comment -

          Hi Matteo Bertozzi, I was just adding shell support just now. Curious about "rename_snapshot" could not work? looks like HBaseAdmin has no #renameSnapshot?

          Show
          Julian Zhou added a comment - Hi Matteo Bertozzi , I was just adding shell support just now. Curious about "rename_snapshot" could not work? looks like HBaseAdmin has no #renameSnapshot?
          Hide
          Matteo Bertozzi added a comment -

          Julian Zhou yeah rename_snapshot doesn't work, take a look at the last comment on HBASE-7218.

          Show
          Matteo Bertozzi added a comment - Julian Zhou yeah rename_snapshot doesn't work, take a look at the last comment on HBASE-7218 .
          Hide
          Julian Zhou added a comment -

          Oh, thanks Matteo Bertozzi for pointing. I should do a search first.. ok, may not include into this stream?
          Another question is that why not define more functions in admin module pointing to e.g. HBaseAdmin#listSnapshots(regex), #deleteSnapshots(regex).. then shell/command/*.rb module could invoke them directly, currently, list_snapshots module has its own regex processing logic implemented? "xxx.to_java_bytes" is mandatory for ruby->java method call?

          Show
          Julian Zhou added a comment - Oh, thanks Matteo Bertozzi for pointing. I should do a search first.. ok, may not include into this stream? Another question is that why not define more functions in admin module pointing to e.g. HBaseAdmin#listSnapshots(regex), #deleteSnapshots(regex).. then shell/command/*.rb module could invoke them directly, currently, list_snapshots module has its own regex processing logic implemented? "xxx.to_java_bytes" is mandatory for ruby->java method call?
          Hide
          Matteo Bertozzi added a comment -

          Another question is that why not define more functions in admin module pointing to e.g. HBaseAdmin#listSnapshots(regex), #deleteSnapshots(regex).. then shell/command/*.rb module could invoke them directly, currently, list_snapshots module has its own regex processing logic implemented? "xxx.to_java_bytes" is mandatory for ruby->java method call?

          No particular reason, the admin.listSnapshots(regex) & co were added later, and the shell was not updated to use them. and since the regex stuff is just a loop with an if there's no real advantage of having it in the admin, aside saving you from write 3 extra lines of code.
          Jon was suggesting to have extra logic in the shell for stuff like delete with regex, where you may want to add an "are you sure?" check in front.

          Show
          Matteo Bertozzi added a comment - Another question is that why not define more functions in admin module pointing to e.g. HBaseAdmin#listSnapshots(regex), #deleteSnapshots(regex).. then shell/command/*.rb module could invoke them directly, currently, list_snapshots module has its own regex processing logic implemented? "xxx.to_java_bytes" is mandatory for ruby->java method call? No particular reason, the admin.listSnapshots(regex) & co were added later, and the shell was not updated to use them. and since the regex stuff is just a loop with an if there's no real advantage of having it in the admin, aside saving you from write 3 extra lines of code. Jon was suggesting to have extra logic in the shell for stuff like delete with regex, where you may want to add an "are you sure?" check in front.
          Hide
          Julian Zhou added a comment -

          Hi, Matteo Bertozzi, applied the changes. Could you help review? Thanks~

          Show
          Julian Zhou added a comment - Hi, Matteo Bertozzi , applied the changes. Could you help review? Thanks~
          Hide
          Matteo Bertozzi added a comment -

          v1 looks good to me

          Show
          Matteo Bertozzi added a comment - v1 looks good to me
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12585434/8642-trunk-0.95-v1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12585434/8642-trunk-0.95-v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5886//console This message is automatically generated.
          Hide
          Matteo Bertozzi added a comment -

          I'll commit this one tomorrow, if there are no objections.

          Show
          Matteo Bertozzi added a comment - I'll commit this one tomorrow, if there are no objections.
          Hide
          Jonathan Hsieh added a comment -

          The idea of a delete by table name commands seems reasonable. This might get confusing if we have a rename table functionality but at the moment we don't.

          Show
          Jonathan Hsieh added a comment - The idea of a delete by table name commands seems reasonable. This might get confusing if we have a rename table functionality but at the moment we don't.
          Hide
          Ted Yu added a comment -
          +    def delete_snapshots_by_table(table)
          

          Can the new commands be made shorter ?

          Show
          Ted Yu added a comment - + def delete_snapshots_by_table(table) Can the new commands be made shorter ?
          Hide
          Matteo Bertozzi added a comment -

          this might get confusing if we have a rename table functionality but at the moment we don't.

          right... we sort of have the rename table mentioned in the docbook...
          since we don't have a proper naming system, my guess is that we should just alert the user... if you rename the table snapshots are not updated with the new table name...

          Show
          Matteo Bertozzi added a comment - this might get confusing if we have a rename table functionality but at the moment we don't. right... we sort of have the rename table mentioned in the docbook... since we don't have a proper naming system, my guess is that we should just alert the user... if you rename the table snapshots are not updated with the new table name...
          Hide
          Julian Zhou added a comment -

          Table rename is via cloning snapshot currently (so we rename the table this way, pairwisely we update all mapped snapshots?)? How about the claiming is that listing/deleting snapshot by table name is based on current table name available?

          For shorter cmd, how about "delete_table_snapshot"/"list_table_snapshot"?

          Show
          Julian Zhou added a comment - Table rename is via cloning snapshot currently (so we rename the table this way, pairwisely we update all mapped snapshots?)? How about the claiming is that listing/deleting snapshot by table name is based on current table name available? For shorter cmd, how about "delete_table_snapshot"/"list_table_snapshot"?
          Hide
          Julian Zhou added a comment -

          Yeah, RDBMS has object (database, tablespace, table, column, etc.) id in catalog, which make external name changable and transparent to system. Is it possible to using id (shorter) instead of original name bytes in ROOT/META? Just a question, this involve lots of changes to current HBase.

          Show
          Julian Zhou added a comment - Yeah, RDBMS has object (database, tablespace, table, column, etc.) id in catalog, which make external name changable and transparent to system. Is it possible to using id (shorter) instead of original name bytes in ROOT/META? Just a question, this involve lots of changes to current HBase.
          Hide
          Matteo Bertozzi added a comment -

          Table rename is via cloning snapshot currently (so we rename the table this way, pairwisely we update all mapped snapshots?)?

          No we don't update the other snapshots info... so they have the old table name...

          How about the claiming is that listing/deleting snapshot by table name is based on current table name available?

          I don't really understand this one... at the moment if you list by table name, you get also the snapshots of the renamed table.

          Yeah, RDBMS has object (database, tablespace, table, column, etc.) id in catalog, which make external name changable and transparent to system. Is it possible to using id (shorter) instead of original name bytes in ROOT/META? Just a question, this involve lots of changes to current HBase.

          Take a look at the last slide of HBASE-7806 pdf

          Show
          Matteo Bertozzi added a comment - Table rename is via cloning snapshot currently (so we rename the table this way, pairwisely we update all mapped snapshots?)? No we don't update the other snapshots info... so they have the old table name... How about the claiming is that listing/deleting snapshot by table name is based on current table name available? I don't really understand this one... at the moment if you list by table name, you get also the snapshots of the renamed table. Yeah, RDBMS has object (database, tablespace, table, column, etc.) id in catalog, which make external name changable and transparent to system. Is it possible to using id (shorter) instead of original name bytes in ROOT/META? Just a question, this involve lots of changes to current HBase. Take a look at the last slide of HBASE-7806 pdf
          Hide
          Ted Yu added a comment -

          how about "delete_table_snapshot"/"list_table_snapshot"?

          I think "delete_table_snapshots"/"list_table_snapshots" are good.

          Show
          Ted Yu added a comment - how about "delete_table_snapshot"/"list_table_snapshot"? I think "delete_table_snapshots"/"list_table_snapshots" are good.
          Hide
          Julian Zhou added a comment -

          Hi, Matteo Bertozzi, I see that last slide of HBASE-7806 for future, is that to seperate .data and .meta to enable possible file sharing among tables. One byte (256 items could be attached) for each node anchor under .data tree. This could be a new catalog system for hbase.

          Show
          Julian Zhou added a comment - Hi, Matteo Bertozzi , I see that last slide of HBASE-7806 for future, is that to seperate .data and .meta to enable possible file sharing among tables. One byte (256 items could be attached) for each node anchor under .data tree. This could be a new catalog system for hbase.
          Hide
          Matteo Bertozzi added a comment -

          is that to seperate data and meta to enable possible file sharing among tables. This could be a new catalog system for hbase.

          Yeah that's the idea... it not just file sharing between table/snapshots is also the ability to switch to managing blocks directly and avoid to rewrite everything during compactions.

          One byte (256 items could be attached) for each node anchor under .data tree.

          Not sure what you mean with this... The file placement using the first bytes of the hash/name is just to avoid the problem of too many files in a directory that old filesystems have, and a different way to store stuff removing the knowledge of table/region/cf that today is hardcoded. This doesn't really have effect on all the capabilities that you'll gain from the richer metadata system.

          (This stuff is starting being off topic here, since is not related 100% with this jira, if you've other question/suggestions/... just write it on HBASE-7806)

          Show
          Matteo Bertozzi added a comment - is that to seperate data and meta to enable possible file sharing among tables. This could be a new catalog system for hbase. Yeah that's the idea... it not just file sharing between table/snapshots is also the ability to switch to managing blocks directly and avoid to rewrite everything during compactions. One byte (256 items could be attached) for each node anchor under .data tree. Not sure what you mean with this... The file placement using the first bytes of the hash/name is just to avoid the problem of too many files in a directory that old filesystems have, and a different way to store stuff removing the knowledge of table/region/cf that today is hardcoded. This doesn't really have effect on all the capabilities that you'll gain from the richer metadata system. (This stuff is starting being off topic here, since is not related 100% with this jira, if you've other question/suggestions/... just write it on HBASE-7806 )
          Hide
          Julian Zhou added a comment -

          Updated with new ruby module name. Could we go ahead with this?

          Show
          Julian Zhou added a comment - Updated with new ruby module name. Could we go ahead with this?
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12585796/8642-trunk-0.95-v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12585796/8642-trunk-0.95-v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5907//console This message is automatically generated.
          Hide
          stack added a comment -

          Matteo Bertozzi You good w/ the last patch boss? If so, commit? I took a look and looks good to me. Thanks boss.

          Show
          stack added a comment - Matteo Bertozzi You good w/ the last patch boss? If so, commit? I took a look and looks good to me. Thanks boss.
          Hide
          stack added a comment -

          Matteo Bertozzi You see above boss?

          Show
          stack added a comment - Matteo Bertozzi You see above boss?
          Hide
          Matteo Bertozzi added a comment -

          patch looks good to me, now doesn't apply cleanly but the fix is trivial.
          my main concern with this feature is related to the rename semantic, where you rename a table and listing/deleting with the old rename results in including the snapshots made on before the rename table. Which may be fine, since may be considered not totally wrong and we don't have rename support in the core.

          so, I'm +1 on the code and +0 on the merge, I'll let you decide.

          Show
          Matteo Bertozzi added a comment - patch looks good to me, now doesn't apply cleanly but the fix is trivial. my main concern with this feature is related to the rename semantic, where you rename a table and listing/deleting with the old rename results in including the snapshots made on before the rename table. Which may be fine, since may be considered not totally wrong and we don't have rename support in the core. so, I'm +1 on the code and +0 on the merge, I'll let you decide.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12585796/8642-trunk-0.95-v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8184//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12585796/8642-trunk-0.95-v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8184//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12585796/8642-trunk-0.95-v2.patch
          against trunk revision .
          ATTACHMENT ID: 12585796

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10772//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12585796/8642-trunk-0.95-v2.patch against trunk revision . ATTACHMENT ID: 12585796 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10772//console This message is automatically generated.
          Hide
          Enis Soztutar added a comment -

          Lets do this. My only concern is that all new API should only be using TableName args, and not byte[] or String table name args.

          Show
          Enis Soztutar added a comment - Lets do this. My only concern is that all new API should only be using TableName args, and not byte[] or String table name args.

            People

            • Assignee:
              Julian Zhou
              Reporter:
              Julian Zhou
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:

                Development