Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      Namespace auditor provides basic quota support for namespaces in terms of number of tables and number of regions. In order to use namespace quotas, quota support must be enabled by setting
      "hbase.quota.enabled" property to true in hbase-site.xml file.

      The users can add quota information to namespace, while creating new namespaces or by altering existing ones.

      Examples:
      1. create_namespace 'ns1', {'hbase.namespace.quota.maxregions'=>'10'}
      2. create_namespace 'ns2', {'hbase.namespace.quota.maxtables'=>'2','hbase.namespace.quota.maxregions'=>'5'}
      3. alter_namespace 'ns3', {METHOD => 'set', 'hbase.namespace.quota.maxtables'=>'5','hbase.namespace.quota.maxregions'=>'25'}

      The quotas can be modified/added to namespace at any point of time. To remove quotas, the following command can be used:

      alter_namespace 'ns3', {METHOD => 'unset', NAME => 'hbase.namespace.quota.maxtables'}
      alter_namespace 'ns3', {METHOD => 'unset', NAME => 'hbase.namespace.quota.maxregions'}
      Show
      Namespace auditor provides basic quota support for namespaces in terms of number of tables and number of regions. In order to use namespace quotas, quota support must be enabled by setting "hbase.quota.enabled" property to true in hbase-site.xml file. The users can add quota information to namespace, while creating new namespaces or by altering existing ones. Examples: 1. create_namespace 'ns1', {'hbase.namespace.quota.maxregions'=>'10'} 2. create_namespace 'ns2', {'hbase.namespace.quota.maxtables'=>'2','hbase.namespace.quota.maxregions'=>'5'} 3. alter_namespace 'ns3', {METHOD => 'set', 'hbase.namespace.quota.maxtables'=>'5','hbase.namespace.quota.maxregions'=>'25'} The quotas can be modified/added to namespace at any point of time. To remove quotas, the following command can be used: alter_namespace 'ns3', {METHOD => 'unset', NAME => 'hbase.namespace.quota.maxtables'} alter_namespace 'ns3', {METHOD => 'unset', NAME => 'hbase.namespace.quota.maxregions'}

      Description

      This task involves creating an observer which provides basic quota support to namespaces in terms of (1) number of tables and (2) number of regions. The quota support can be enabled by setting:

      <property>
      <name>hbase.coprocessor.region.classes</name>
      <value>org.apache.hadoop.hbase.namespace.NamespaceController</value>
      </property>
      <property>
      <name>hbase.coprocessor.master.classes</name>
      <value>org.apache.hadoop.hbase.namespace.NamespaceController</value>
      </property>

      in the hbase-site.xml.

      To add quotas to namespace, while creating namespace properties need to be added.

      Examples:
      1. namespace_create 'ns1',

      {'hbase.namespace.quota.maxregion'=>'10'}

      2. 1. namespace_create 'ns2',

      {'hbase.namespace.quota.maxtables'=>'2'}

      ,

      {'hbase.namespace.quota.maxregion'=>'5'}

      The quotas can be modified/added to namespace at any point of time.

      1. HBASE-8410_trunk_14.patch
        132 kB
        Francis Liu
      2. HBASE-8410.docx
        202 kB
        Vandana Ayyalasomayajula
      3. HBASE-8410-master.patch
        76 kB
        Vandana Ayyalasomayajula
      4. HBASE-8410-master.1.patch
        58 kB
        Vandana Ayyalasomayajula
      5. HBASE-8410-master.4.patch
        59 kB
        Vandana Ayyalasomayajula
      6. HBASE-8410-master.5.patch
        60 kB
        Vandana Ayyalasomayajula
      7. HBASE-8410-master.6.patch
        60 kB
        Vandana Ayyalasomayajula
      8. HBASE-8410-master.7.patch
        61 kB
        Vandana Ayyalasomayajula
      9. HBASE-8410-master.9.patch
        55 kB
        Vandana Ayyalasomayajula
      10. 8410-master.9.patch
        55 kB
        Ted Yu

        Issue Links

          Activity

          Hide
          ashish singhi Ashish Singhi added a comment -

          Thanks Enis to the edit. It looks much better now.

          Show
          ashish singhi Ashish Singhi added a comment - Thanks Enis to the edit. It looks much better now.
          Hide
          enis Enis Soztutar added a comment -

          Thanks Ashish. I've edited the release notes.

          Show
          enis Enis Soztutar added a comment - Thanks Ashish. I've edited the release notes.
          Hide
          ashish singhi Ashish Singhi added a comment -

          In the release note example we need to correct the command used, there is no shell command namespace_create instead it should be create_namespace.
          Also if possible can we also mention in the example how a user can unset the maxtable/maxregions in the namespace

          alter_namespace 'ns3', {METHOD => 'unset', 'hbase.namespace.quota.maxtables'} 
          Show
          ashish singhi Ashish Singhi added a comment - In the release note example we need to correct the command used, there is no shell command namespace_create instead it should be create_namespace . Also if possible can we also mention in the example how a user can unset the maxtable/maxregions in the namespace alter_namespace 'ns3', {METHOD => 'unset', 'hbase.namespace.quota.maxtables'}
          Hide
          ashish singhi Ashish Singhi added a comment -

          Vandana Ayyalasomayajula are you planning to backport this issue ?
          If not, I can take up this task to backport to branch-1.

          Show
          ashish singhi Ashish Singhi added a comment - Vandana Ayyalasomayajula are you planning to backport this issue ? If not, I can take up this task to backport to branch-1.
          Hide
          enis Enis Soztutar added a comment -

          Also should I be creating a backport jira for branch-1 and 98 ? The code base seems quite different and some work needs to be done for the backport.

          Yes, I think this is the best way.
          Ted Yu you are gonna commit to branch-1?

          Show
          enis Enis Soztutar added a comment - Also should I be creating a backport jira for branch-1 and 98 ? The code base seems quite different and some work needs to be done for the backport. Yes, I think this is the best way. Ted Yu you are gonna commit to branch-1?
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          I have added release notes to this jira. Please let me know if I need to modify something. Also should I be creating a backport jira for branch-1 and 98 ? The code base seems quite different and some work needs to be done for the backport.

          Thanks Ted for committing the patch.

          Show
          avandana Vandana Ayyalasomayajula added a comment - I have added release notes to this jira. Please let me know if I need to modify something. Also should I be creating a backport jira for branch-1 and 98 ? The code base seems quite different and some work needs to be done for the backport. Thanks Ted for committing the patch.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          Can you update Release Note?

          Show
          anoop.hbase Anoop Sam John added a comment - Can you update Release Note?
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #6051 (See https://builds.apache.org/job/HBase-TRUNK/6051/)
          HBASE-8410 Basic quota support for namespaces (Vandana) (tedyu: rev 8261d84290b88b4b4609504096dc9dec3fbc788b)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RegionStateListener.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceTableAndRegionInfo.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/CreateTableHandler.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotaManager.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceStateManager.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceAuditor.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableNamespaceManager.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #6051 (See https://builds.apache.org/job/HBase-TRUNK/6051/ ) HBASE-8410 Basic quota support for namespaces (Vandana) (tedyu: rev 8261d84290b88b4b4609504096dc9dec3fbc788b) hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RegionStateListener.java hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceTableAndRegionInfo.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/CreateTableHandler.java hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotaManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceStateManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceAuditor.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableNamespaceManager.java
          Hide
          yuzhihong@gmail.com Ted Yu added a comment - - edited

          Integrated to master after addressing checkstyle nits.

          The above QA run stopped at hbase-rest module which should not have been caused by the patch.

          Thanks for the contribution, Vandana.

          Thanks for detailed review, Enis.

          Will watch for trunk build before integrating to branch-1

          Show
          yuzhihong@gmail.com Ted Yu added a comment - - edited Integrated to master after addressing checkstyle nits. The above QA run stopped at hbase-rest module which should not have been caused by the patch. Thanks for the contribution, Vandana. Thanks for detailed review, Enis. Will watch for trunk build before integrating to branch-1
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12694371/8410-master.9.patch
          against master branch at commit 588b43b06ba9a3434dc2178b5b014283cc959d62.
          ATTACHMENT ID: 12694371

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 1942 checkstyle errors (more than the master's current 1938 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12694371/8410-master.9.patch against master branch at commit 588b43b06ba9a3434dc2178b5b014283cc959d62. ATTACHMENT ID: 12694371 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 1942 checkstyle errors (more than the master's current 1938 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12579//console This message is automatically generated.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Previous QA run result is no longer accessible.

          Re-attaching to get result.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Previous QA run result is no longer accessible. Re-attaching to get result.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          The latest patch HBASE-8410-master.9.patch is the one in RB. So the last hadoopqa test results should be good.

          Show
          avandana Vandana Ayyalasomayajula added a comment - The latest patch HBASE-8410 -master.9.patch is the one in RB. So the last hadoopqa test results should be good.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Patch downloaded from reviewboard is 8410_trunk_16.patch whose rev number is different from the patch 9 above.

          @Vandana:
          Please attach latest patch for QA run.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Patch downloaded from reviewboard is 8410_trunk_16.patch whose rev number is different from the patch 9 above. @Vandana: Please attach latest patch for QA run.
          Hide
          enis Enis Soztutar added a comment -

          Thanks Vandana for bearing with me through the reviews. Forwarding my +1 from RB. I like that we have a simpler state tracking now.
          Will commit this tomorrow to branch-1 and master unless anybody else wants to review.

          Show
          enis Enis Soztutar added a comment - Thanks Vandana for bearing with me through the reviews. Forwarding my +1 from RB. I like that we have a simpler state tracking now. Will commit this tomorrow to branch-1 and master unless anybody else wants to review.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12692864/HBASE-8410-master.9.patch
          against master branch at commit 092c91eb0fc2a6b4044183e9ece71dd03711045d.
          ATTACHMENT ID: 12692864

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 2077 checkstyle errors (more than the master's current 2073 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12692864/HBASE-8410-master.9.patch against master branch at commit 092c91eb0fc2a6b4044183e9ece71dd03711045d. ATTACHMENT ID: 12692864 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 2077 checkstyle errors (more than the master's current 2073 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12494//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Latest patch in review board.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Latest patch in review board.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12690516/HBASE-8410-master.7.patch
          against master branch at commit 45fc2bdd863ff238491f4941b3da04a38731d7e1.
          ATTACHMENT ID: 12690516

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 2087 checkstyle errors (more than the master's current 2084 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690516/HBASE-8410-master.7.patch against master branch at commit 45fc2bdd863ff238491f4941b3da04a38731d7e1. ATTACHMENT ID: 12690516 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 2087 checkstyle errors (more than the master's current 2084 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12339//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Patch to fix unit tests.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Patch to fix unit tests.
          Hide
          enis Enis Soztutar added a comment -

          nvm. You had two RB links.

          Show
          enis Enis Soztutar added a comment - nvm. You had two RB links.
          Hide
          enis Enis Soztutar added a comment -

          Vandana mind putting the latest patch to RB as well. I think what you have there and here does not match.

          Show
          enis Enis Soztutar added a comment - Vandana mind putting the latest patch to RB as well. I think what you have there and here does not match.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12690406/HBASE-8410-master.6.patch
          against master branch at commit 45fc2bdd863ff238491f4941b3da04a38731d7e1.
          ATTACHMENT ID: 12690406

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 2087 checkstyle errors (more than the master's current 2084 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690406/HBASE-8410-master.6.patch against master branch at commit 45fc2bdd863ff238491f4941b3da04a38731d7e1. ATTACHMENT ID: 12690406 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 2087 checkstyle errors (more than the master's current 2084 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12335//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Patch for fixing javadoc and find bugs warnings.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Patch for fixing javadoc and find bugs warnings.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12690213/HBASE-8410-master.5.patch
          against master branch at commit 7774f964e62842806d849cae1a6af830c137d737.
          ATTACHMENT ID: 12690213

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 4 warning messages.

          -1 checkstyle. The applied patch generated 2087 checkstyle errors (more than the master's current 2084 errors).

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690213/HBASE-8410-master.5.patch against master branch at commit 7774f964e62842806d849cae1a6af830c137d737. ATTACHMENT ID: 12690213 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 4 warning messages. -1 checkstyle . The applied patch generated 2087 checkstyle errors (more than the master's current 2084 errors). -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12320//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Patch for fixing unit tests.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Patch for fixing unit tests.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12690142/HBASE-8410-master.4.patch
          against master branch at commit 24bcebdeeb5c8025a1171fd73b5f38e666ae819b.
          ATTACHMENT ID: 12690142

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 4 warning messages.

          -1 checkstyle. The applied patch generated 2084 checkstyle errors (more than the master's current 2081 errors).

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod
          org.apache.hadoop.hbase.regionserver.wal.TestWALReplay
          org.apache.hadoop.hbase.regionserver.TestJoinedScanners
          org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
          org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad
          org.apache.hadoop.hbase.regionserver.TestRegionReplicas
          org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed
          org.apache.hadoop.hbase.TestHBaseTestingUtility
          org.apache.hadoop.hbase.regionserver.TestRegionServerOnlineConfigChange
          org.apache.hadoop.hbase.regionserver.TestHRegion
          org.apache.hadoop.hbase.regionserver.TestRegionServerNoMaster
          org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster
          org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay
          org.apache.hadoop.hbase.regionserver.TestSCVFWithMiniCluster
          org.apache.hadoop.hbase.regionserver.TestFSErrorsExposed
          org.apache.hadoop.hbase.regionserver.TestEncryptionRandomKeying
          org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush

          -1 core zombie tests. There are 15 zombie test(s): at org.apache.hadoop.hbase.trace.TestHTraceHooks.testTraceCreateTable(TestHTraceHooks.java:71)
          at org.apache.hadoop.hbase.TestInfoServers.testMasterServerReadOnly(TestInfoServers.java:104)
          at org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort.testRSAbortWithUnflushedEdits(TestLogRollAbort.java:139)
          at org.apache.hadoop.hbase.regionserver.TestHRegion.testgetHDFSBlocksDistribution(TestHRegion.java:4146)
          at org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.testCompactionRecordDoesntBlockRolling(TestLogRolling.java:574)
          at org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics.testMutationsWithoutWal(TestRegionServerMetrics.java:192)
          at org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad.testAtomicBulkLoad(TestHRegionServerBulkLoad.java:292)
          at org.apache.hadoop.hbase.regionserver.TestCompactionState.testMajorCompactionOnFamily(TestCompactionState.java:74)
          at org.apache.hadoop.hbase.regionserver.TestEncryptionKeyRotation.testMasterKeyRotation(TestEncryptionKeyRotation.java:162)
          at org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testRSSplitDaughtersAreOnlinedAfterShutdownHandling(TestSplitTransactionOnCluster.java:291)
          at org.apache.hadoop.hbase.regionserver.TestScannerWithBulkload.testBulkLoad(TestScannerWithBulkload.java:76)
          at org.apache.hadoop.hbase.regionserver.TestTags.testTags(TestTags.java:120)
          at org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster.testMergeWithReplicas(TestRegionMergeTransactionOnCluster.java:329)

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690142/HBASE-8410-master.4.patch against master branch at commit 24bcebdeeb5c8025a1171fd73b5f38e666ae819b. ATTACHMENT ID: 12690142 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 4 warning messages. -1 checkstyle . The applied patch generated 2084 checkstyle errors (more than the master's current 2081 errors). -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod org.apache.hadoop.hbase.regionserver.wal.TestWALReplay org.apache.hadoop.hbase.regionserver.TestJoinedScanners org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad org.apache.hadoop.hbase.regionserver.TestRegionReplicas org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed org.apache.hadoop.hbase.TestHBaseTestingUtility org.apache.hadoop.hbase.regionserver.TestRegionServerOnlineConfigChange org.apache.hadoop.hbase.regionserver.TestHRegion org.apache.hadoop.hbase.regionserver.TestRegionServerNoMaster org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay org.apache.hadoop.hbase.regionserver.TestSCVFWithMiniCluster org.apache.hadoop.hbase.regionserver.TestFSErrorsExposed org.apache.hadoop.hbase.regionserver.TestEncryptionRandomKeying org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush -1 core zombie tests . There are 15 zombie test(s): at org.apache.hadoop.hbase.trace.TestHTraceHooks.testTraceCreateTable(TestHTraceHooks.java:71) at org.apache.hadoop.hbase.TestInfoServers.testMasterServerReadOnly(TestInfoServers.java:104) at org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort.testRSAbortWithUnflushedEdits(TestLogRollAbort.java:139) at org.apache.hadoop.hbase.regionserver.TestHRegion.testgetHDFSBlocksDistribution(TestHRegion.java:4146) at org.apache.hadoop.hbase.regionserver.wal.TestLogRolling.testCompactionRecordDoesntBlockRolling(TestLogRolling.java:574) at org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics.testMutationsWithoutWal(TestRegionServerMetrics.java:192) at org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad.testAtomicBulkLoad(TestHRegionServerBulkLoad.java:292) at org.apache.hadoop.hbase.regionserver.TestCompactionState.testMajorCompactionOnFamily(TestCompactionState.java:74) at org.apache.hadoop.hbase.regionserver.TestEncryptionKeyRotation.testMasterKeyRotation(TestEncryptionKeyRotation.java:162) at org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testRSSplitDaughtersAreOnlinedAfterShutdownHandling(TestSplitTransactionOnCluster.java:291) at org.apache.hadoop.hbase.regionserver.TestScannerWithBulkload.testBulkLoad(TestScannerWithBulkload.java:76) at org.apache.hadoop.hbase.regionserver.TestTags.testTags(TestTags.java:120) at org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster.testMergeWithReplicas(TestRegionMergeTransactionOnCluster.java:329) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12306//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Latest patch from review board after addressing comments.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Latest patch from review board after addressing comments.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          3 new files, e.g. NamespaceAuditor, don't have interface audience annotation.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - 3 new files, e.g. NamespaceAuditor, don't have interface audience annotation.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12688629/HBASE-8410-master.1.patch
          against master branch at commit a1fe1e09642355aa8165c11da3f759d621da1421.
          ATTACHMENT ID: 12688629

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 4 warning messages.

          -1 checkstyle. The applied patch generated 2090 checkstyle errors (more than the master's current 2085 errors).

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.TestInterfaceAudienceAnnotations

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/patchReleaseAuditWarnings.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12688629/HBASE-8410-master.1.patch against master branch at commit a1fe1e09642355aa8165c11da3f759d621da1421. ATTACHMENT ID: 12688629 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 4 warning messages. -1 checkstyle . The applied patch generated 2090 checkstyle errors (more than the master's current 2085 errors). -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. -1 release audit . The applied patch generated 1 release audit warnings (more than the master's current 0 warnings). +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.TestInterfaceAudienceAnnotations Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/patchReleaseAuditWarnings.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12183//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Updated patch for master. Removed .backup file. The inclusion was unintentional.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Updated patch for master. Removed .backup file. The inclusion was unintentional.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          The inclusion of TestNamespaceAuditor.java.backup was not intentional, I think.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - The inclusion of TestNamespaceAuditor.java.backup was not intentional, I think.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12688454/HBASE-8410-master.patch
          against master branch at commit 40fb2e921936a0d207efd5d06c6300fe180c66af.
          ATTACHMENT ID: 12688454

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 5 warning messages.

          -1 checkstyle. The applied patch generated 2090 checkstyle errors (more than the master's current 2085 errors).

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.TestInterfaceAudienceAnnotations

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12688454/HBASE-8410-master.patch against master branch at commit 40fb2e921936a0d207efd5d06c6300fe180c66af. ATTACHMENT ID: 12688454 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 5 warning messages. -1 checkstyle . The applied patch generated 2090 checkstyle errors (more than the master's current 2085 errors). -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.TestInterfaceAudienceAnnotations Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12168//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Updated patch for master.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Updated patch for master.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Review board request: https://reviews.apache.org/r/28685

          Show
          avandana Vandana Ayyalasomayajula added a comment - Review board request: https://reviews.apache.org/r/28685
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Patch for latest 98 branch. There is another JIRA which address quota in general, https://issues.apache.org/jira/browse/HBASE-11999.

          Please suggest how I should proceed for master and branch-1 patch ?

          Show
          avandana Vandana Ayyalasomayajula added a comment - Patch for latest 98 branch. There is another JIRA which address quota in general, https://issues.apache.org/jira/browse/HBASE-11999 . Please suggest how I should proceed for master and branch-1 patch ?
          Hide
          stack stack added a comment -

          See here http://hbase.apache.org/xref/org/apache/hadoop/hbase/regionserver/SplitTransaction.html#312 See how RS sets region into PENDING_SPLIT mode and the master must transition it for the split to proceed? Master could remove the znode. You could have the RS fail gracefully w/ nice log message and just skip the split?

          Show
          stack stack added a comment - See here http://hbase.apache.org/xref/org/apache/hadoop/hbase/regionserver/SplitTransaction.html#312 See how RS sets region into PENDING_SPLIT mode and the master must transition it for the split to proceed? Master could remove the znode. You could have the RS fail gracefully w/ nice log message and just skip the split?
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          stack If we are looking at alternative to disabling table to avoid region splits, how can the master control a region from splitting ? In my understanding, region splits are controlled at the region server level. Please help me in case I am missing any links.

          Show
          avandana Vandana Ayyalasomayajula added a comment - stack If we are looking at alternative to disabling table to avoid region splits, how can the master control a region from splitting ? In my understanding, region splits are controlled at the region server level. Please help me in case I am missing any links.
          Hide
          stack stack added a comment -

          Also as I understood stack's suggestion, we can have namespace auditor running on master and region servers but on region servers, it would only ask permission of master in the pre-split hook.

          Pardon me Vandana. I should have been more clear. I was suggesting that you do not need to have a process on the regionserver if you want to prevent splitting. A process running on the master only should be sufficient.

          Show
          stack stack added a comment - Also as I understood stack's suggestion, we can have namespace auditor running on master and region servers but on region servers, it would only ask permission of master in the pre-split hook. Pardon me Vandana. I should have been more clear. I was suggesting that you do not need to have a process on the regionserver if you want to prevent splitting. A process running on the master only should be sufficient.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          On the Master manage RegionSplitPolicy details in the schema such that the user/application cannot override the settings. For example, when through polling you discover a table is at or just slightly over a high water mark, disable region splits by setting “hbase.hregion.max.filesize” in the table schema to the maximum value and set the split policy in the schema to ConstantSizeRegionSplitPolicy.
          What this won't cover is interception of administrative split requests made directly to the regionserver. However you could still handle this in the master by watching for when the number of regions for a table is at or over a hard limit. Respond by offlining the table. A regionserver won't process a split request for a region it is not serving. This achieves the objective of stopping a runaway user or application.

          {quote }

          We would want to stop the bad users/ applications but not necessarily disable their tables or change any table properties. I would prefer not allowing further operations ( create table or region splits ). We can a chore which regularly reads ( how frequently can be a config variable) meta and updates zk, cache. Also as I understood stack's suggestion, we can have namespace auditor running on master and region servers but on region servers, it would only ask permission of master in the pre-split hook.
          Let me know your opinion on this approach.

          Show
          avandana Vandana Ayyalasomayajula added a comment - On the Master manage RegionSplitPolicy details in the schema such that the user/application cannot override the settings. For example, when through polling you discover a table is at or just slightly over a high water mark, disable region splits by setting “hbase.hregion.max.filesize” in the table schema to the maximum value and set the split policy in the schema to ConstantSizeRegionSplitPolicy. What this won't cover is interception of administrative split requests made directly to the regionserver. However you could still handle this in the master by watching for when the number of regions for a table is at or over a hard limit. Respond by offlining the table. A regionserver won't process a split request for a region it is not serving. This achieves the objective of stopping a runaway user or application. {quote } We would want to stop the bad users/ applications but not necessarily disable their tables or change any table properties. I would prefer not allowing further operations ( create table or region splits ). We can a chore which regularly reads ( how frequently can be a config variable) meta and updates zk, cache. Also as I understood stack's suggestion, we can have namespace auditor running on master and region servers but on region servers, it would only ask permission of master in the pre-split hook. Let me know your opinion on this approach.
          Hide
          apurtell Andrew Purtell added a comment -

          Just to say that RS now asks the Master if they can split.

          Great

          Show
          apurtell Andrew Purtell added a comment - Just to say that RS now asks the Master if they can split. Great
          Hide
          stack stack added a comment -

          Just to say that RS now asks the Master if they can split. Master could stop the split when asked and the region count is over quota.

          Show
          stack stack added a comment - Just to say that RS now asks the Master if they can split. Master could stop the split when asked and the region count is over quota.
          Hide
          apurtell Andrew Purtell added a comment -

          If a table is splitting really aggressively, this is either due to unexpected/uncontrolled high rate ingest or botched split policy settings to the same effect, or runaway admin requests. For all of those cases offlining the table seems like the right thing to do?

          Show
          apurtell Andrew Purtell added a comment - If a table is splitting really aggressively, this is either due to unexpected/uncontrolled high rate ingest or botched split policy settings to the same effect, or runaway admin requests. For all of those cases offlining the table seems like the right thing to do?
          Hide
          apurtell Andrew Purtell added a comment -

          We are trying to stop users who might be running applications which might be accidentally creating large number of tables or regions.

          Understood. It would be good to reconsider if you really need something running in the regionserver though. Installing a RegionObserver adds a certain (small) cost to every op even though you are only sitting on a pre split hook. Rejecting splits in a pre split hook is messy as mentioned above because you are not changing the higher level decisionmaking on whether to split or not in the first place. Coordinating between multiple processes on the cluster requires either meta scanning or the ZK mediated cache, which could be avoided if there is a single arbiter running in the master.

          ... accidentally creating large number of tables ///

          Can be handled in the master by intercepting table create requests in the namespace

          .. accidentally creating large number of [...] regions ...

          On the Master manage RegionSplitPolicy details in the schema such that the user/application cannot override the settings. For example, when through polling you discover a table is at or just slightly over a high water mark, disable region splits by setting “hbase.hregion.max.filesize” in the table schema to the maximum value and set the split policy in the schema to ConstantSizeRegionSplitPolicy.

          What this won't cover is interception of administrative split requests made directly to the regionserver. However you could still handle this in the master by watching for when the number of regions for a table is at or over a hard limit. Respond by offlining the table. A regionserver won't process a split request for a region it is not serving. This achieves the objective of stopping a runaway user or application.

          Show
          apurtell Andrew Purtell added a comment - We are trying to stop users who might be running applications which might be accidentally creating large number of tables or regions. Understood. It would be good to reconsider if you really need something running in the regionserver though. Installing a RegionObserver adds a certain (small) cost to every op even though you are only sitting on a pre split hook. Rejecting splits in a pre split hook is messy as mentioned above because you are not changing the higher level decisionmaking on whether to split or not in the first place. Coordinating between multiple processes on the cluster requires either meta scanning or the ZK mediated cache, which could be avoided if there is a single arbiter running in the master. ... accidentally creating large number of tables /// Can be handled in the master by intercepting table create requests in the namespace .. accidentally creating large number of [...] regions ... On the Master manage RegionSplitPolicy details in the schema such that the user/application cannot override the settings. For example, when through polling you discover a table is at or just slightly over a high water mark, disable region splits by setting “hbase.hregion.max.filesize” in the table schema to the maximum value and set the split policy in the schema to ConstantSizeRegionSplitPolicy. What this won't cover is interception of administrative split requests made directly to the regionserver. However you could still handle this in the master by watching for when the number of regions for a table is at or over a hard limit. Respond by offlining the table. A regionserver won't process a split request for a region it is not serving. This achieves the objective of stopping a runaway user or application.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          We are trying to stop users who might be running applications which might be accidentally creating large number of tables or regions. That is the reason we want to actively manage region counts. The major issue being discussed on RB is the META region being scanned often. As per your suggestion, if the META region's observer scans the meta once and updates ZK with namespace state information and late on acts as the only writer , then scans to the META will be reduced.
          Is that okay with you ?

          Show
          avandana Vandana Ayyalasomayajula added a comment - We are trying to stop users who might be running applications which might be accidentally creating large number of tables or regions. That is the reason we want to actively manage region counts. The major issue being discussed on RB is the META region being scanned often. As per your suggestion, if the META region's observer scans the meta once and updates ZK with namespace state information and late on acts as the only writer , then scans to the META will be reduced. Is that okay with you ?
          Hide
          apurtell Andrew Purtell added a comment -

          It is relatively messy if we treat a region quota as an absolute and actively manage it. A coprocessor can sit in the preSplit hook and reject split transactions. However, this will not prevent the regionserver from deciding to try and split the region again (and again). I'm not sure anything will stop the resulting log spam but raising the quota or an online schema update. (See below.)

          Another issue is all of the meta scanning that might be involved if the namespace auditor is running on all regionservers as well as the master. There's been some discussion about mitigating this on RB, but the issue could be side stepped.

          How about accepting that the region limit is a soft limit. Then instead of running on every regionserver the auditor needs only run on the master, periodically poll meta for if a namespace has crossed the threshold, and then issue online schema updates to update the split policy and/or split parameters for the table or all tables in the namespace. Would this work? Would avoid the two issues mentioned above I think.

          Show
          apurtell Andrew Purtell added a comment - It is relatively messy if we treat a region quota as an absolute and actively manage it. A coprocessor can sit in the preSplit hook and reject split transactions. However, this will not prevent the regionserver from deciding to try and split the region again (and again). I'm not sure anything will stop the resulting log spam but raising the quota or an online schema update. (See below.) Another issue is all of the meta scanning that might be involved if the namespace auditor is running on all regionservers as well as the master. There's been some discussion about mitigating this on RB, but the issue could be side stepped. How about accepting that the region limit is a soft limit. Then instead of running on every regionserver the auditor needs only run on the master, periodically poll meta for if a namespace has crossed the threshold, and then issue online schema updates to update the split policy and/or split parameters for the table or all tables in the namespace. Would this work? Would avoid the two issues mentioned above I think.
          Hide
          apurtell Andrew Purtell added a comment -

          I put up some comments on logic and implementation issues on RB that should be addressed before this goes in.

          Show
          apurtell Andrew Purtell added a comment - I put up some comments on logic and implementation issues on RB that should be addressed before this goes in.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12635381/HBASE-8410_trunk_15.patch
          against trunk revision .
          ATTACHMENT ID: 12635381

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + private NamespaceTableAndRegionInfo(boolean noInit)

          { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
          + private TableRegionCountPair(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12635381/HBASE-8410_trunk_15.patch against trunk revision . ATTACHMENT ID: 12635381 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + private NamespaceTableAndRegionInfo(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); } + private TableRegionCountPair(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); } +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9036//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -
          Show
          avandana Vandana Ayyalasomayajula added a comment - Review board request: https://reviews.apache.org/r/19367/
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Rebased patch with corrected formatting.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Rebased patch with corrected formatting.
          Hide
          stack stack added a comment -

          Can we also post the patch on rb? Thanks.

          Show
          stack stack added a comment - Can we also post the patch on rb? Thanks.
          Hide
          stack stack added a comment -

          Formatting is odd in ProtobufUtil

          Formatting is odd in general in this patch. Please see rest of hbase code (two spaces for a tab, etc.)

          Any chance of a high-level writeup on how this patch works before start in on a review?

          Does the patch apply still?

          Thanks.

          Show
          stack stack added a comment - Formatting is odd in ProtobufUtil Formatting is odd in general in this patch. Please see rest of hbase code (two spaces for a tab, etc.) Any chance of a high-level writeup on how this patch works before start in on a review? Does the patch apply still? Thanks.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          +1

          Show
          yuzhihong@gmail.com Ted Yu added a comment - +1
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12626012/HBASE-8410_trunk_14.patch
          against trunk revision .
          ATTACHMENT ID: 12626012

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + private NamespaceTableAndRegionInfo(boolean noInit)

          { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
          + private TableRegionCountPair(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12626012/HBASE-8410_trunk_14.patch against trunk revision . ATTACHMENT ID: 12626012 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + private NamespaceTableAndRegionInfo(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); } + private TableRegionCountPair(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); } +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8556//console This message is automatically generated.
          Hide
          toffer Francis Liu added a comment -

          Submitting a patch with the minor change from Ted in behalf of Vandana as she is on leave.

          Show
          toffer Francis Liu added a comment - Submitting a patch with the minor change from Ted in behalf of Vandana as she is on leave.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          +1, with javadoc warning fixed.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - +1, with javadoc warning fixed.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Please correct this javadoc warning:

          [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/NamespaceTableAndRegionInfo.java:187: warning - @param argument "TableAndRegionInfo" is not a parameter name.
          
          Show
          yuzhihong@gmail.com Ted Yu added a comment - Please correct this javadoc warning: [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/NamespaceTableAndRegionInfo.java:187: warning - @param argument "TableAndRegionInfo" is not a parameter name.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12623763/HBASE-8410_trunk_13.patch
          against trunk revision .
          ATTACHMENT ID: 12623763

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + private NamespaceTableAndRegionInfo(boolean noInit)

          { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
          + private TableRegionCountPair(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }

          -1 site. The patch appears to cause mvn site goal to fail.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623763/HBASE-8410_trunk_13.patch against trunk revision . ATTACHMENT ID: 12623763 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + private NamespaceTableAndRegionInfo(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); } + private TableRegionCountPair(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); } -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8467//console This message is automatically generated.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          From https://builds.apache.org/job/PreCommit-HBASE-Build/8456//testReport/org.apache.hadoop.hbase.namespace/TestNamespaceAuditor/testRegionOperations/ :

          2014-01-17 05:27:16,370 INFO  [pool-1-thread-1] namespace.TestNamespaceAuditor(163): org.apache.hadoop.hbase.DoNotRetryIOException: org.apache.hadoop.hbase.DoNotRetryIOException: The table TestNamespaceAuditor_regiontest:table1 is not allowed to have 7 regions. The total number of regions permitted is only 6, while current region count is 0. This may be transient, please retry later if there are any ongoing split operations in the namespace.
          	at org.apache.hadoop.hbase.namespace.NamespaceAuditor.checkNamespaceTableCount(NamespaceAuditor.java:322)
          	at org.apache.hadoop.hbase.namespace.NamespaceAuditor.preCreateTable(NamespaceAuditor.java:82)
          	at org.apache.hadoop.hbase.master.MasterCoprocessorHost.preCreateTable(MasterCoprocessorHost.java:235)
          	at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:1733)
          	at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:1766)
          	at org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java:38221)
          	at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2008)
          	at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:92)
          	at org.apache.hadoop.hbase.ipc.FifoRpcScheduler$1.run(FifoRpcScheduler.java:73)
          	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
          	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
          	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
          	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
          	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
          	at java.lang.Thread.run(Thread.java:662)
          
          2014-01-17 05:27:16,371 DEBUG [pool-1-thread-1-EventThread] hbase.ZKNamespaceStateManager(205): Updating namespace state cache from node path /hbase/namespace-state/TestNamespaceAuditor_regiontest with data: NamespaceTableAndRegionInfo [name=TestNamespaceAuditor_regiontest, tableRegionInfoMap={}]
          

          ZKNamespaceStateManager received notification 1 millisecond later than the receipt of DoNotRetryIOException

          Please handle this scenario accordingly.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - From https://builds.apache.org/job/PreCommit-HBASE-Build/8456//testReport/org.apache.hadoop.hbase.namespace/TestNamespaceAuditor/testRegionOperations/ : 2014-01-17 05:27:16,370 INFO [pool-1-thread-1] namespace.TestNamespaceAuditor(163): org.apache.hadoop.hbase.DoNotRetryIOException: org.apache.hadoop.hbase.DoNotRetryIOException: The table TestNamespaceAuditor_regiontest:table1 is not allowed to have 7 regions. The total number of regions permitted is only 6, while current region count is 0. This may be transient , please retry later if there are any ongoing split operations in the namespace. at org.apache.hadoop.hbase.namespace.NamespaceAuditor.checkNamespaceTableCount(NamespaceAuditor.java:322) at org.apache.hadoop.hbase.namespace.NamespaceAuditor.preCreateTable(NamespaceAuditor.java:82) at org.apache.hadoop.hbase.master.MasterCoprocessorHost.preCreateTable(MasterCoprocessorHost.java:235) at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:1733) at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:1766) at org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java:38221) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2008) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:92) at org.apache.hadoop.hbase.ipc.FifoRpcScheduler$1.run(FifoRpcScheduler.java:73) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang. Thread .run( Thread .java:662) 2014-01-17 05:27:16,371 DEBUG [pool-1-thread-1-EventThread] hbase.ZKNamespaceStateManager(205): Updating namespace state cache from node path /hbase/namespace-state/TestNamespaceAuditor_regiontest with data: NamespaceTableAndRegionInfo [name=TestNamespaceAuditor_regiontest, tableRegionInfoMap={}] ZKNamespaceStateManager received notification 1 millisecond later than the receipt of DoNotRetryIOException Please handle this scenario accordingly.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12623561/HBASE-8410_trunk_12.patch
          against trunk revision .
          ATTACHMENT ID: 12623561

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + private NamespaceTableAndRegionInfo(boolean noInit)

          { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
          + private TableRegionCountPair(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }

          -1 site. The patch appears to cause mvn site goal to fail.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.namespace.TestNamespaceAuditor

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623561/HBASE-8410_trunk_12.patch against trunk revision . ATTACHMENT ID: 12623561 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + private NamespaceTableAndRegionInfo(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); } + private TableRegionCountPair(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); } -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.namespace.TestNamespaceAuditor Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8456//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Ted Yu The new patch should fix the warnings.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Ted Yu The new patch should fix the warnings.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Thanks for the new patch.

          Do you mind fixing findbugs and javadoc warnings ?

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Thanks for the new patch. Do you mind fixing findbugs and javadoc warnings ?
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12623448/HBASE-8410_trunk_11.patch
          against trunk revision .
          ATTACHMENT ID: 12623448

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + private NamespaceTableAndRegionInfo(boolean noInit)

          { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
          + private TableRegionCountPair(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }

          -1 site. The patch appears to cause mvn site goal to fail.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623448/HBASE-8410_trunk_11.patch against trunk revision . ATTACHMENT ID: 12623448 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + private NamespaceTableAndRegionInfo(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); } + private TableRegionCountPair(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); } -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8446//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Fixed a NPE condition.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Fixed a NPE condition.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12623227/HBASE-8410_trunk_10.patch
          against trunk revision .
          ATTACHMENT ID: 12623227

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + private NamespaceTableAndRegionInfo(boolean noInit)

          { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
          + private TableRegionCountPair(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }

          -1 site. The patch appears to cause mvn site goal to fail.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.namespace.TestNamespaceAuditor

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623227/HBASE-8410_trunk_10.patch against trunk revision . ATTACHMENT ID: 12623227 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + private NamespaceTableAndRegionInfo(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); } + private TableRegionCountPair(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); } -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.namespace.TestNamespaceAuditor Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8439//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Ted Yu Addressed the comments. Thanks!

          Show
          avandana Vandana Ayyalasomayajula added a comment - Ted Yu Addressed the comments. Thanks!
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          @Vandana:
          Can you take a look at my comment dated 09/Jan/14 14:01 ?

          Thanks

          Show
          yuzhihong@gmail.com Ted Yu added a comment - @Vandana: Can you take a look at my comment dated 09/Jan/14 14:01 ? Thanks
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Alright.
          My last question got an answer.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Alright. My last question got an answer.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12622260/HBASE-8410_trunk_10.patch
          against trunk revision .
          ATTACHMENT ID: 12622260

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + private NamespaceTableAndRegionInfo(boolean noInit)

          { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }
          + private TableRegionCountPair(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); }

          -1 site. The patch appears to cause mvn site goal to fail.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12622260/HBASE-8410_trunk_10.patch against trunk revision . ATTACHMENT ID: 12622260 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + private NamespaceTableAndRegionInfo(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); } + private TableRegionCountPair(boolean noInit) { this.unknownFields = com.google.protobuf.UnknownFieldSet.getDefaultInstance(); } -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8379//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          What do you mean by registered ? In the test case, TestNamespaceAuditor beforeClass method has the following.

          conf.setStrings(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY,
          NamespaceAuditor.class.getName());
          conf.setStrings(CoprocessorHost.REGION_COPROCESSOR_CONF_KEY,
          NamespaceAuditor.class.getName());

          Also, the namespace auditor runs at the master and the regions.

          Show
          avandana Vandana Ayyalasomayajula added a comment - What do you mean by registered ? In the test case, TestNamespaceAuditor beforeClass method has the following. conf.setStrings(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY, NamespaceAuditor.class.getName()); conf.setStrings(CoprocessorHost.REGION_COPROCESSOR_CONF_KEY, NamespaceAuditor.class.getName()); Also, the namespace auditor runs at the master and the regions.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Where is NamespaceAuditor registered ?
          I searched the patch but couldn't find registration.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Where is NamespaceAuditor registered ? I searched the patch but couldn't find registration.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -
          +public class ZKNamespaceStateManager extends ZooKeeperListener {
          

          Please add class javadoc.

          +  * Starts the ZKNamespaceStateManager and created the associated ZNode.
          

          'created' -> 'creates'

          +  * @return the state
          +  * @throws IOException Signals that an I/O exception has occurred.
          +  */
          + public NamespaceTableAndRegionInfo getState(String name) throws IOException {
          +   NamespaceTableAndRegionInfo info = nsStateCache.get(name);
          

          Would IOException come from ConcurrentSkipListMap.get() ?
          Please clarify the return value javadoc.

          +     if (nodeData.length != 0) {
          +     NamespaceTableAndRegionInfo ns = ProtobufUtil
          +         .toNamespaceState(NamespaceStateProtos.NamespaceTableAndRegionInfo
          +             .parseFrom(nodeData));
          +     nsStateCache.put(ns.getName(), ns);
          +     } else {
          

          Please fix indentation in the if block.

          +@InterfaceAudience.Public
          +public class NamespaceAuditor extends BaseRegionObserver implements MasterObserver {
          

          Can NamespaceAuditor be marked @InterfaceAudience.Private ?

          +    } else if (e instanceof RegionCoprocessorEnvironment) {
          +      // if running at region
          +      RegionCoprocessorEnvironment regionEnv = (RegionCoprocessorEnvironment) e;
          +      rsServices = regionEnv.getRegionServerServices();
          +      stateManager = new ZKNamespaceStateManager(rsServices.getZooKeeper());
          +    }
          

          Is the above needed ? I thought auditor runs at region server level.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - + public class ZKNamespaceStateManager extends ZooKeeperListener { Please add class javadoc. + * Starts the ZKNamespaceStateManager and created the associated ZNode. 'created' -> 'creates' + * @ return the state + * @ throws IOException Signals that an I/O exception has occurred. + */ + public NamespaceTableAndRegionInfo getState( String name) throws IOException { + NamespaceTableAndRegionInfo info = nsStateCache.get(name); Would IOException come from ConcurrentSkipListMap.get() ? Please clarify the return value javadoc. + if (nodeData.length != 0) { + NamespaceTableAndRegionInfo ns = ProtobufUtil + .toNamespaceState(NamespaceStateProtos.NamespaceTableAndRegionInfo + .parseFrom(nodeData)); + nsStateCache.put(ns.getName(), ns); + } else { Please fix indentation in the if block. +@InterfaceAudience.Public + public class NamespaceAuditor extends BaseRegionObserver implements MasterObserver { Can NamespaceAuditor be marked @InterfaceAudience.Private ? + } else if (e instanceof RegionCoprocessorEnvironment) { + // if running at region + RegionCoprocessorEnvironment regionEnv = (RegionCoprocessorEnvironment) e; + rsServices = regionEnv.getRegionServerServices(); + stateManager = new ZKNamespaceStateManager(rsServices.getZooKeeper()); + } Is the above needed ? I thought auditor runs at region server level.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Ted Yu – Would you be able to do a fresh review ? I have changed the code quite a bit from your previous review. Thanks!
          Stack – With the latest patch, meta is not scanned every time, only once after master starts up. In your previous comments, you wanted to know why ZK namespace manager is required in the RS. The auditor runs in the master and all the region servers. So instead of starting zk namepsace manager on all the regions, I had it the RS, so that all the regions belonging to the RS can shared it.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Ted Yu – Would you be able to do a fresh review ? I have changed the code quite a bit from your previous review. Thanks! Stack – With the latest patch, meta is not scanned every time, only once after master starts up. In your previous comments, you wanted to know why ZK namespace manager is required in the RS. The auditor runs in the master and all the region servers. So instead of starting zk namepsace manager on all the regions, I had it the RS, so that all the regions belonging to the RS can shared it.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          New version of the patch with comments addressed.

          The changes made are the following:

          1. Added ZKNamespaceStateManager class which tracks the state of a namespace in terms of number of tables and regions.

          2. Meta region is not scanned every time for a table is created or split.

          Show
          avandana Vandana Ayyalasomayajula added a comment - New version of the patch with comments addressed. The changes made are the following: 1. Added ZKNamespaceStateManager class which tracks the state of a namespace in terms of number of tables and regions. 2. Meta region is not scanned every time for a table is created or split.
          Hide
          heliangliang He Liangliang added a comment -

          added HBASE-9817

          Show
          heliangliang He Liangliang added a comment - added HBASE-9817
          Hide
          heliangliang He Liangliang added a comment -

          Vandana Ayyalasomayajula stack Is there plan to add throughput quota support, i.e. limiting the read/write per sec for a namespace (more precisely, table) or (kerberos principal, namespace)? It's a desirable feature in a shared cluster. In a step forward, guaranteeing the throughput is also a nice feature to have but much difficult.

          Show
          heliangliang He Liangliang added a comment - Vandana Ayyalasomayajula stack Is there plan to add throughput quota support, i.e. limiting the read/write per sec for a namespace (more precisely, table) or (kerberos principal, namespace)? It's a desirable feature in a shared cluster. In a step forward, guaranteeing the throughput is also a nice feature to have but much difficult.
          Hide
          stack stack added a comment -

          Sorry Vandana Ayyalasomayajula. Distracted.

          So we will scan meta a bunch. It is necessary? Can we do less scanning of the meta at all? It is an in-demand resource already.

          Sorry. I still don't get why zknm in the RS. Isn't it the master that runs the audit?

          Reading your justification and synopsizing: "NS Descriptor has counts. Need to read NS Descriptor. For some reason this requires running a zknamespacemanager" Why the latter? Why does the master not just scan the ns table to get the descriptor so it can do its audit check?

          Sorry if I am being slow.

          Please remove code that is not being used, yes.

          Show
          stack stack added a comment - Sorry Vandana Ayyalasomayajula . Distracted. So we will scan meta a bunch. It is necessary? Can we do less scanning of the meta at all? It is an in-demand resource already. Sorry. I still don't get why zknm in the RS. Isn't it the master that runs the audit? Reading your justification and synopsizing: "NS Descriptor has counts. Need to read NS Descriptor. For some reason this requires running a zknamespacemanager" Why the latter? Why does the master not just scan the ns table to get the descriptor so it can do its audit check? Sorry if I am being slow. Please remove code that is not being used, yes.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Stack Can you please look at the above comments ? I will make required changes and submit a new patch based on your feedback.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Stack Can you please look at the above comments ? I will make required changes and submit a new patch based on your feedback.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          The method is used while tables are creates and when a region is split, to check then number of tables and regions in a given namespace.

          Everytime a new table is created and each time we split, we scan the .META. table? Am I reading this right?

          That is right.

          getNamespaceDescRetriever is the wrong name for a method that returns a NamespaceDescriptors

          I will fix it. My bad, this should have been corrected.

          I am still unclear why we need auditing facility in the regionserver?I do not understand how you expect auditing to work going by the patch. I see that there is NamespaceAuditor which implements MasterObserver and so intercepts master ops to check counts. I do not see why I need the manager running in a RS?

          The auditing facility is required only on the regions and master, to check if a given namespace never exceeds a given number of tables and regions ( quota set while creating namespace). The information about the exact number of regions and tables allowed is stored in the namespace descriptor. So for auditing purposes, namespace descriptor is needed. The namespace descriptor can be retrieved from the Zk namespace manager. So, either I get zk instance from region server and start one zk namespace manager for every region or I could create one in region server and share it among all the regions. I have taken the second approach. That is the reason I am starting a ZKNamespaceManager in region server. Also, that is the reason I added an API in the region server services, so that I can retrieve ZKNamespaceManager from RegionCoprocessorEnvironment.

          RegionCoprocessorEnvironment regionEnv = (RegionCoprocessorEnvironment) e;
                rsServices = regionEnv.getRegionServerServices();
          

          Why the RS need to be able to list namespaces?

          Correct, I do not need the RS to be able to list namespaces. I added that API in NamespaceDescriptors to make it generic, for any further use. I can remove it if you want.

          I will upload a new patch, once we agree on all your questions.

          Thanks for your time.

          Show
          avandana Vandana Ayyalasomayajula added a comment - The method is used while tables are creates and when a region is split, to check then number of tables and regions in a given namespace. Everytime a new table is created and each time we split, we scan the .META. table? Am I reading this right? That is right. getNamespaceDescRetriever is the wrong name for a method that returns a NamespaceDescriptors I will fix it. My bad, this should have been corrected. I am still unclear why we need auditing facility in the regionserver?I do not understand how you expect auditing to work going by the patch. I see that there is NamespaceAuditor which implements MasterObserver and so intercepts master ops to check counts. I do not see why I need the manager running in a RS? The auditing facility is required only on the regions and master, to check if a given namespace never exceeds a given number of tables and regions ( quota set while creating namespace). The information about the exact number of regions and tables allowed is stored in the namespace descriptor. So for auditing purposes, namespace descriptor is needed. The namespace descriptor can be retrieved from the Zk namespace manager. So, either I get zk instance from region server and start one zk namespace manager for every region or I could create one in region server and share it among all the regions. I have taken the second approach. That is the reason I am starting a ZKNamespaceManager in region server. Also, that is the reason I added an API in the region server services, so that I can retrieve ZKNamespaceManager from RegionCoprocessorEnvironment. RegionCoprocessorEnvironment regionEnv = (RegionCoprocessorEnvironment) e; rsServices = regionEnv.getRegionServerServices(); Why the RS need to be able to list namespaces? Correct, I do not need the RS to be able to list namespaces. I added that API in NamespaceDescriptors to make it generic, for any further use. I can remove it if you want. I will upload a new patch, once we agree on all your questions. Thanks for your time.
          Hide
          stack stack added a comment -

          The method is used while tables are creates and when a region is split, to check then number of tables and regions in a given namespace.

          Everytime a new table is created and each time we split, we scan the .META. table? Am I reading this right?

          I am still unclear why we need auditing facility in the regionserver? I do not understand how you expect auditing to work going by the patch. I see that there is NamespaceAuditor which implements MasterObserver and so intercepts master ops to check counts. I do not see why I need the manager running in a RS? Why the RS need to be able to list namespaces?

          getNamespaceDescRetriever is the wrong name for a method that returns a NamespaceDescriptors

          Thanks

          Show
          stack stack added a comment - The method is used while tables are creates and when a region is split, to check then number of tables and regions in a given namespace. Everytime a new table is created and each time we split, we scan the .META. table? Am I reading this right? I am still unclear why we need auditing facility in the regionserver? I do not understand how you expect auditing to work going by the patch. I see that there is NamespaceAuditor which implements MasterObserver and so intercepts master ops to check counts. I do not see why I need the manager running in a RS? Why the RS need to be able to list namespaces? getNamespaceDescRetriever is the wrong name for a method that returns a NamespaceDescriptors Thanks
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12602500/HBASE-8410_trunk_9.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12602500/HBASE-8410_trunk_9.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7142//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          "How often do we do this: getNamespaceTableAndRegionInfo ?"

          The method is used while tables are creates and when a region is split, to check then number of tables and regions in a given namespace.

          What does it do in the RS? Why is it needed?

          NamespaceAuditor can be run on master, region server and on regions. The master services have an API to get namespace descriptor. But RegionServerServices does not have one. Both the RegionServerCoprocessorEnvironment and RegionCoprocessorEnvironment can retrieve the RegionServerServices. Thats the reason, I added getNamespaceDescRetriever() API to RegionServerServices, so that I can start the ZK namespace manager instance once in a region server and use it for all the regions.

          Show
          avandana Vandana Ayyalasomayajula added a comment - "How often do we do this: getNamespaceTableAndRegionInfo ?" The method is used while tables are creates and when a region is split, to check then number of tables and regions in a given namespace. What does it do in the RS? Why is it needed? NamespaceAuditor can be run on master, region server and on regions. The master services have an API to get namespace descriptor. But RegionServerServices does not have one. Both the RegionServerCoprocessorEnvironment and RegionCoprocessorEnvironment can retrieve the RegionServerServices. Thats the reason, I added getNamespaceDescRetriever() API to RegionServerServices, so that I can start the ZK namespace manager instance once in a region server and use it for all the regions.
          Hide
          stack stack added a comment -

          I am starting the zk namespace manager in the regionserver so that I don't have to start one for each region / regionserver. All the regions can use the same zk namespace manager.

          What does it do in the RS? Why is it needed?

          Also asked "How often do we do this: getNamespaceTableAndRegionInfo ?"

          Thanks.

          Show
          stack stack added a comment - I am starting the zk namespace manager in the regionserver so that I don't have to start one for each region / regionserver. All the regions can use the same zk namespace manager. What does it do in the RS? Why is it needed? Also asked "How often do we do this: getNamespaceTableAndRegionInfo ?" Thanks.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          The TableDescriptors class is also in hbase-server, so I would want to leave the NamespaceDescriptors also in hbase-server. I am starting the zk namespace manager in the regionserver so that I don't have to start one for each region / regionserver. All the regions can use the same zk namespace manager.

          https://issues.apache.org/jira/browse/HBASE-8410?focusedCommentId=13744374&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13744374

          had the problem, which I fixed.

          Show
          avandana Vandana Ayyalasomayajula added a comment - The TableDescriptors class is also in hbase-server, so I would want to leave the NamespaceDescriptors also in hbase-server. I am starting the zk namespace manager in the regionserver so that I don't have to start one for each region / regionserver. All the regions can use the same zk namespace manager. https://issues.apache.org/jira/browse/HBASE-8410?focusedCommentId=13744374&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13744374 had the problem, which I fixed.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12602457/HBASE-8410_trunk_8.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12602457/HBASE-8410_trunk_8.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7134//console This message is automatically generated.
          Hide
          stack stack added a comment -

          Sorry, a list returning a Set is odd because I was expecting a List, not a Map. This patch goes the wrong direction making list return a Map. Pardon me. I should have been more clear. Do you want to move this Interface.

          This method name is not right given what it is returning getNamespaceDescRetriever

          What about my other questions above? Thanks Vandana Ayyalasomayajula

          Show
          stack stack added a comment - Sorry, a list returning a Set is odd because I was expecting a List, not a Map. This patch goes the wrong direction making list return a Map. Pardon me. I should have been more clear. Do you want to move this Interface. This method name is not right given what it is returning getNamespaceDescRetriever What about my other questions above? Thanks Vandana Ayyalasomayajula
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Addressed Stack's comments.

          1. Renamed NamespaceDescriptorRetriever to NamespaceDescriptors.

          2. Changed the return type of list to Map<String, NamespaceDescriptor>

          3. Renamed NamespaceController to NamespaceAuditor

          4. Made NamespaceTableAndRegionInfo to be package private. Only the NamespaceAuditor class is using for now.

          5. The ZK namespace manager initializes the cache and registers listener. No stop is required.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Addressed Stack's comments. 1. Renamed NamespaceDescriptorRetriever to NamespaceDescriptors. 2. Changed the return type of list to Map<String, NamespaceDescriptor> 3. Renamed NamespaceController to NamespaceAuditor 4. Made NamespaceTableAndRegionInfo to be package private. Only the NamespaceAuditor class is using for now. 5. The ZK namespace manager initializes the cache and registers listener. No stop is required.
          Hide
          stack stack added a comment -

          I took a look.

          The Interface is named NamespaceDescriptorRetriever. A related, more general Interface for dealing with TableDescriptors is called TableDescriptors. For consistency should this Interface not be called NamespaceDescriptors?

          Does it belong in hbase-common rather than in hbase-server?

          The method list returns a Set which is a little disorientating. In TableDescriptors, the equivalent method is named getAll.

          NamespaceController seems a too general name for a class that does resource checking. NamespaceResourceChecker or NamespaceAuditor?

          Why is this not package private? +public class NamespaceTableAndRegionInfo { Is not used in this package only?

          How often do we do this: getNamespaceTableAndRegionInfo ?

          We start this in the RS. Do we have to stop it when done?

          + this.zkNamespaceManager.start();

          Do we have to add this to RegionServerServices? getNamespaceDescRetriever ?

          Does the ZKNamespaceManager in RS do anything? Does it have to be on the RS? Can't master do necessary checks?

          Thanks.

          Show
          stack stack added a comment - I took a look. The Interface is named NamespaceDescriptorRetriever. A related, more general Interface for dealing with TableDescriptors is called TableDescriptors. For consistency should this Interface not be called NamespaceDescriptors? Does it belong in hbase-common rather than in hbase-server? The method list returns a Set which is a little disorientating. In TableDescriptors, the equivalent method is named getAll. NamespaceController seems a too general name for a class that does resource checking. NamespaceResourceChecker or NamespaceAuditor? Why is this not package private? +public class NamespaceTableAndRegionInfo { Is not used in this package only? How often do we do this: getNamespaceTableAndRegionInfo ? We start this in the RS. Do we have to stop it when done? + this.zkNamespaceManager.start(); Do we have to add this to RegionServerServices? getNamespaceDescRetriever ? Does the ZKNamespaceManager in RS do anything? Does it have to be on the RS? Can't master do necessary checks? Thanks.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Ted Yu Do we need one more +1 to commit ?

          Show
          avandana Vandana Ayyalasomayajula added a comment - Ted Yu Do we need one more +1 to commit ?
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          +1

          Show
          yuzhihong@gmail.com Ted Yu added a comment - +1
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12602196/HBASE-8410_trunk_7.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12602196/HBASE-8410_trunk_7.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7100//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          HBASE-8410_trunk_7.patch has the javadoc warning addressed.

          Show
          avandana Vandana Ayyalasomayajula added a comment - HBASE-8410 _trunk_7.patch has the javadoc warning addressed.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          +1, provided that the following javadoc warning is fixed:

          [WARNING] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/NamespaceDescriptorRetriever.java:38: warning - @param argument "The" is not a parameter name.
          
          Show
          yuzhihong@gmail.com Ted Yu added a comment - +1, provided that the following javadoc warning is fixed: [WARNING] /Users/tyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/NamespaceDescriptorRetriever.java:38: warning - @param argument "The" is not a parameter name.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12601231/HBASE-8410_trunk_6.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12601231/HBASE-8410_trunk_6.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7015//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Ted Yu There were two warnings which I fixed in the latest patch.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Ted Yu There were two warnings which I fixed in the latest patch.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Fixed findbugs warnings.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Fixed findbugs warnings.
          Show
          yuzhihong@gmail.com Ted Yu added a comment - If you compare https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html#Warnings_MALICIOUS_CODE with https://builds.apache.org/job/PreCommit-HBASE-Build/7008//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html#Warnings_MALICIOUS_CODE , you can easily see which two new warnings were introduced.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Ted Yu The warnings seems to be in files unrelated to the patch.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Ted Yu The warnings seems to be in files unrelated to the patch.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Please fix javadoc and findbugs warnings.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Please fix javadoc and findbugs warnings.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12601187/HBASE-8410_trunk_5.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12601187/HBASE-8410_trunk_5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7009//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Rebased the patch.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Rebased the patch.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Good.

          Somehow the patch went stale. Once you rebase, I would give +1

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Good. Somehow the patch went stale. Once you rebase, I would give +1
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Ted Yu I ran the tests when I attached the patch. The tests ran fine.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Ted Yu I ran the tests when I attached the patch. The tests ran fine.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          The latest patch looks cleaner.

          Does it pass test suite ?

          Show
          yuzhihong@gmail.com Ted Yu added a comment - The latest patch looks cleaner. Does it pass test suite ?
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Ted YuCan you take a look at the latest patch when you have time ? Thanks!.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Ted Yu Can you take a look at the latest patch when you have time ? Thanks!.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12600636/HBASE-8410_trunk_4.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6966//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12600636/HBASE-8410_trunk_4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6966//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Attached the patch again!.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Attached the patch again!.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Do you mind attaching patch again ?

          The previous QA run didn't go through.

          Thanks

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Do you mind attaching patch again ? The previous QA run didn't go through. Thanks
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Ted Yu Can you take a look at the latest patch when you have time ? Thanks!.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Ted Yu Can you take a look at the latest patch when you have time ? Thanks!.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          addressed comments and rebased the patch.

          Show
          avandana Vandana Ayyalasomayajula added a comment - addressed comments and rebased the patch.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          NamespaceController looks cleaner in patch v3.
          Can you update the patch with latest trunk ?

          +        throw new DoNotRetryIOException("The region "
          +            + Bytes.toString(regionEnv.getRegion().getRegionName())
          

          You can use regionEnv.getRegion().getRegionNameAsString() so that Bytes.toString() is not needed.

          For NamespaceDescriptorRetriever, please add annotation for audience.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - NamespaceController looks cleaner in patch v3. Can you update the patch with latest trunk ? + throw new DoNotRetryIOException( "The region " + + Bytes.toString(regionEnv.getRegion().getRegionName()) You can use regionEnv.getRegion().getRegionNameAsString() so that Bytes.toString() is not needed. For NamespaceDescriptorRetriever, please add annotation for audience.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Ted Yu Can you take a look at the latest patch when you have time ? Thanks!.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Ted Yu Can you take a look at the latest patch when you have time ? Thanks!.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12599768/HBASE-8410_trunk_3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6910//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12599768/HBASE-8410_trunk_3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6910//console This message is automatically generated.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Addressed Ted's comments.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Addressed Ted's comments.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -
          +      return zkNamespaceManager;
          +    } else {
          +      throw new IOException("ZKNamespaceManager found to be null.");
          

          nit: 'else' keyword is not needed.

          In NamespaceController:

          +    } else if (e instanceof RegionServerCoprocessorEnvironment) {
          +      RegionServerCoprocessorEnvironment rsEnv = (RegionServerCoprocessorEnvironment) e;
          +      zk = rsEnv.getRegionServerServices().getZooKeeper();
          +      zkManager = new ZKNamespaceManager(zk);
          +      zkManager.start();
          +    } else if (e instanceof RegionCoprocessorEnvironment) {
          +      // if running at region
          +      RegionCoprocessorEnvironment regionEnv = (RegionCoprocessorEnvironment) e;
          +      zk = regionEnv.getRegionServerServices().getZooKeeper();
          +      zkManager = new ZKNamespaceManager(zk);
          

          If I read the above correctly, there would be n+1 ZKNamespaceManager's running in region server where n is the number of online regions for that server ?

          Show
          yuzhihong@gmail.com Ted Yu added a comment - + return zkNamespaceManager; + } else { + throw new IOException( "ZKNamespaceManager found to be null ." ); nit: 'else' keyword is not needed. In NamespaceController: + } else if (e instanceof RegionServerCoprocessorEnvironment) { + RegionServerCoprocessorEnvironment rsEnv = (RegionServerCoprocessorEnvironment) e; + zk = rsEnv.getRegionServerServices().getZooKeeper(); + zkManager = new ZKNamespaceManager(zk); + zkManager.start(); + } else if (e instanceof RegionCoprocessorEnvironment) { + // if running at region + RegionCoprocessorEnvironment regionEnv = (RegionCoprocessorEnvironment) e; + zk = regionEnv.getRegionServerServices().getZooKeeper(); + zkManager = new ZKNamespaceManager(zk); If I read the above correctly, there would be n+1 ZKNamespaceManager's running in region server where n is the number of online regions for that server ?
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Ted Yu Can you take a look at the latest patch when you have time ? Thanks!.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Ted Yu Can you take a look at the latest patch when you have time ? Thanks!.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          1. Rebased the old patch with the new changed in trunk.

          2. Added an API in the master services to get an instance of ZKNamespace Manager.

          Show
          avandana Vandana Ayyalasomayajula added a comment - 1. Rebased the old patch with the new changed in trunk. 2. Added an API in the master services to get an instance of ZKNamespace Manager.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          1. Regarding the region size config parameter, the upper bound on the total space can be set using HDFS quota on the namespace folder. So it will kind of redundant to have space related restrictions again in the namespace controller.

          2. Regarding double ZKNamespaceManager instances in the same JVM, I talked to francis to provide an API to retrive the ZKNamespaceManager and he agreed to it. So I will rebase the patch when he makes the changes in the parent JIRA.

          Show
          avandana Vandana Ayyalasomayajula added a comment - 1. Regarding the region size config parameter, the upper bound on the total space can be set using HDFS quota on the namespace folder. So it will kind of redundant to have space related restrictions again in the namespace controller. 2. Regarding double ZKNamespaceManager instances in the same JVM, I talked to francis to provide an API to retrive the ZKNamespaceManager and he agreed to it. So I will rebase the patch when he makes the changes in the parent JIRA.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          In combination with max region count, can we consider region size config parameter so that there is upper bound on the total space ?

          w.r.t. double ZKNamespaceManager instances in the same JVM, can one of them be dropped - e.g. can NamespaceController retrieve the other ZKNamespaceManager instance ?

          Show
          yuzhihong@gmail.com Ted Yu added a comment - In combination with max region count, can we consider region size config parameter so that there is upper bound on the total space ? w.r.t. double ZKNamespaceManager instances in the same JVM, can one of them be dropped - e.g. can NamespaceController retrieve the other ZKNamespaceManager instance ?
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Ted Yu I am using the same zk from master services to create a ZKNamespaceManager. So yes, there will be more than one ZKNamespaceManager running in the same JVM.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Ted Yu I am using the same zk from master services to create a ZKNamespaceManager. So yes, there will be more than one ZKNamespaceManager running in the same JVM.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Addressed Ted's comments.

          Show
          avandana Vandana Ayyalasomayajula added a comment - Addressed Ted's comments.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          NamespaceTableAndRegionInfo is fine.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - NamespaceTableAndRegionInfo is fine.
          Hide
          avandana Vandana Ayyalasomayajula added a comment -

          Ted Yu Does the name NamespaceTableAndRegionInfo sound good replacement for NamespaceQuota classname ?

          Show
          avandana Vandana Ayyalasomayajula added a comment - Ted Yu Does the name NamespaceTableAndRegionInfo sound good replacement for NamespaceQuota classname ?
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          For NamespaceController, please add class javadoc and audience annotation.

          +    zkManager = new ZKNamespaceManager(zk);
          +    zkManager.start();
          

          I saw the following in TableNamespaceManager:

          +    zkNamespaceManager = new ZKNamespaceManager(masterServices.getZooKeeper());
          +    zkNamespaceManager.start();
          

          So we may have more than one ZKNamespaceManager running in the same JVM ?

          The spacing is slightly off: two spaces should be used per indentation.

          +        maxRegions = Long.parseLong(value);
          +      } catch (NumberFormatException exp) {
          +        throw new ConstraintException("NumberFormatException while getting max regions.", exp);
          

          Please include value in exception message.

          +        currentStatus = getNamespaceQuota(ctx.getEnvironment().getConfiguration(),
          +          nspdesc.getName());
          

          I think there should be a better name for getNamespaceQuota because quota should be the setting governing the namespace which is different from the current status for the underlying namespace.

          I wonder if using table and region count is a good way for enforcing quota because the underlying region size can vary.

          +            + " is not allowed to have " + regions.length
          +            + " number of regions. The total number of regions permitted are only "
          

          Remove 'number of '. 'permitted are only' -> 'permitted is only'.

          For class NamespaceQuota, please add javadoc and audience annotation. I think the class should be renamed because it reflects the status of a namespace, not its quota.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - For NamespaceController, please add class javadoc and audience annotation. + zkManager = new ZKNamespaceManager(zk); + zkManager.start(); I saw the following in TableNamespaceManager: + zkNamespaceManager = new ZKNamespaceManager(masterServices.getZooKeeper()); + zkNamespaceManager.start(); So we may have more than one ZKNamespaceManager running in the same JVM ? The spacing is slightly off: two spaces should be used per indentation. + maxRegions = Long .parseLong(value); + } catch (NumberFormatException exp) { + throw new ConstraintException( "NumberFormatException while getting max regions." , exp); Please include value in exception message. + currentStatus = getNamespaceQuota(ctx.getEnvironment().getConfiguration(), + nspdesc.getName()); I think there should be a better name for getNamespaceQuota because quota should be the setting governing the namespace which is different from the current status for the underlying namespace. I wonder if using table and region count is a good way for enforcing quota because the underlying region size can vary. + + " is not allowed to have " + regions.length + + " number of regions. The total number of regions permitted are only " Remove 'number of '. 'permitted are only' -> 'permitted is only'. For class NamespaceQuota, please add javadoc and audience annotation. I think the class should be renamed because it reflects the status of a namespace, not its quota.

            People

            • Assignee:
              avandana Vandana Ayyalasomayajula
              Reporter:
              toffer Francis Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              20 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development