Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-7935

make policy and compactor in default store engine separately pluggable (for things like tier-based, and default policy experiments with permutations)

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • None
    • Compaction
    • None

    Description

      Technically, StoreEngine can be used to achieve any permutations of things, but to make it more convenient to replace compaction policy/compator in standard schemes like tier-based, we can add separate hooks in DefaultStoreEngine (as long as custom ones conform to its default expectations e.g. flat list of sorted files, etc.)

      Attachments

        1. HBASE-7935-v0.patch
          14 kB
          Sergey Shelukhin
        2. HBASE-7935-v0-with-7843.patch
          97 kB
          Sergey Shelukhin
        3. HBASE-7935-v1.patch
          13 kB
          Sergey Shelukhin
        4. HBASE-7935-v2.patch
          27 kB
          Sergey Shelukhin
        5. HBASE-7935-v3.patch
          26 kB
          Sergey Shelukhin
        6. HBASE-7935-v3.patch
          27 kB
          Sergey Shelukhin
        7. HBASE-7935-addendum.patch
          2 kB
          Sergey Shelukhin

        Issue Links

          Activity

            Again two patches, one standalone (relatively small), and one including the blocking issue.

            sershe Sergey Shelukhin added a comment - Again two patches, one standalone (relatively small), and one including the blocking issue.
            hadoopqa Hadoop QA added a comment -

            +1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12570892/HBASE-7935-v0-with-7843.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 15 new or modified tests.

            +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 lineLengths. The patch does not introduce lines longer than 100

            +1 core tests. The patch passed unit tests in .

            Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//testReport/
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
            Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12570892/HBASE-7935-v0-with-7843.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 15 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4542//console This message is automatically generated.

            Rebase the patch, now all the prerequsites are ready.

            sershe Sergey Shelukhin added a comment - Rebase the patch, now all the prerequsites are ready.
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12571320/HBASE-7935-v1.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 8 new or modified tests.

            +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 lineLengths. The patch does not introduce lines longer than 100

            -1 core tests. The patch failed these unit tests:
            org.apache.hadoop.hbase.regionserver.wal.TestHLog

            Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//testReport/
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
            Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12571320/HBASE-7935-v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestHLog Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4590//console This message is automatically generated.

            TestHLog passes locally; posted /r/ at: https://reviews.apache.org/r/9681/

            sershe Sergey Shelukhin added a comment - TestHLog passes locally; posted /r/ at: https://reviews.apache.org/r/9681/

            ping? thanks

            sershe Sergey Shelukhin added a comment - ping? thanks
            yuzhihong@gmail.com Ted Yu added a comment -

            Patch is out of date after recent checkin.

            Mind rebasing ?

            yuzhihong@gmail.com Ted Yu added a comment - Patch is out of date after recent checkin. Mind rebasing ?

            I saw there's some feedback on /r/. I will address it after I get back and resubmit the patch.

            sershe Sergey Shelukhin added a comment - I saw there's some feedback on /r/. I will address it after I get back and resubmit the patch.

            Rebase, remove assignments and subsequent simplification. We can call createComponents in create without depending on class user...

            sershe Sergey Shelukhin added a comment - Rebase, remove assignments and subsequent simplification. We can call createComponents in create without depending on class user...
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12571998/HBASE-7935-v2.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 12 new or modified tests.

            +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 lineLengths. The patch does not introduce lines longer than 100

            -1 core tests. The patch failed these unit tests:
            org.apache.hadoop.hbase.master.TestMasterFailover
            org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster

            Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//testReport/
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
            Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12571998/HBASE-7935-v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 12 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.master.TestMasterFailover org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4659//console This message is automatically generated.
            ddas Devaraj Das added a comment -

            Some comments:
            1. Do you want to remove the unused field compactionpolicy from HStore.java
            2. Do you want to retain the existing signature for createComponents and instead have the method throw RuntimeException (which doesn't need to be declared).
            3. Javadoc in StoreEngine needs to be updated to reflect the signature (e.g. getCompactionPolicy)
            4. I am confused by the "isInitialized" field in the StoreEngine.java that you removed in the patch. Why was that required earlier and not required now?

            ddas Devaraj Das added a comment - Some comments: 1. Do you want to remove the unused field compactionpolicy from HStore.java 2. Do you want to retain the existing signature for createComponents and instead have the method throw RuntimeException (which doesn't need to be declared). 3. Javadoc in StoreEngine needs to be updated to reflect the signature (e.g. getCompactionPolicy) 4. I am confused by the "isInitialized" field in the StoreEngine.java that you removed in the patch. Why was that required earlier and not required now?

            2. Do you want to retain the existing signature for createComponents and instead have the method throw RuntimeException (which doesn't need to be declared).

            Probably not, the only reason it was called like that to not call abstract method in ctor. Given that store engine is always created via create it should be ok to have a method to initialize.

            4. I am confused by the "isInitialized" field in the StoreEngine.java that you removed in the patch. Why was that required earlier and not required now?

            Previously the init was called on first use, so it was needed to tell the first use apart; now it's called in a well defined place at create time.

            sershe Sergey Shelukhin added a comment - 2. Do you want to retain the existing signature for createComponents and instead have the method throw RuntimeException (which doesn't need to be declared). Probably not, the only reason it was called like that to not call abstract method in ctor. Given that store engine is always created via create it should be ok to have a method to initialize. 4. I am confused by the "isInitialized" field in the StoreEngine.java that you removed in the patch. Why was that required earlier and not required now? Previously the init was called on first use, so it was needed to tell the first use apart; now it's called in a well defined place at create time.

            rebase & update

            sershe Sergey Shelukhin added a comment - rebase & update
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12572206/HBASE-7935-v3.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 12 new or modified tests.

            +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 lineLengths. The patch does not introduce lines longer than 100

            -1 core tests. The patch failed these unit tests:
            org.apache.hadoop.hbase.io.TestHeapSize

            Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//testReport/
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
            Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12572206/HBASE-7935-v3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 12 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.io.TestHeapSize Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4682//console This message is automatically generated.

            forgot to change FIXED_OVERHEAD

            sershe Sergey Shelukhin added a comment - forgot to change FIXED_OVERHEAD
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12572225/HBASE-7935-v3.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 12 new or modified tests.

            +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 lineLengths. The patch does not introduce lines longer than 100

            -1 core tests. The patch failed these unit tests:
            org.apache.hadoop.hbase.replication.TestReplicationQueueFailoverCompressed
            org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster

            -1 core zombie tests. There are 1 zombie test(s):

            Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//testReport/
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
            Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12572225/HBASE-7935-v3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 12 new or modified tests. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplicationQueueFailoverCompressed org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster -1 core zombie tests . There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4687//console This message is automatically generated.
            ddas Devaraj Das added a comment -

            +1

            ddas Devaraj Das added a comment - +1

            Matteo also +1-d in /r, so I will commit in the afternoon if there are no objections.

            sershe Sergey Shelukhin added a comment - Matteo also +1-d in /r, so I will commit in the afternoon if there are no objections.

            Noticed the comment on r w/ship it Here's the addendum. Only comment changes. I will commit together.

            sershe Sergey Shelukhin added a comment - Noticed the comment on r w/ship it Here's the addendum. Only comment changes. I will commit together.
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12572392/HBASE-7935-addendum.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            -1 patch. The patch command could not apply the patch.

            Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4698//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12572392/HBASE-7935-addendum.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4698//console This message is automatically generated.
            hudson Hudson added a comment -

            Integrated in hbase-0.95 #32 (See https://builds.apache.org/job/hbase-0.95/32/)
            HBASE-7935 make policy and compactor in default store engine separately pluggable (for things like tier-based, and default policy experiments with permutations) (Revision 1453588)

            Result = FAILURE
            sershe :
            Files :

            • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
            • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
            • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreEngine.java
            • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java
            • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
            • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java
            • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultStoreEngine.java
            • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
            hudson Hudson added a comment - Integrated in hbase-0.95 #32 (See https://builds.apache.org/job/hbase-0.95/32/ ) HBASE-7935 make policy and compactor in default store engine separately pluggable (for things like tier-based, and default policy experiments with permutations) (Revision 1453588) Result = FAILURE sershe : Files : /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreEngine.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultStoreEngine.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
            hudson Hudson added a comment -

            Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #433 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/433/)
            HBASE-7935 make policy and compactor in default store engine separately pluggable (for things like tier-based, and default policy experiments with permutations) (Revision 1453586)

            Result = FAILURE
            sershe :
            Files :

            • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
            • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
            • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreEngine.java
            • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java
            • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
            • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java
            • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultStoreEngine.java
            • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
            hudson Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #433 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/433/ ) HBASE-7935 make policy and compactor in default store engine separately pluggable (for things like tier-based, and default policy experiments with permutations) (Revision 1453586) Result = FAILURE sershe : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreEngine.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultStoreEngine.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
            hudson Hudson added a comment -

            Integrated in hbase-0.95-on-hadoop2 #14 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/14/)
            HBASE-7935 make policy and compactor in default store engine separately pluggable (for things like tier-based, and default policy experiments with permutations) (Revision 1453588)

            Result = FAILURE
            sershe :
            Files :

            • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
            • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
            • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreEngine.java
            • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java
            • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
            • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java
            • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultStoreEngine.java
            • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
            hudson Hudson added a comment - Integrated in hbase-0.95-on-hadoop2 #14 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/14/ ) HBASE-7935 make policy and compactor in default store engine separately pluggable (for things like tier-based, and default policy experiments with permutations) (Revision 1453588) Result = FAILURE sershe : Files : /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreEngine.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultStoreEngine.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
            hudson Hudson added a comment -

            Integrated in HBase-TRUNK #3921 (See https://builds.apache.org/job/HBase-TRUNK/3921/)
            HBASE-7935 make policy and compactor in default store engine separately pluggable (for things like tier-based, and default policy experiments with permutations) (Revision 1453586)

            Result = FAILURE
            sershe :
            Files :

            • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java
            • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
            • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreEngine.java
            • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java
            • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
            • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java
            • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultStoreEngine.java
            • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
            hudson Hudson added a comment - Integrated in HBase-TRUNK #3921 (See https://builds.apache.org/job/HBase-TRUNK/3921/ ) HBASE-7935 make policy and compactor in default store engine separately pluggable (for things like tier-based, and default policy experiments with permutations) (Revision 1453586) Result = FAILURE sershe : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreEngine.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreEngine.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionContext.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultStoreEngine.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java

            in

            sershe Sergey Shelukhin added a comment - in

            People

              sershe Sergey Shelukhin
              sershe Sergey Shelukhin
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: