HBase
  1. HBase
  2. HBASE-7693

Hostname returned by TableInputFormatBase.reverseDNS contains trailing period

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.94.3
    • Fix Version/s: 0.94.5, 0.95.0
    • Component/s: mapreduce
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TableInputFormatBase.reverseDNS makes a call to org.apache.hadoop.net.DNS.reverseDns which (at least in Hadoop 1.0.4) returns a PTR record. PTR records contain a trailing period, which then shows up in the input split location causing the JobTracker to incorrectly match map jobs to data-local map slots.

        Issue Links

          Activity

          Robert Dyer created issue -
          Robert Dyer made changes -
          Field Original Value New Value
          Link This issue relates to HBASE-4109 [ HBASE-4109 ]
          Robert Dyer made changes -
          Attachment HBASE-7693.patch [ 12566747 ]
          Ted Yu made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Marc Reichman added a comment -

          This is a dupe of HBASE-7618, but maybe HBASE-7618 can be closed since this contains a patch.

          Show
          Marc Reichman added a comment - This is a dupe of HBASE-7618 , but maybe HBASE-7618 can be closed since this contains a patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12566747/HBASE-7693.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.TestZooKeeper
          org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4211//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4211//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4211//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4211//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4211//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4211//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4211//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4211//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12566747/HBASE-7693.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.TestZooKeeper org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4211//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4211//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4211//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4211//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4211//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4211//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4211//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4211//console This message is automatically generated.
          Hide
          Lars Hofhansl added a comment -

          Patch looks good. Test failures are unrelated.

          Show
          Lars Hofhansl added a comment - Patch looks good. Test failures are unrelated.
          Hide
          Ted Yu added a comment -

          I ran the above two tests with patch and they passed.

          Integrated to trunk.

          Thanks for the patch, Robert.

          Thanks for the review, Robert.

          Show
          Ted Yu added a comment - I ran the above two tests with patch and they passed. Integrated to trunk. Thanks for the patch, Robert. Thanks for the review, Robert.
          Hide
          Marc Reichman added a comment -

          Can this please be integrated into 0.94.x?

          Show
          Marc Reichman added a comment - Can this please be integrated into 0.94.x?
          Ted Yu made changes -
          Assignee Robert Dyer [ psybers ]
          Ted Yu made changes -
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 0.96.0 [ 12320040 ]
          Hide
          Lars Hofhansl added a comment - - edited

          Yes, that is crucial for 0.94... I'll commit this now. Thanks again for the finding and patch.

          Show
          Lars Hofhansl added a comment - - edited Yes, that is crucial for 0.94... I'll commit this now. Thanks again for the finding and patch.
          Lars Hofhansl made changes -
          Fix Version/s 0.94.5 [ 12323874 ]
          Hide
          Lars Hofhansl added a comment -

          Done.

          Show
          Lars Hofhansl added a comment - Done.
          Lars Hofhansl made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #3815 (See https://builds.apache.org/job/HBase-TRUNK/3815/)
          HBASE-7693 Hostname returned by TableInputFormatBase.reverseDNS contains trailing period (Robert Dyer) (Revision 1439556)

          Result = FAILURE
          tedyu :
          Files :

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #3815 (See https://builds.apache.org/job/HBase-TRUNK/3815/ ) HBASE-7693 Hostname returned by TableInputFormatBase.reverseDNS contains trailing period (Robert Dyer) (Revision 1439556) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94 #796 (See https://builds.apache.org/job/HBase-0.94/796/)
          HBASE-7693 Hostname returned by TableInputFormatBase.reverseDNS contains trailing period (Robert Dyer) (Revision 1439558)

          Result = FAILURE
          larsh :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
          Show
          Hudson added a comment - Integrated in HBase-0.94 #796 (See https://builds.apache.org/job/HBase-0.94/796/ ) HBASE-7693 Hostname returned by TableInputFormatBase.reverseDNS contains trailing period (Robert Dyer) (Revision 1439558) Result = FAILURE larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #381 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/381/)
          HBASE-7693 Hostname returned by TableInputFormatBase.reverseDNS contains trailing period (Robert Dyer) (Revision 1439556)

          Result = FAILURE
          tedyu :
          Files :

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #381 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/381/ ) HBASE-7693 Hostname returned by TableInputFormatBase.reverseDNS contains trailing period (Robert Dyer) (Revision 1439556) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security #102 (See https://builds.apache.org/job/HBase-0.94-security/102/)
          HBASE-7693 Hostname returned by TableInputFormatBase.reverseDNS contains trailing period (Robert Dyer) (Revision 1439558)

          Result = SUCCESS
          larsh :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security #102 (See https://builds.apache.org/job/HBase-0.94-security/102/ ) HBASE-7693 Hostname returned by TableInputFormatBase.reverseDNS contains trailing period (Robert Dyer) (Revision 1439558) Result = SUCCESS larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security-on-Hadoop-23 #11 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/11/)
          HBASE-7693 Hostname returned by TableInputFormatBase.reverseDNS contains trailing period (Robert Dyer) (Revision 1439558)

          Result = FAILURE
          larsh :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #11 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/11/ ) HBASE-7693 Hostname returned by TableInputFormatBase.reverseDNS contains trailing period (Robert Dyer) (Revision 1439558) Result = FAILURE larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
          Lars Hofhansl made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          stack made changes -
          Fix Version/s 0.95.0 [ 12324094 ]
          Fix Version/s 0.96.0 [ 12320040 ]
          Fix Version/s 0.94.5 [ 12323874 ]
          Lars Hofhansl made changes -
          Fix Version/s 0.94.5 [ 12323874 ]
          Eli Collins made changes -
          Link This issue is related to HADOOP-9369 [ HADOOP-9369 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          4h 47m 1 Ted Yu 28/Jan/13 14:11
          Patch Available Patch Available Resolved Resolved
          4h 32m 1 Lars Hofhansl 28/Jan/13 18:43
          Resolved Resolved Closed Closed
          18d 9h 30m 1 Lars Hofhansl 16/Feb/13 04:14

            People

            • Assignee:
              Robert Dyer
              Reporter:
              Robert Dyer
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development