HBase
  1. HBase
  2. HBASE-4109

Hostname returned via reverse dns lookup contains trailing period if configured interface is not "default"

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.90.3
    • Fix Version/s: 0.90.4
    • Component/s: master, regionserver
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
      have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
      It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html

      We make call to DNS.getDefaultHost at more than one places and treat that as actual hostname.

      Quoting HRegionServer for example

      String machineName = DNS.getDefaultHost(conf.get(
              "hbase.regionserver.dns.interface", "default"), conf.get(
              "hbase.regionserver.dns.nameserver", "default"));
      

      This causes inconsistencies. An example of such inconsistency was observed while debugging the issue "Regions not getting reassigned if RS is brought down". More here
      http://search-hadoop.com/m/CANUA1qRCkQ1

      We may want to sanitize the string returned from DNS class. Or better we can take a path of overhauling the way we do DNS name matching all over.

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in HBase-0.92-security #105 (See https://builds.apache.org/job/HBase-0.92-security/105/)
          HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311827)
          HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311825)

          Result = FAILURE
          stack :
          Files :

          • /hbase/branches/0.92/CHANGES.txt

          stack :
          Files :

          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/Strings.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
          Show
          Hudson added a comment - Integrated in HBase-0.92-security #105 (See https://builds.apache.org/job/HBase-0.92-security/105/ ) HBASE-5758 Forward port " HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311827) HBASE-5758 Forward port " HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311825) Result = FAILURE stack : Files : /hbase/branches/0.92/CHANGES.txt stack : Files : /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/Strings.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security #9 (See https://builds.apache.org/job/HBase-0.94-security/9/)
          HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311822)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/Strings.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security #9 (See https://builds.apache.org/job/HBase-0.94-security/9/ ) HBASE-5758 Forward port " HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311822) Result = SUCCESS stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/Strings.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-security #167 (See https://builds.apache.org/job/HBase-TRUNK-security/167/)
          HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311821)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/Strings.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-security #167 (See https://builds.apache.org/job/HBase-TRUNK-security/167/ ) HBASE-5758 Forward port " HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311821) Result = SUCCESS stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/Strings.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.92 #366 (See https://builds.apache.org/job/HBase-0.92/366/)
          HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311827)
          HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311825)

          Result = FAILURE
          stack :
          Files :

          • /hbase/branches/0.92/CHANGES.txt

          stack :
          Files :

          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/Strings.java
          • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
          Show
          Hudson added a comment - Integrated in HBase-0.92 #366 (See https://builds.apache.org/job/HBase-0.92/366/ ) HBASE-5758 Forward port " HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311827) HBASE-5758 Forward port " HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311825) Result = FAILURE stack : Files : /hbase/branches/0.92/CHANGES.txt stack : Files : /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/Strings.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2737 (See https://builds.apache.org/job/HBase-TRUNK/2737/)
          HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311821)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/Strings.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2737 (See https://builds.apache.org/job/HBase-TRUNK/2737/ ) HBASE-5758 Forward port " HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311821) Result = SUCCESS stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/Strings.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94 #101 (See https://builds.apache.org/job/HBase-0.94/101/)
          HBASE-5758 Forward port "HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311822)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/Strings.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
          Show
          Hudson added a comment - Integrated in HBase-0.94 #101 (See https://builds.apache.org/job/HBase-0.94/101/ ) HBASE-5758 Forward port " HBASE-4109 Hostname returned via reverse dns lookup contains trailing period if configured interface is not default (Revision 1311822) Result = SUCCESS stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/Strings.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java
          Hide
          stack added a comment -

          @Adrian Forward port is over in hbase-5758. I will commit later today.

          Show
          stack added a comment - @Adrian Forward port is over in hbase-5758. I will commit later today.
          Hide
          Adrian Muraru added a comment -

          Hi,
          Just noticed that the same issue pops up in 0.92 now.
          Can we have this patch applied in 0.92 trunk as well?

          Show
          Adrian Muraru added a comment - Hi, Just noticed that the same issue pops up in 0.92 now. Can we have this patch applied in 0.92 trunk as well?
          Hide
          Harsh J added a comment -

          Hi,

          This affects multihomed DataNodes as well. I've filed HADOOP-8134 upstream.

          Show
          Harsh J added a comment - Hi, This affects multihomed DataNodes as well. I've filed HADOOP-8134 upstream.
          Hide
          stack added a comment -

          Sorry. I meant to say that I like Eugene's suggestion but agree that this single method is not really enough to start up a new class – especially given the kind of String manipulation being done; I think its good for now.

          Show
          stack added a comment - Sorry. I meant to say that I like Eugene's suggestion but agree that this single method is not really enough to start up a new class – especially given the kind of String manipulation being done; I think its good for now.
          Hide
          stack added a comment -

          Committed to branch (Should be no need for this kind of fixup on trunk). Thanks for the patch Shrijeet.

          Show
          stack added a comment - Committed to branch (Should be no need for this kind of fixup on trunk). Thanks for the patch Shrijeet.
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-07-20 23:59:24, Eugene Koontz wrote:

          > Should : String domainNamePointerToHostName(String dnPtr) be in o.a.h.h.util.Strings? Perhaps it would be better in o.a.h.h.util.Addressing?

          Eugene, yeah I had second thoughts about it myself. One, I was hesitating introducing a new class (I was thinking of introducing NetUtils) because all we are doing is string manipulation instead of any networking magic. Second, I saw org.apache.hadoop.util having functions like simpleHostname in it.

          • Shrijeet

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1139/#review1146
          -----------------------------------------------------------

          On 2011-07-18 18:41:16, Shrijeet Paliwal wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1139/

          -----------------------------------------------------------

          (Updated 2011-07-18 18:41:16)

          Review request for hbase and Michael Stack.

          Summary

          -------

          If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will

          have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.

          It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html

          This patch adds a sanitizing function and wraps all calls to getDefaultHost to go through a step of removing trailing period.

          This addresses bug HBASE-4109.

          https://issues.apache.org/jira/browse/HBASE-4109

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/util/Strings.java c2cad2e

          src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java d551c6f

          src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 2d033f3

          src/main/java/org/apache/hadoop/hbase/master/HMaster.java c91523a

          Diff: https://reviews.apache.org/r/1139/diff

          Testing

          -------

          Thanks,

          Shrijeet

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-07-20 23:59:24, Eugene Koontz wrote: > Should : String domainNamePointerToHostName(String dnPtr) be in o.a.h.h.util.Strings? Perhaps it would be better in o.a.h.h.util.Addressing? Eugene, yeah I had second thoughts about it myself. One, I was hesitating introducing a new class (I was thinking of introducing NetUtils) because all we are doing is string manipulation instead of any networking magic. Second, I saw org.apache.hadoop.util having functions like simpleHostname in it. Shrijeet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1139/#review1146 ----------------------------------------------------------- On 2011-07-18 18:41:16, Shrijeet Paliwal wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1139/ ----------------------------------------------------------- (Updated 2011-07-18 18:41:16) Review request for hbase and Michael Stack. Summary ------- If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing. It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html This patch adds a sanitizing function and wraps all calls to getDefaultHost to go through a step of removing trailing period. This addresses bug HBASE-4109 . https://issues.apache.org/jira/browse/HBASE-4109 Diffs ----- src/main/java/org/apache/hadoop/hbase/util/Strings.java c2cad2e src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java d551c6f src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 2d033f3 src/main/java/org/apache/hadoop/hbase/master/HMaster.java c91523a Diff: https://reviews.apache.org/r/1139/diff Testing ------- Thanks, Shrijeet
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1139/#review1146
          -----------------------------------------------------------

          Should : String domainNamePointerToHostName(String dnPtr) be in o.a.h.h.util.Strings? Perhaps it would be better in o.a.h.h.util.Addressing?

          • Eugene

          On 2011-07-18 18:41:16, Shrijeet Paliwal wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1139/

          -----------------------------------------------------------

          (Updated 2011-07-18 18:41:16)

          Review request for hbase and Michael Stack.

          Summary

          -------

          If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will

          have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.

          It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html

          This patch adds a sanitizing function and wraps all calls to getDefaultHost to go through a step of removing trailing period.

          This addresses bug HBASE-4109.

          https://issues.apache.org/jira/browse/HBASE-4109

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/util/Strings.java c2cad2e

          src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java d551c6f

          src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 2d033f3

          src/main/java/org/apache/hadoop/hbase/master/HMaster.java c91523a

          Diff: https://reviews.apache.org/r/1139/diff

          Testing

          -------

          Thanks,

          Shrijeet

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1139/#review1146 ----------------------------------------------------------- Should : String domainNamePointerToHostName(String dnPtr) be in o.a.h.h.util.Strings? Perhaps it would be better in o.a.h.h.util.Addressing? Eugene On 2011-07-18 18:41:16, Shrijeet Paliwal wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1139/ ----------------------------------------------------------- (Updated 2011-07-18 18:41:16) Review request for hbase and Michael Stack. Summary ------- If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing. It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html This patch adds a sanitizing function and wraps all calls to getDefaultHost to go through a step of removing trailing period. This addresses bug HBASE-4109 . https://issues.apache.org/jira/browse/HBASE-4109 Diffs ----- src/main/java/org/apache/hadoop/hbase/util/Strings.java c2cad2e src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java d551c6f src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 2d033f3 src/main/java/org/apache/hadoop/hbase/master/HMaster.java c91523a Diff: https://reviews.apache.org/r/1139/diff Testing ------- Thanks, Shrijeet
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1139/#review1145
          -----------------------------------------------------------

          Ship it!

          +1

          • Michael

          On 2011-07-18 18:41:16, Shrijeet Paliwal wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1139/

          -----------------------------------------------------------

          (Updated 2011-07-18 18:41:16)

          Review request for hbase and Michael Stack.

          Summary

          -------

          If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will

          have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.

          It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html

          This patch adds a sanitizing function and wraps all calls to getDefaultHost to go through a step of removing trailing period.

          This addresses bug HBASE-4109.

          https://issues.apache.org/jira/browse/HBASE-4109

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/util/Strings.java c2cad2e

          src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java d551c6f

          src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 2d033f3

          src/main/java/org/apache/hadoop/hbase/master/HMaster.java c91523a

          Diff: https://reviews.apache.org/r/1139/diff

          Testing

          -------

          Thanks,

          Shrijeet

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1139/#review1145 ----------------------------------------------------------- Ship it! +1 Michael On 2011-07-18 18:41:16, Shrijeet Paliwal wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1139/ ----------------------------------------------------------- (Updated 2011-07-18 18:41:16) Review request for hbase and Michael Stack. Summary ------- If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing. It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html This patch adds a sanitizing function and wraps all calls to getDefaultHost to go through a step of removing trailing period. This addresses bug HBASE-4109 . https://issues.apache.org/jira/browse/HBASE-4109 Diffs ----- src/main/java/org/apache/hadoop/hbase/util/Strings.java c2cad2e src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java d551c6f src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 2d033f3 src/main/java/org/apache/hadoop/hbase/master/HMaster.java c91523a Diff: https://reviews.apache.org/r/1139/diff Testing ------- Thanks, Shrijeet
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1139/
          -----------------------------------------------------------

          Review request for hbase and Michael Stack.

          Summary
          -------

          If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will
          have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing.
          It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html

          This patch adds a sanitizing function and wraps all calls to getDefaultHost to go through a step of removing trailing period.

          This addresses bug HBASE-4109.
          https://issues.apache.org/jira/browse/HBASE-4109

          Diffs


          src/main/java/org/apache/hadoop/hbase/util/Strings.java c2cad2e
          src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java d551c6f
          src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 2d033f3
          src/main/java/org/apache/hadoop/hbase/master/HMaster.java c91523a

          Diff: https://reviews.apache.org/r/1139/diff

          Testing
          -------

          Thanks,

          Shrijeet

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1139/ ----------------------------------------------------------- Review request for hbase and Michael Stack. Summary ------- If you are using an interface anything other than 'default' (literally that keyword) DNS.java 's getDefaultHost will return a string which will have a trailing period at the end. It seems javadoc of reverseDns in DNS.java (see below) is conflicting with what that function is actually doing. It is returning a PTR record while claims it returns a hostname. The PTR record always has period at the end , RFC: http://irbs.net/bog-4.9.5/bog47.html This patch adds a sanitizing function and wraps all calls to getDefaultHost to go through a step of removing trailing period. This addresses bug HBASE-4109 . https://issues.apache.org/jira/browse/HBASE-4109 Diffs src/main/java/org/apache/hadoop/hbase/util/Strings.java c2cad2e src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java d551c6f src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 2d033f3 src/main/java/org/apache/hadoop/hbase/master/HMaster.java c91523a Diff: https://reviews.apache.org/r/1139/diff Testing ------- Thanks, Shrijeet
          Hide
          Shrijeet Paliwal added a comment -

          Patch of hbase 0.90.3

          Show
          Shrijeet Paliwal added a comment - Patch of hbase 0.90.3
          Hide
          Shrijeet Paliwal added a comment -

          Makes my life easier I will submit a patch with sanitizing function today.

          Show
          Shrijeet Paliwal added a comment - Makes my life easier I will submit a patch with sanitizing function today.
          Hide
          stack added a comment -

          @Shrijeet The redo has been done in TRUNK. Regionserver uses a String passed it by the master for all messages (HBASE-1502).

          A sanitization would work for 0.90?

          Show
          stack added a comment - @Shrijeet The redo has been done in TRUNK. Regionserver uses a String passed it by the master for all messages ( HBASE-1502 ). A sanitization would work for 0.90?

            People

            • Assignee:
              Shrijeet Paliwal
              Reporter:
              Shrijeet Paliwal
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development