HBase
  1. HBase
  2. HBASE-7628

Port HBASE-6509 fast-forwarding FuzzyRowFilter to 0.94

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.5
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is to port HBASE-6509: 'Implement fast-forwarding FuzzyRowFilter to allow filtering rows e.g. by "???alex?b"' to 0.94

      1. HBASE-7628.patch
        22 kB
        Anoop Sam John

        Issue Links

          Activity

          Hide
          Jonathan Hsieh added a comment -

          Do we really want this in 0.94? I'm not really a fan of this filter being in hbase core.

          Show
          Jonathan Hsieh added a comment - Do we really want this in 0.94? I'm not really a fan of this filter being in hbase core.
          Hide
          Ted Yu added a comment -

          I read through patch for HBASE-6509 again.
          The addition of fuzzy filter is not intrusive.

          I think the risk of this addition is very low.

          Show
          Ted Yu added a comment - I read through patch for HBASE-6509 again. The addition of fuzzy filter is not intrusive. I think the risk of this addition is very low.
          Hide
          Lars Hofhansl added a comment -

          Jonathan Hsieh Why not? Where else should we have it? It seems useful on its own.

          Show
          Lars Hofhansl added a comment - Jonathan Hsieh Why not? Where else should we have it? It seems useful on its own.
          Hide
          Lars Hofhansl added a comment -

          I do agree that Filters need to be supported better. At least with some classloading that is similar to coprocessors.

          Show
          Lars Hofhansl added a comment - I do agree that Filters need to be supported better. At least with some classloading that is similar to coprocessors.
          Hide
          Jonathan Hsieh added a comment -

          My main concern is that this is actually fairly complicated, and that a filter like this might be better as some sort of plugin. As with the original patch, I'm a +0 on this – low risk and potentially useful I agree, but complicated.

          Show
          Jonathan Hsieh added a comment - My main concern is that this is actually fairly complicated, and that a filter like this might be better as some sort of plugin. As with the original patch, I'm a +0 on this – low risk and potentially useful I agree, but complicated.
          Hide
          Anoop Sam John added a comment -

          I was trying to back port for our version

          Show
          Anoop Sam John added a comment - I was trying to back port for our version
          Hide
          Ted Yu added a comment -

          The following tests passed locally:

          1058 mt -Dtest=TestFuzzyRowFilter
          1060 mt -Dtest=TestHbaseObjectWritable

          Show
          Ted Yu added a comment - The following tests passed locally: 1058 mt -Dtest=TestFuzzyRowFilter 1060 mt -Dtest=TestHbaseObjectWritable
          Hide
          Lars Hofhansl added a comment -

          +1 (Jonathan Hsieh your point is duly noted, we should make a followup jira - or I think there might be one already - to support filters better)

          Show
          Lars Hofhansl added a comment - +1 ( Jonathan Hsieh your point is duly noted, we should make a followup jira - or I think there might be one already - to support filters better)
          Hide
          Ted Yu added a comment -

          Integrated to 0.94 branch

          Thanks for the patch, Anoop.

          Thanks for the review, Lars.

          Show
          Ted Yu added a comment - Integrated to 0.94 branch Thanks for the patch, Anoop. Thanks for the review, Lars.
          Hide
          Jonathan Hsieh added a comment -

          Added link to related HBASE-6527 (pluggable filters)

          Show
          Jonathan Hsieh added a comment - Added link to related HBASE-6527 (pluggable filters)
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94 #766 (See https://builds.apache.org/job/HBase-0.94/766/)
          HBASE-7628 Port HBASE-6509 fast-forwarding FuzzyRowFilter to 0.94 (Anoop) (Revision 1438114)

          Result = SUCCESS
          tedyu :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
          Show
          Hudson added a comment - Integrated in HBase-0.94 #766 (See https://builds.apache.org/job/HBase-0.94/766/ ) HBASE-7628 Port HBASE-6509 fast-forwarding FuzzyRowFilter to 0.94 (Anoop) (Revision 1438114) Result = SUCCESS tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security #97 (See https://builds.apache.org/job/HBase-0.94-security/97/)
          HBASE-7628 Port HBASE-6509 fast-forwarding FuzzyRowFilter to 0.94 (Anoop) (Revision 1438114)

          Result = FAILURE
          tedyu :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security #97 (See https://builds.apache.org/job/HBase-0.94-security/97/ ) HBASE-7628 Port HBASE-6509 fast-forwarding FuzzyRowFilter to 0.94 (Anoop) (Revision 1438114) Result = FAILURE tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security-on-Hadoop-23 #11 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/11/)
          HBASE-7628 Port HBASE-6509 fast-forwarding FuzzyRowFilter to 0.94 (Anoop) (Revision 1438114)

          Result = FAILURE
          tedyu :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #11 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/11/ ) HBASE-7628 Port HBASE-6509 fast-forwarding FuzzyRowFilter to 0.94 (Anoop) (Revision 1438114) Result = FAILURE tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java

            People

            • Assignee:
              Anoop Sam John
              Reporter:
              Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development