HBase
  1. HBase
  2. HBASE-6509

Implement fast-forwarding FuzzyRowFilter to allow filtering rows e.g. by "???alex?b"

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: Filters
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Implement fuzzy row key filter to allow fetching records e.g. by this criteria: "???alex?b".

      This seems to be very useful as an alternative to select records by row keys by specifying their part which is not prefix part. Due to fast-forwarding nature of the filter in many situations this helps to avoid heavy full-table scans.

      This is especially effective when you have composite row key and (some of) its parts has fixed length. E.g. with the key of format userId_actionId_time, given that userId and actionId length is fixed, one can select user actions of specific type using fuzzy row key by specifying mask "????_myaction". Given fast-forwarding nature of filter, this will usually work much faster than doing whole table scan with any of the existing server-side filters.

      In many cases this can work as secondary-indexing alternative.

      Many times users implement it as a custom filter and many times they just don' know this is possible. Let's add it to the common codebase.

      1. HBASE-6509_3.patch
        95 kB
        Alex Baranau
      2. HBASE-6509_2.patch
        20 kB
        Alex Baranau
      3. HBASE-6509_1.patch
        19 kB
        Alex Baranau
      4. HBASE-6509.patch
        19 kB
        Alex Baranau

        Issue Links

          Activity

          Hide
          Ted Yu added a comment -

          @Alex:
          HBASE-7628 port this feature to 0.94

          So no more action is needed.

          Show
          Ted Yu added a comment - @Alex: HBASE-7628 port this feature to 0.94 So no more action is needed.
          Hide
          Alex Baranau added a comment -

          Ted Yu please let me know if some action is needed from my side. Will be happy to help!

          Show
          Alex Baranau added a comment - Ted Yu please let me know if some action is needed from my side. Will be happy to help!
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security-on-Hadoop-23 #11 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/11/)
          HBASE-7628 Port HBASE-6509 fast-forwarding FuzzyRowFilter to 0.94 (Anoop) (Revision 1438114)

          Result = FAILURE
          tedyu :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #11 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/11/ ) HBASE-7628 Port HBASE-6509 fast-forwarding FuzzyRowFilter to 0.94 (Anoop) (Revision 1438114) Result = FAILURE tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security #97 (See https://builds.apache.org/job/HBase-0.94-security/97/)
          HBASE-7628 Port HBASE-6509 fast-forwarding FuzzyRowFilter to 0.94 (Anoop) (Revision 1438114)

          Result = FAILURE
          tedyu :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security #97 (See https://builds.apache.org/job/HBase-0.94-security/97/ ) HBASE-7628 Port HBASE-6509 fast-forwarding FuzzyRowFilter to 0.94 (Anoop) (Revision 1438114) Result = FAILURE tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94 #766 (See https://builds.apache.org/job/HBase-0.94/766/)
          HBASE-7628 Port HBASE-6509 fast-forwarding FuzzyRowFilter to 0.94 (Anoop) (Revision 1438114)

          Result = SUCCESS
          tedyu :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java
          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java
          • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
          Show
          Hudson added a comment - Integrated in HBase-0.94 #766 (See https://builds.apache.org/job/HBase-0.94/766/ ) HBASE-7628 Port HBASE-6509 fast-forwarding FuzzyRowFilter to 0.94 (Anoop) (Revision 1438114) Result = SUCCESS tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java
          Hide
          Ted Yu added a comment -

          Created HBASE-7628 for the backport.

          Show
          Ted Yu added a comment - Created HBASE-7628 for the backport.
          Hide
          Lars Hofhansl added a comment -

          Just noticed that this is only in trunk. Any objections to having this in 0.94 as well? If not, I'll make a patch.

          Show
          Lars Hofhansl added a comment - Just noticed that this is only in trunk. Any objections to having this in 0.94 as well? If not, I'll make a patch.
          Hide
          ramkrishna.s.vasudevan added a comment -

          The blog on Fuzzyrowfilter was very nice.

          Show
          ramkrishna.s.vasudevan added a comment - The blog on Fuzzyrowfilter was very nice.
          Hide
          Alex Baranau added a comment -

          Answered on user list. Subj: "Can I specify the range inside of fuzzy rule in FuzzyRowFilter?". Thank you for a very good question, Anil!

          Show
          Alex Baranau added a comment - Answered on user list. Subj: "Can I specify the range inside of fuzzy rule in FuzzyRowFilter?". Thank you for a very good question, Anil!
          Hide
          stack added a comment -

          @Anil Suggest you ask up on the user list.

          Show
          stack added a comment - @Anil Suggest you ask up on the user list.
          Hide
          Anil Gupta added a comment -

          Hi Alex,

          I have a question related to this filter. I have a similar filtering requirement which will be an extension to FuzzyFilterRow.
          Suppose, i have the following structure of rowkeys: userid_actionid, where userid is of 6 digit and then actionid is 5 digit. I would like to get all the rows with actionid between 00200 to 00350. With current FuzzyRowFilter i can search for all the rows a particular actionid. Instead of searching for a particular actionid i would like to search for a range of actionid.

          Does this use case sounds like an extension to current FuzzyRowFilter? Can i run this kind of filter on HBase0.92 without doing any significant update to the cluster. If i develop this kind of filter then what is needed to run it on all the RS's?

          Thanks,
          Anil

          Show
          Anil Gupta added a comment - Hi Alex, I have a question related to this filter. I have a similar filtering requirement which will be an extension to FuzzyFilterRow. Suppose, i have the following structure of rowkeys: userid_actionid, where userid is of 6 digit and then actionid is 5 digit. I would like to get all the rows with actionid between 00200 to 00350. With current FuzzyRowFilter i can search for all the rows a particular actionid. Instead of searching for a particular actionid i would like to search for a range of actionid. Does this use case sounds like an extension to current FuzzyRowFilter? Can i run this kind of filter on HBase0.92 without doing any significant update to the cluster. If i develop this kind of filter then what is needed to run it on all the RS's? Thanks, Anil
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #3203 (See https://builds.apache.org/job/HBase-TRUNK/3203/)
          HBASE-6509 Implement fast-forwarding FuzzyRowFilter to allow filtering rows e.g. by "???alex?b" (Alex Baranau) (Revision 1370788)

          Result = FAILURE
          tedyu :
          Files :

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FilterProtos.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
          • /hbase/trunk/hbase-server/src/main/protobuf/Filter.proto
          • /hbase/trunk/hbase-server/src/main/protobuf/hbase.proto
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #3203 (See https://builds.apache.org/job/HBase-TRUNK/3203/ ) HBASE-6509 Implement fast-forwarding FuzzyRowFilter to allow filtering rows e.g. by "???alex?b" (Alex Baranau) (Revision 1370788) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FilterProtos.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java /hbase/trunk/hbase-server/src/main/protobuf/Filter.proto /hbase/trunk/hbase-server/src/main/protobuf/hbase.proto /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java
          Hide
          Alex Baranau added a comment -

          patch committed, marking as resolved.

          Thanx Ted, Jon!

          Show
          Alex Baranau added a comment - patch committed, marking as resolved. Thanx Ted, Jon!
          Hide
          Ted Yu added a comment -

          Integrated to trunk.

          Thanks for the patch, Alex.

          Thanks for the comments, Jon.

          Show
          Ted Yu added a comment - Integrated to trunk. Thanks for the patch, Alex. Thanks for the comments, Jon.
          Hide
          Ted Yu added a comment -

          I created HBASE-6527 for Filter plugin.

          Show
          Ted Yu added a comment - I created HBASE-6527 for Filter plugin.
          Hide
          Jonathan Hsieh added a comment -

          I'm +0.

          Just some follow on if this is to be committed – please file a jira to document in book and also, consider filing a jira for making these custom filters some sort of plugin in the future.

          Show
          Jonathan Hsieh added a comment - I'm +0. Just some follow on if this is to be committed – please file a jira to document in book and also, consider filing a jira for making these custom filters some sort of plugin in the future.
          Hide
          Ted Yu added a comment -

          I ran the 3 failed tests locally and they passed.

            532  mt -Dtest=TestClassLoading#testClassLoadingFromLibDirInJar 
            533  mt -Dtest=TestSplitLogManager#testMultipleResubmits 
            534  mt -Dtest=TestReplication#queueFailover 
          

          Placement of new Filter in Filter.proto looks good.

          @Jon:
          Do you have further comments ?

          Show
          Ted Yu added a comment - I ran the 3 failed tests locally and they passed. 532 mt -Dtest=TestClassLoading#testClassLoadingFromLibDirInJar 533 mt -Dtest=TestSplitLogManager#testMultipleResubmits 534 mt -Dtest=TestReplication#queueFailover Placement of new Filter in Filter.proto looks good. @Jon: Do you have further comments ?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12539731/HBASE-6509_3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

          -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.coprocessor.TestClassLoading
          org.apache.hadoop.hbase.replication.TestReplication
          org.apache.hadoop.hbase.master.TestSplitLogManager

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2529//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2529//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2529//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2529//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2529//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2529//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2529//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539731/HBASE-6509_3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestClassLoading org.apache.hadoop.hbase.replication.TestReplication org.apache.hadoop.hbase.master.TestSplitLogManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2529//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2529//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2529//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2529//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2529//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2529//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2529//console This message is automatically generated.
          Hide
          Alex Baranau added a comment -

          Added filter to Filter.proto (aslo added BytesBytesPair type in hbase.proto) & generated java code from it.

          Updated diff on review board (see link to review request in first comments)

          Show
          Alex Baranau added a comment - Added filter to Filter.proto (aslo added BytesBytesPair type in hbase.proto) & generated java code from it. Updated diff on review board (see link to review request in first comments)
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12539386/HBASE-6509_2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

          -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2524//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2524//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539386/HBASE-6509_2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2524//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2524//console This message is automatically generated.
          Hide
          Alex Baranau added a comment -

          Ted, thank you for review. Fixed nits, updated diff.

          Show
          Alex Baranau added a comment - Ted, thank you for review. Fixed nits, updated diff.
          Hide
          Alex Baranau added a comment -

          yes, the point is to utilize fast-forwarding navigation between rows.

          Re more general optimization for regex comparator: I don't think it is doable in general case. I.e. only for very specific cases of regexp we can do fast-forwarding. If we do it for some, that it can be misleading for users, and again, the functionality might be overlooked.

          Show
          Alex Baranau added a comment - yes, the point is to utilize fast-forwarding navigation between rows. Re more general optimization for regex comparator: I don't think it is doable in general case. I.e. only for very specific cases of regexp we can do fast-forwarding. If we do it for some, that it can be misleading for users, and again, the functionality might be overlooked.
          Hide
          Jonathan Hsieh added a comment -

          Ted, interesting.

          I wonder if this kind of optimization is more generally applicable or it is worth pushing down into the regex comparator.

          My concern is that this seems a bit special purpose. I wonder if there is a jira already filed for custom filter plugins/coprocessors.

          Show
          Jonathan Hsieh added a comment - Ted, interesting. I wonder if this kind of optimization is more generally applicable or it is worth pushing down into the regex comparator. My concern is that this seems a bit special purpose. I wonder if there is a jira already filed for custom filter plugins/coprocessors.
          Hide
          Ted Yu added a comment -

          Alex's patch utilizes ReturnCode.SEEK_NEXT_USING_HINT in certain condition.

          Looking at RowFilter, I don't see this optimization.

          Show
          Ted Yu added a comment - Alex's patch utilizes ReturnCode.SEEK_NEXT_USING_HINT in certain condition. Looking at RowFilter, I don't see this optimization.
          Hide
          Jonathan Hsieh added a comment -

          Hey Alex,

          Is there a reason why this is necessary given that it seems tha you can use a RegexStringComparator on a RowFilter?

          #example from title
          Filter f = new RowFilter(CompareOp.EQUALS, new RegexStringComparator("..alex.b") )
          
          # example in javadoc
          Filter f = new RowFilter(CompareOp.EQUALS, new RegexStringComparator("...._99_...._01") )
          
          
          Show
          Jonathan Hsieh added a comment - Hey Alex, Is there a reason why this is necessary given that it seems tha you can use a RegexStringComparator on a RowFilter? #example from title Filter f = new RowFilter(CompareOp.EQUALS, new RegexStringComparator( "..alex.b" ) ) # example in javadoc Filter f = new RowFilter(CompareOp.EQUALS, new RegexStringComparator( "...._99_...._01" ) )
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12539130/HBASE-6509_1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

          -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2501//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2501//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2501//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2501//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2501//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2501//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2501//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539130/HBASE-6509_1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2501//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2501//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2501//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2501//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2501//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2501//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2501//console This message is automatically generated.
          Hide
          Alex Baranau added a comment -

          Added SmallTests annotation to test.

          Thanx, Ted!

          Show
          Alex Baranau added a comment - Added SmallTests annotation to test. Thanx, Ted!
          Hide
          Ted Yu added a comment -

          Please categorize TestFuzzyRowFilter as small test.

          Show
          Ted Yu added a comment - Please categorize TestFuzzyRowFilter as small test.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12539104/HBASE-6509.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

          -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.TestCheckTestClasses

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2500//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2500//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539104/HBASE-6509.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.TestCheckTestClasses Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2500//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2500//console This message is automatically generated.
          Hide
          Alex Baranau added a comment -

          Sorry - my IDE inserted bad "license header" in patch. Fixed

          Show
          Alex Baranau added a comment - Sorry - my IDE inserted bad "license header" in patch. Fixed
          Hide
          Alex Baranau added a comment -

          Attached patch. Also created review request at https://reviews.apache.org/r/6354/. More unit-tests to come (see review).

          Please let me know your thoughts about API. I feel like setting mask (0s and 1s only currently) via byte[] is might be overkill. Not sure if we'll need more states for values. Using byte[] just looked handy to me from the client prospective at the time I implemented this initially (some time ago)

          Show
          Alex Baranau added a comment - Attached patch. Also created review request at https://reviews.apache.org/r/6354/ . More unit-tests to come (see review). Please let me know your thoughts about API. I feel like setting mask (0s and 1s only currently) via byte[] is might be overkill. Not sure if we'll need more states for values. Using byte[] just looked handy to me from the client prospective at the time I implemented this initially (some time ago)

            People

            • Assignee:
              Alex Baranau
              Reporter:
              Alex Baranau
            • Votes:
              1 Vote for this issue
              Watchers:
              15 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development