HBase
  1. HBase
  2. HBASE-4800

Result.compareResults is incorrect

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.90.4, 0.92.0, 0.94.0
    • Fix Version/s: 0.90.5
    • Component/s: Client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      A coworker of mine (James Taylor) found a bug in Result.compareResults(...).
      This condition:

            if (!ourKVs[i].equals(replicatedKVs[i]) &&
                !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
              throw new Exception("This result was different: "
      

      should be

            if (!ourKVs[i].equals(replicatedKVs[i]) ||
                !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
              throw new Exception("This result was different: "
      

      Just checked, this is wrong in all branches.

      1. 4800.txt
        2 kB
        Lars Hofhansl

        Activity

          People

          • Assignee:
            Lars Hofhansl
            Reporter:
            Lars Hofhansl
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development