[HBASE-4800] Result.compareResults is incorrect

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.90.4, 0.92.0, 0.94.0
• Fix Version/s: 0.90.5
• Component/s: Client
• Hadoop Flags: Reviewed
• Assignee: Lars Hofhansl
• Reporter: Lars Hofhansl
• Created: 16/Nov/11 18:06
• Updated: 20/Nov/15 11:54
• Resolved: 16/Nov/11 18:45

Description

A coworker of mine (James Taylor) found a bug in Result.compareResults(...).
This condition:

      if (!ourKVs[i].equals(replicatedKVs[i]) &&
          !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
        throw new Exception("This result was different: "

should be

      if (!ourKVs[i].equals(replicatedKVs[i]) ||
          !Bytes.equals(ourKVs[i].getValue(), replicatedKVs[i].getValue())) {
        throw new Exception("This result was different: "

Just checked, this is wrong in all branches.