Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-4768

Per-(table, columnFamily) metrics with configurable table name inclusion

    XMLWordPrintableJSON

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.0
    • Component/s: None
    • Labels:
      None
    • Release Note:
      Trying to get the most recent patch tested on Hudson.

      Description

      As we kept adding more granular block read and block cache usage statistics, a combinatorial explosion of various cases to monitor started to happen, especially when we wanted both per-table/column family/block type statistics and aggregate statistics on various subsets of these dimensions. Here, we un-clutters HFile readers, LruBlockCache, StoreFile, etc. by creating a centralized class that knows how to update all kinds of per-table/CF/block type counters.

      Table name and column family configuration have been pushed to a base class, SchemaConfigured. This is convenient as many of existing classes that have these properties (HFile readers/writers, HFile blocks, etc.) did not have a base class. Whether to collect per-(table, columnFamily) or per-columnFamily only metrics can be configured with the hbase.metrics.showTableName configuration key. We don't expect this configuration to change at runtime, so we cache the setting statically and log a warning when an attempt is made to flip it once already set. This way we don't have to pass configuration to a lot more places, e.g. everywhere an HFile reader is instantiated.

      Thanks to Liyin for his initial version of per-table metrics patch and a lot of valuable feedback.

        Attachments

        1. ASF.LICENSE.NOT.GRANTED--D363.5.patch
          149 kB
          Phabricator
        2. ASF.LICENSE.NOT.GRANTED--D363.4.patch
          149 kB
          Phabricator
        3. ASF.LICENSE.NOT.GRANTED--D363.3.patch
          148 kB
          Phabricator
        4. ASF.LICENSE.NOT.GRANTED--D363.2.patch
          142 kB
          Phabricator
        5. ASF.LICENSE.NOT.GRANTED--D363.1.patch
          142 kB
          Phabricator
        6. 4768.addendum2
          0.5 kB
          Ted Yu
        7. 4768.addendum
          0.7 kB
          Ted Yu

          Issue Links

            Activity

              People

              • Assignee:
                mikhail Mikhail Gryzykhin
                Reporter:
                mikhail Mikhail Gryzykhin
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: