HBase
  1. HBase
  2. HBASE-4654

[replication] Add a check to make sure we don't replicate to ourselves

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.90.4
    • Fix Version/s: 0.98.0, 0.96.1, 0.94.14
    • Component/s: None
    • Labels:
      None
    • Tags:
      replication

      Description

      It's currently possible to add a peer for replication and point it to the local cluster, which I believe could very well happen for those like us that use only one ZK ensemble per DC so that only the root znode changes when you want to set up replication intra-DC.

      I don't think comparing just the cluster ID would be enough because you would normally use a different one for another cluster and nothing will block you from pointing elsewhere.
      Comparing the ZK ensemble address doesn't work either when you have multiple DNS entries that point at the same place.

      I think this could be resolved by looking up the master address in the relevant znode as it should be exactly the same thing in the case where you have the same cluster.

      1. HBASE-4654-0.96-v0.patch
        1 kB
        Demai Ni
      2. HBASE-4654-trunk-v0.patch
        1 kB
        stack
      3. HBASE-4654-0.94-v0.patch
        1.0 kB
        Demai Ni
      4. HBASE-4654-trunk-v0.patch
        1 kB
        Demai Ni
      5. HBASE-4654-trunk-v0.patch
        1 kB
        Demai Ni
      6. 4654-trunk.txt
        0.8 kB
        Lars Hofhansl

        Activity

        Jean-Daniel Cryans created issue -
        Lars Hofhansl made changes -
        Field Original Value New Value
        Attachment 4654-trunk.txt [ 12503848 ]
        stack made changes -
        Fix Version/s 0.90.6 [ 12319200 ]
        Fix Version/s 0.90.5 [ 12317145 ]
        ramkrishna.s.vasudevan made changes -
        Fix Version/s 0.90.7 [ 12319481 ]
        Fix Version/s 0.92.1 [ 12318551 ]
        Fix Version/s 0.90.6 [ 12319200 ]
        stack made changes -
        Fix Version/s 0.92.2 [ 12319888 ]
        Fix Version/s 0.92.1 [ 12318551 ]
        Fix Version/s 0.90.7 [ 12319481 ]
        stack made changes -
        Fix Version/s 0.92.3 [ 12321692 ]
        Fix Version/s 0.92.2 [ 12319888 ]
        Demai Ni made changes -
        Assignee Demai Ni [ nidmhbase ]
        Demai Ni made changes -
        Attachment HBASE-4654-trunk-v0.patch [ 12613253 ]
        Demai Ni made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Fix Version/s 0.98.0 [ 12323143 ]
        Tags replication
        Demai Ni made changes -
        Attachment HBASE-4654-trunk-v0.patch [ 12613286 ]
        Demai Ni made changes -
        Fix Version/s 0.94.14 [ 12325047 ]
        Fix Version/s 0.92.3 [ 12321692 ]
        Demai Ni made changes -
        Attachment HBASE-4654-0.94-v0.patch [ 12613313 ]
        stack made changes -
        Attachment HBASE-4654-trunk-v0.patch [ 12613316 ]
        Demai Ni made changes -
        Fix Version/s 0.96.1 [ 12324961 ]
        Demai Ni made changes -
        Attachment HBASE-4654-0.96-v0.patch [ 12613513 ]
        Lars Hofhansl made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Lars Hofhansl made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Demai Ni
            Reporter:
            Jean-Daniel Cryans
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development