Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-4654

[replication] Add a check to make sure we don't replicate to ourselves

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.90.4
    • 0.98.0, 0.96.1, 0.94.14
    • None
    • None
    • replication

    Description

      It's currently possible to add a peer for replication and point it to the local cluster, which I believe could very well happen for those like us that use only one ZK ensemble per DC so that only the root znode changes when you want to set up replication intra-DC.

      I don't think comparing just the cluster ID would be enough because you would normally use a different one for another cluster and nothing will block you from pointing elsewhere.
      Comparing the ZK ensemble address doesn't work either when you have multiple DNS entries that point at the same place.

      I think this could be resolved by looking up the master address in the relevant znode as it should be exactly the same thing in the case where you have the same cluster.

      Attachments

        1. 4654-trunk.txt
          0.8 kB
          Lars Hofhansl
        2. HBASE-4654-0.94-v0.patch
          1.0 kB
          Demai Ni
        3. HBASE-4654-0.96-v0.patch
          1 kB
          Demai Ni
        4. HBASE-4654-trunk-v0.patch
          1 kB
          Michael Stack
        5. HBASE-4654-trunk-v0.patch
          1 kB
          Demai Ni
        6. HBASE-4654-trunk-v0.patch
          1 kB
          Demai Ni

        Activity

          People

            nidmhbase Demai Ni
            jdcryans Jean-Daniel Cryans
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: