Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-4384

Hard to tell what causes failure in CloseRegionHandler#getCurrentVersion

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.90.0
    • Fix Version/s: 0.90.5
    • Component/s: Zookeeper
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The current code goes like:

      172    * Get the node's current version
      173    * @return The expectedVersion.  If -1, we failed getting the node
      174    */
      175   private int getCurrentVersion() {
      176     int expectedVersion = FAILED;
      177     try {
      178       if ((expectedVersion = ZKAssign.getVersion(
      179           server.getZooKeeper(), regionInfo)) == FAILED) {
      180         LOG.warn("Error getting node's version in CLOSING state," +
      181           " aborting close of " + regionInfo.getRegionNameAsString());
      182       }
      183     } catch (KeeperException e) {
      184       LOG.warn("Error creating node in CLOSING state, aborting close of " +
      185         regionInfo.getRegionNameAsString());
      186     }
      187     return expectedVersion;
      188   }
      189 }
      

      Both WARN cases would be identical this way. In case of an exception, I think an exception ought to be logged as well.

        Attachments

          Activity

            People

            • Assignee:
              qwertymaniac Harsh J
              Reporter:
              qwertymaniac Harsh J
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: