[HBASE-4384] Hard to tell what causes failure in CloseRegionHandler#getCurrentVersion

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.90.0
• Fix Version/s: 0.90.5
• Component/s: Zookeeper
• Hadoop Flags: Reviewed
• Assignee: Harsh J
• Reporter: Harsh J
• Created: 13/Sep/11 10:01
• Updated: 20/Nov/15 11:52
• Resolved: 13/Sep/11 21:11

Description

The current code goes like:

172    * Get the node's current version
173    * @return The expectedVersion.  If -1, we failed getting the node
174    */
175   private int getCurrentVersion() {
176     int expectedVersion = FAILED;
177     try {
178       if ((expectedVersion = ZKAssign.getVersion(
179           server.getZooKeeper(), regionInfo)) == FAILED) {
180         LOG.warn("Error getting node's version in CLOSING state," +
181           " aborting close of " + regionInfo.getRegionNameAsString());
182       }
183     } catch (KeeperException e) {
184       LOG.warn("Error creating node in CLOSING state, aborting close of " +
185         regionInfo.getRegionNameAsString());
186     }
187     return expectedVersion;
188   }
189 }

Both WARN cases would be identical this way. In case of an exception, I think an exception ought to be logged as well.