[HBASE-28413] Fix race condition in TestCleanerChore.retriesIOExceptionInStatus

• Type: Test
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.6.0, 3.0.0-alpha-4, 4.0.0-alpha-1
• Component/s: test
• Labels: pull-request-available
• Assignee: Nick Dimiduk
• Reporter: Nick Dimiduk
• Created: 01/Mar/24 06:45
• Updated: 03/Mar/24 08:00

Description

We occasionally get a test failure in TestCleanerChore.retriesIOExceptionInStatus. For example, from a recent PR build on branch-2.6,

java.util.concurrent.ExecutionException: java.io.IOException: whomp whomp.
	at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:395)
	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1999)
	at org.apache.hadoop.hbase.master.cleaner.TestCleanerChore.retriesIOExceptionInStatus(TestCleanerChore.java:163)
...
Caused by: java.io.IOException: whomp whomp.
	at org.apache.hadoop.hbase.master.cleaner.TestCleanerChore$1.listStatus(TestCleanerChore.java:134)
	at org.apache.hadoop.hbase.master.cleaner.CleanerChore.traverseAndDelete(CleanerChore.java:475)
	at org.apache.hadoop.hbase.master.cleaner.CleanerChore.lambda$chore$0(CleanerChore.java:258)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	... 1 more

This looks like a race condition where the chore manages an entire execution between when the flag is flipped and when the test thread gets back around to continuing execution. Make the test a little more pessimistic about its view of the world.

Issue Links

• relates to: HBASE-27321 The ReplicationLogCleaner is not thread safe but can be called from different threads at the same time
• links to: GitHub Pull Request #5735