[HBASE-27321] The ReplicationLogCleaner is not thread safe but can be called from different threads at the same time

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.6.0, 3.0.0-alpha-4
• Component/s: master, Replication
• Hadoop Flags: Reviewed
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 24/Aug/22 02:43
• Updated: 01/Mar/24 07:00
• Resolved: 27/Aug/22 16:32

Description

In preClean method we will update the class fields and then use them in the getDeletableFiles method. This implies that we will have only one cleaner run at the same time.

But actually, in MasterRpcServices.runCleanerChore, we will call execute the HFileCleaner and LogCleaner directly, not in the cleanerChore thread.

This could cause data loss for replication, which is a very serious problem.

Issue Links

• is related to: HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus
• links to: GitHub Pull Request #4730