[HBASE-28248] Race between RegionRemoteProcedureBase and rollback operation could lead to ROLLEDBACK state be persisent to procedure store

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.6.0, 2.4.18, 3.0.0-beta-1, 2.5.7
• Component/s: proc-v2, Region Assignment
• Hadoop Flags: Reviewed
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 07/Dec/23 06:22
• Updated: 10/Dec/23 20:13
• Resolved: 09/Dec/23 14:18

Description

And then cause load procedures failure.

This is because we do not execute RegionRemoteProcedureBase.persistAndWake method in PEWorker, so even if we hold the procedureExecutionLock in rollback, they could be executed concurrently.

So it is possible that in rollback, we set the state to ROLLEDBACK and delete the procedure, and then in persistAndWake, we persist the ROLLEDBACK state to procedure store.

Issue Links

• is broken by: HBASE-28212 Do not need to maintain rollback step when root procedure does not support rollback
• links to: GitHub Pull Request #5567