[HBASE-28212] Do not need to maintain rollback step when root procedure does not support rollback

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.6.0, 2.4.18, 3.0.0-beta-1, 2.5.7
• Component/s: master, proc-v2
• Hadoop Flags: Reviewed
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 21/Nov/23 04:01
• Updated: 07/Dec/23 06:22
• Resolved: 02/Dec/23 13:15

Description

In HBASE-28210, we need to synchronized on RootProcedureState when updating procedure store, which will decrease the performance a lot when there are lots of sub procedures for a procedure, such as SCP, so it will impact MTTR.
But actually, SCP does not support rollback, so I do not think we need to maintain this information. If so, I think we do not need the synchronization added in HBASE-28210, at least for SCP then. This could get the performance back.

Issue Links

• breaks: HBASE-28248 Race between RegionRemoteProcedureBase and rollback operation could lead to ROLLEDBACK state be persisent to procedure store
• is related to: HBASE-28210 There could be holes in stack ids when loading procedures
• links to: GitHub Pull Request #5538
• links to: GitHub Pull Request #5547
• links to: GitHub Pull Request #5555