[HBASE-25989] FanOutOneBlockAsyncDFSOutput using shaded protobuf in hdfs 3.3+

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.5.0, 2.4.5
• Hadoop Flags: Reviewed
• Assignee: Michael Stack
• Reporter: Michael Stack
• Created: 09/Jun/21 16:54
• Updated: 14/Jun/21 14:12
• Resolved: 12/Jun/21 14:33

Description

The parent added some fancy dancing to make it so on hadoop-3.3.0+ we'd use hadoops shaded protobuf rather than the non-relocated protobuf. When hdfs 3.3, the 'trick' is not working so we continue to use the unshaded protobuf. Fix is trivial.

Found this testing the 3.3.1RC3. Hard to see because whether we use shaded or unshaded is at DEBUG level. If you set DEBUG level and run TestFanOutOneBlockAsyncDFSOutput with hdfs 3.3.1 RC candidate in place you'll see it uses the unshaded protobuf.

Issue Links

• is related to: HBASE-25920 Support Hadoop 3.3.1
• links to: GitHub Pull Request #3368