[HBASE-23833] The relocated hadoop-thirdparty protobuf breaks HBase asyncwal

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1
• Fix Version/s: 3.0.0-alpha-1, 2.3.0, 2.2.5
• Component/s: wal
• Hadoop Flags: Reviewed
• Assignee: Wei-Chiu Chuang
• Reporter: Wei-Chiu Chuang
• Created: 13/Feb/20 00:33
• Updated: 21/May/20 09:17
• Resolved: 17/Apr/20 19:10

Description

Hadoop trunk (3.3.0) shaded protobuf and moved it to hadoop-thirdparty. As the result, hbase asyncwal fails to compile because asyncwal uses the Hadoop's protobuf objects.

The following command

mvn clean install -Dhadoop.profile=3.0 -Dhadoop.version=3.3.0-SNAPSHOT

fails with the following error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project hbase-server: Compilation failure: Compilation failure:
[ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[361,44] cannot access org.apache.hadoop.thirdparty.protobuf.MessageOrBuilder
[ERROR]   class file for org.apache.hadoop.thirdparty.protobuf.MessageOrBuilder not found
[ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[362,14] cannot access org.apache.hadoop.thirdparty.protobuf.GeneratedMessageV3
[ERROR]   class file for org.apache.hadoop.thirdparty.protobuf.GeneratedMessageV3 not found
[ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[366,16] cannot access org.apache.hadoop.thirdparty.protobuf.ByteString
[ERROR]   class file for org.apache.hadoop.thirdparty.protobuf.ByteString not found
[ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[375,12] cannot find symbol
[ERROR]   symbol:   method writeDelimitedTo(org.apache.hbase.thirdparty.io.netty.buffer.ByteBufOutputStream)
[ERROR]   location: variable proto of type org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.DataTransferEncryptorMessageProto
[ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[702,81] incompatible types: org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.DataTransferEncryptorMessageProto cannot be converted to com.google.protobuf.MessageLite
[ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:[314,66] incompatible types: org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.BlockOpResponseProto cannot be converted to com.google.protobuf.MessageLite
[ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:[330,81] cannot access org.apache.hadoop.thirdparty.protobuf.ProtocolMessageEnum
[ERROR]   class file for org.apache.hadoop.thirdparty.protobuf.ProtocolMessageEnum not found
[ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:[380,10] cannot find symbol
[ERROR]   symbol:   method writeDelimitedTo(org.apache.hbase.thirdparty.io.netty.buffer.ByteBufOutputStream)
[ERROR]   location: variable proto of type org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.OpWriteBlockProto
[ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:[422,77] cannot access org.apache.hadoop.thirdparty.protobuf.Descriptors
[ERROR]   class file for org.apache.hadoop.thirdparty.protobuf.Descriptors not found
[ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutput.java:[323,64] incompatible types: org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.PipelineAckProto cannot be converted to com.google.protobuf.MessageLite
[ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/SyncReplicationWALProvider.java:[209,68] invalid method reference
[ERROR]   non-static method get() cannot be referenced from a static context

Issue Links

• blocks: HBASE-23829 Get `-PrunSmallTests` passing on JDK11
• is broken by: HADOOP-16596 [pb-upgrade] Use shaded protobuf classes from hadoop-thirdparty dependency
• is related to: HBASE-22953 Supporting Hadoop 3.3.0
• relates to: HBASE-22103 HDFS-13209 in Hadoop 3.3.0 breaks asyncwal
• relates to: HBASE-24209 [Hadoop3.3] Add Hadoop-3.3.0-SNAPSHOT to hadoopcheck in our yetus personality
• links to: GitHub Pull Request #1301
• links to: GitHub Pull Request #1534
• links to: GitHub Pull Request #1535

Sub-Tasks

• Backport HBASE-23833 to branch-2.2: Resolved
• FanOutOneBlockAsyncDFSOutput using shaded protobuf in hdfs 3.3+: Resolved