Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-23312

HBase Thrift SPNEGO configs (HBASE-19852) should be backwards compatible

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha-1, 2.1.1, 2.1.2, 2.1.3, 2.1.4, 2.1.5, 2.1.6, 2.1.7, 2.1.8
    • Fix Version/s: 3.0.0-alpha-1, 2.3.0, 2.2.3, 2.1.9
    • Component/s: Thrift
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      The newer HBase Thrift SPNEGO configs should not be required. The hbase.thrift.spnego.keytab.file and hbase.thrift.spnego.principal configs will fall back to the hbase.thrift.keytab.file and hbase.thrift.kerberos.principal original configs. The older configs will log a deprecation warning. It is preferred to new the newer SPNEGO configurations.
      Show
      The newer HBase Thrift SPNEGO configs should not be required. The hbase.thrift.spnego.keytab.file and hbase.thrift.spnego.principal configs will fall back to the hbase.thrift.keytab.file and hbase.thrift.kerberos.principal original configs. The older configs will log a deprecation warning. It is preferred to new the newer SPNEGO configurations.

      Description

      HBASE-19852 is not backwards compatible since it now requires the SPNEGO thrift configs. I haven't seen anything in Apache HBase about changing this so that the older configs still work with a merged keytab. (fall back to the non SPNEGO specific principal/keytab configs)

      I wrote the original patch in HBASE-19852 and with hindsight being 20/20, I think this section of could be extended to fall back to not requiring the additional configs.

      https://github.com/apache/hbase/blame/master/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftHttpServlet.java#L78

      Supporting the older configs allows upgrade from HBase 1.x to 2.x without needing to change the configs ahead of time. I'll make sure to log a deprecation warning if the older configs are used.

        Attachments

        1. HBASE-23312.master.001.patch
          32 kB
          Kevin Risden

          Issue Links

            Activity

              People

              • Assignee:
                krisden Kevin Risden
                Reporter:
                krisden Kevin Risden
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: