[HBASE-23312] HBase Thrift SPNEGO configs (HBASE-19852) should be backwards compatible

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-1, 2.1.1, 2.1.2, 2.1.3, 2.1.4, 2.1.5, 2.1.6, 2.1.7, 2.1.8
• Fix Version/s: 3.0.0-alpha-1, 2.3.0, 2.2.3, 2.1.9
• Component/s: Thrift
• Hadoop Flags: Reviewed

Release Note

The newer HBase Thrift SPNEGO configs should not be required. The hbase.thrift.spnego.keytab.file and hbase.thrift.spnego.principal configs will fall back to the hbase.thrift.keytab.file and hbase.thrift.kerberos.principal original configs. The older configs will log a deprecation warning. It is preferred to new the newer SPNEGO configurations.

• Assignee: Kevin Risden
• Reporter: Kevin Risden
• Created: 18/Nov/19 15:12
• Updated: 29/Nov/19 09:49
• Resolved: 26/Nov/19 16:20

Description

HBASE-19852 is not backwards compatible since it now requires the SPNEGO thrift configs. I haven't seen anything in Apache HBase about changing this so that the older configs still work with a merged keytab. (fall back to the non SPNEGO specific principal/keytab configs)

I wrote the original patch in HBASE-19852 and with hindsight being 20/20, I think this section of could be extended to fall back to not requiring the additional configs.

https://github.com/apache/hbase/blame/master/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftHttpServlet.java#L78

Supporting the older configs allows upgrade from HBase 1.x to 2.x without needing to change the configs ahead of time. I'll make sure to log a deprecation warning if the older configs are used.

Issue Links

• is caused by: HBASE-19852 HBase Thrift 1 server SPNEGO Improvements
• is duplicated by: HBASE-23343 Thrift Resolve FQDN from SPNEGO principal
• links to: GitHub Pull Request #850
• links to: GitHub Pull Request #878
• links to: Review Board (master)