-
Type:
Sub-task
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 3.0.0-alpha-1, 2.3.0
-
Component/s: None
-
Labels:None
-
Hadoop Flags:Reviewed
In ByteBufferIOEngine , we have the assert:
@Override public void write(ByteBuffer srcBuffer, long offset) throws IOException { assert srcBuffer.hasArray(); bufferArray.putMultiple(offset, srcBuffer.remaining(), srcBuffer.array(), srcBuffer.arrayOffset()); } @Override public void write(ByteBuff srcBuffer, long offset) throws IOException { // When caching block into BucketCache there will be single buffer backing for this HFileBlock. // This will work for now. But from the DFS itself if we get DBB then this may not hold true. assert srcBuffer.hasArray(); bufferArray.putMultiple(offset, srcBuffer.remaining(), srcBuffer.array(), srcBuffer.arrayOffset()); }
Should remove the assert, and allow to write off-heap ByteBuff to bufferArray.
- breaks
-
HBASE-22651 ErrorProne issue in TestByteBufferArray
-
- Resolved
-
- links to