XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In ByteBufferIOEngine , we have the assert:

        @Override
        public void write(ByteBuffer srcBuffer, long offset) throws IOException {
          assert srcBuffer.hasArray();
          bufferArray.putMultiple(offset, srcBuffer.remaining(), srcBuffer.array(),
              srcBuffer.arrayOffset());
        }
      
        @Override
        public void write(ByteBuff srcBuffer, long offset) throws IOException {
          // When caching block into BucketCache there will be single buffer backing for this HFileBlock.
          // This will work for now. But from the DFS itself if we get DBB then this may not hold true.
          assert srcBuffer.hasArray();
          bufferArray.putMultiple(offset, srcBuffer.remaining(), srcBuffer.array(),
              srcBuffer.arrayOffset());
        }
      

      Should remove the assert, and allow to write off-heap ByteBuff to bufferArray.

        Attachments

        1. HBASE-22159.HBASE-21879.v7.patch
          58 kB
          Zheng Hu
        2. HBASE-22159.HBASE-21879.v6.patch
          54 kB
          Zheng Hu
        3. HBASE-22159.HBASE-21879.v5.patch
          41 kB
          Zheng Hu
        4. HBASE-22159.HBASE-21879.v4.patch
          37 kB
          Zheng Hu
        5. HBASE-22159.HBASE-21879.v3.patch
          34 kB
          Zheng Hu
        6. HBASE-22159.HBASE-21879.v2.patch
          31 kB
          Zheng Hu
        7. HBASE-22159.HBASE-21879.v1.patch
          22 kB
          Zheng Hu

          Issue Links

            Activity

              People

              • Assignee:
                openinx Zheng Hu
                Reporter:
                openinx Zheng Hu
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: