[HBASE-22159] ByteBufferIOEngine should support write off-heap ByteBuff to the bufferArray

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.3.0
• Hadoop Flags: Reviewed
• Assignee: Zheng Hu
• Reporter: Zheng Hu
• Created: 03/Apr/19 09:01
• Updated: 23/Jan/20 17:38
• Resolved: 12/Apr/19 10:45

Description

In ByteBufferIOEngine , we have the assert:

  @Override
  public void write(ByteBuffer srcBuffer, long offset) throws IOException {
    assert srcBuffer.hasArray();
    bufferArray.putMultiple(offset, srcBuffer.remaining(), srcBuffer.array(),
        srcBuffer.arrayOffset());
  }

  @Override
  public void write(ByteBuff srcBuffer, long offset) throws IOException {
    // When caching block into BucketCache there will be single buffer backing for this HFileBlock.
    // This will work for now. But from the DFS itself if we get DBB then this may not hold true.
    assert srcBuffer.hasArray();
    bufferArray.putMultiple(offset, srcBuffer.remaining(), srcBuffer.array(),
        srcBuffer.arrayOffset());
  }

Should remove the assert, and allow to write off-heap ByteBuff to bufferArray.

Issue Links

• breaks: HBASE-22651 ErrorProne issue in TestByteBufferArray
• links to: Review board