-
Type:
Sub-task
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 3.0.0-alpha-1, 2.3.0
-
Component/s: None
-
Labels:None
-
Hadoop Flags:Reviewed
In HBASE-22005, we have the following TODO in HFileBlock#CacheableDeserializer:
public static final class BlockDeserializer implements CacheableDeserializer<Cacheable> { private BlockDeserializer() { } @Override public HFileBlock deserialize(ByteBuff buf, boolean reuse, MemoryType memType) throws IOException { // .... // TODO make the newly created HFileBlock use the off-heap allocator, Need change the // deserializer or change the deserialize interface. return new HFileBlock(newByteBuff, usesChecksum, memType, offset, nextBlockOnDiskSize, null, ByteBuffAllocator.HEAP); }
Should use the global ByteBuffAllocator here rather than HEAP allocator, as the TODO said, we need to adjust the interface of deserializer.
- links to