[HBASE-22090] The HFileBlock#CacheableDeserializer should pass ByteBuffAllocator to the newly created HFileBlock

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha-1, 2.3.0
• Hadoop Flags: Reviewed
• Assignee: Zheng Hu
• Reporter: Zheng Hu
• Created: 22/Mar/19 16:38
• Updated: 23/Jan/20 17:47
• Resolved: 09/May/19 08:47

Description

In HBASE-22005, we have the following TODO in HFileBlock#CacheableDeserializer:

  public static final class BlockDeserializer implements CacheableDeserializer<Cacheable> {
    private BlockDeserializer() {
    }

    @Override
    public HFileBlock deserialize(ByteBuff buf, boolean reuse, MemoryType memType)
        throws IOException {
       // ....

      // TODO make the newly created HFileBlock use the off-heap allocator, Need change the
      // deserializer or change the deserialize interface.
      return new HFileBlock(newByteBuff, usesChecksum, memType, offset, nextBlockOnDiskSize, null,
          ByteBuffAllocator.HEAP);
    }

Should use the global ByteBuffAllocator here rather than HEAP allocator, as the TODO said, we need to adjust the interface of deserializer.

Issue Links

• links to: Review board