Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersConvert to IssueMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0-alpha-1, 2.3.0
    • None
    • None
    • Reviewed

    Description

      When decompressing an compressed block, we are also allocating HeapByteBuffer for the unpacked block. should allocate ByteBuff from the global ByteBuffAllocator, skimmed the code, the key point is, we need an ByteBuff decompress interface, not the following:

      # Compression.java
        public static void decompress(byte[] dest, int destOffset,
            InputStream bufferedBoundedStream, int compressedSize,
            int uncompressedSize, Compression.Algorithm compressAlgo)
            throws IOException {
            //...
      }
      

      Not very high priority, let me make the block without compression to be offheap firstly.

      In HBASE-22005, I ignored the unit test:
      1. TestLoadAndSwitchEncodeOnDisk ;
      2. TestHFileBlock#testPreviousOffset;

      Need to resolve this issue and make those UT works fine.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            openinx Zheng Hu Assign to me
            openinx Zheng Hu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment