Details
-
Sub-task
-
Status: Closed
-
Blocker
-
Resolution: Fixed
-
1.4.0, 2.0.0
-
None
-
Incompatible change
-
Hide<!-- markdown -->
The HBase shell now behaves as it did prior to the changes that started inHBASE-15965. Namely, some shell commands return values that may be further manipulated within the shell's IRB session.
The command line option `--return-values` is no longer acted on by the shell since it now always behaves as it did when passed this parameter. Passing the option results in a harmless warning about this change.
Users who wish to maintain the behavior seen in the 1.4.0-1.4.2 releases of the HBase shell should refer to the section _irbrc_ in the reference guide for how to configure their IRB session to avoid echoing expression results to the console.Show<!-- markdown --> The HBase shell now behaves as it did prior to the changes that started in HBASE-15965 . Namely, some shell commands return values that may be further manipulated within the shell's IRB session. The command line option `--return-values` is no longer acted on by the shell since it now always behaves as it did when passed this parameter. Passing the option results in a harmless warning about this change. Users who wish to maintain the behavior seen in the 1.4.0-1.4.2 releases of the HBase shell should refer to the section _irbrc_ in the reference guide for how to configure their IRB session to avoid echoing expression results to the console.
Description
Feedback from mdrob on HBASE-19158:
Shell:
HBASE-19770. There was another issue opened where this was identified as a problem so maybe the shape will change further, but I can't find it now.
New commentary from busbey:
This was a follow on to HBASE-15965. That change effectively makes it so none of our ruby wrappers can be used to build expressions in an interactive REPL. This is a pretty severe change (most of my tips on HBASE-15611 will break, I think).
I think we should
a) Have a DISCUSS thread, spanning dev@ and user@
b) based on the outcome of that thread, either default to the new behavior or the old behavior
c) if we keep the HBASE-15965 behavior as the default, flag it as incompatible, call it out in the hbase 2.0 upgrade section, and update docs (two examples: the output in the shell_exercises sections would be wrong, and the _table_variables section won't work)
d) In either case document the new flag in the ref guide
Attachments
Attachments
- HBASE-20276.0.patch
- 8 kB
- Sean Busbey
- HBASE-20276.1.patch
- 9 kB
- Sean Busbey
- HBASE-20276.2.patch
- 13 kB
- Sean Busbey
- HBASE-20276.3.patch
- 9 kB
- Sean Busbey
- HBASE-20276-branch-1.v4.patch
- 2 kB
- Sean Busbey
Issue Links
- blocks
-
HBASE-20263 Update stable release line to be based on branch-1.4
- Closed
- is duplicated by
-
HBASE-20304 Flip default "return-values" in shell from false to true
- Closed
- relates to
-
HBASE-20463 Fix breakage introduced on branch-1 by HBASE-20276 "[shell] Revert shell REPL change and document"
- Closed
- supercedes
-
HBASE-19770 Add '--return-values' option to Shell to print return values of commands in interactive mode
- Closed
Activity
either default to [...] the old behavior
I'm definitely in the camp that this should be treated as a bug. It has repercussions that stretched beyond what was originally intended. I think the proper thing is to revert to the old functionality (and the fact that it is a "bug" gives us justification to fix it since 1.4.0)
This seems pretty severe? I can't find mention in the docs about what our compat guarantees for shell commands are...
which direction seems severe? reverting or having it in the first place?
Sorry guys for the mess i started.
Another alternate is - Remove the --return-values flag and make that functionality default (which is what we had earlier). And explicitly call it out as bug in 1.4.0, 1.4.1 releases.
That will undo the damage in 2.0 and we won't have to carry the baggage in future.
I put up a DISCUSS thread pointing folks over here.
I think we already have enough consensus to get a patch up for 1.5+ I'm happy to either get the patch together or review. I'll do the former after I wrap up some other stuff, or the latter if someone else has time to do it sooner.
FWIW, I think we should keep the --return-values flag because it's been in a release. we should just have it print a message about how the change to not return values has been removed.
FWIW, I think we should keep the --return-values flag because it's been in a release. we should just have it print a message about how the change to not return values has been removed.
This is a good compromise for already released 1.4, let's do it.
So the description of this should change to "Revert shell REPL change and document"?
I'd like to add some kind of test here, but I'm still chewing on what that looks like. Happy to have that punted to a follow-on if folks want to see this closed out sooner rather than later.
-0
- restores old behavior
- warn on ignored flag use
- docs on muting console value inspection
- upgrade docs
because one of the things HBASE-15965 changed was to print out more details for the get_splits command, but to do it in the building block function HBase::Table::_get_splits_internal. That method currently also gets used by several tests that don't care about output, and it's also useful if someone needs to reach behind our supported interface to build something programmatic that will operate directly on the splits (ala the stuff in HBASE-15611).
printing the splits in the internal part instead of in the user facing part where it presumably is usefully consumed seemed off, so I moved that part to the user facing command. The summary blurb about number of splits seemed similarly out of place though it's been there much longer, so I moved it over as well.
The net result is that those properly using get_splits directly get the same output as before, but when we're hitting internal for it we skip having puts without reimplementing the function.
+1 pending QA, fine to add a test in a follow-on issue, since a bunch of the implicit jruby stuff doesn't have testing anyway.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 23s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 23s | Maven dependency ordering for branch |
+1 | mvninstall | 4m 30s | master passed |
+1 | javadoc | 2m 36s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 12s | Maven dependency ordering for patch |
+1 | mvninstall | 4m 12s | the patch passed |
-1 | rubocop | 0m 16s | The patch generated 7 new + 246 unchanged - 5 fixed = 253 total (was 251) |
+1 | ruby-lint | 0m 7s | The patch generated 0 new + 189 unchanged - 1 fixed = 189 total (was 190) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | javadoc | 2m 42s | the patch passed |
Other Tests | |||
+1 | unit | 245m 23s | root in the patch passed. |
-1 | asflicense | 0m 51s | The patch generated 1 ASF License warnings. |
261m 54s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12917589/HBASE-20276.0.patch |
Optional Tests | asflicense rubocop ruby_lint javac javadoc unit |
uname | Linux b1f80b133ad4 4.4.0-104-generic #127-Ubuntu SMP Mon Dec 11 12:16:42 UTC 2017 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / 0c0fe05bc4 |
maven | version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
Default Java | 1.8.0_162 |
rubocop | v0.54.0 |
rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/12301/artifact/patchprocess/diff-patch-rubocop.txt |
ruby-lint | v2.3.1 |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/12301/testReport/ |
asflicense | https://builds.apache.org/job/PreCommit-HBASE-Build/12301/artifact/patchprocess/patch-asflicense-problems.txt |
Max. process+thread count | 4740 (vs. ulimit of 10000) |
modules | C: hbase-shell . U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/12301/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
asflicense warning was from HBASE-17730 and has since been fixed.
rubocop looks legit. let me see what I can do.
-1
- rubocop suggested fixes
- disable class length check on Table and Shell classes, since I can't fix them without a major refactoring.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 11s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 16s | Maven dependency ordering for branch |
+1 | mvninstall | 5m 30s | master passed |
+1 | javadoc | 3m 23s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 13s | Maven dependency ordering for patch |
+1 | mvninstall | 5m 28s | the patch passed |
-1 | rubocop | 0m 20s | The patch generated 2 new + 245 unchanged - 6 fixed = 247 total (was 251) |
-1 | ruby-lint | 0m 8s | The patch generated 1 new + 188 unchanged - 2 fixed = 189 total (was 190) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | javadoc | 3m 43s | the patch passed |
Other Tests | |||
+1 | unit | 181m 6s | root in the patch passed. |
+1 | asflicense | 0m 51s | The patch does not generate ASF License warnings. |
201m 37s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12917696/HBASE-20276.1.patch |
Optional Tests | asflicense rubocop ruby_lint javac javadoc unit |
uname | Linux b4619db10568 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / e2b0490d18 |
maven | version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
Default Java | 1.8.0_162 |
rubocop | v0.54.0 |
rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/12308/artifact/patchprocess/diff-patch-rubocop.txt |
ruby-lint | v2.3.1 |
ruby-lint | https://builds.apache.org/job/PreCommit-HBASE-Build/12308/artifact/patchprocess/diff-patch-ruby-lint.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/12308/testReport/ |
Max. process+thread count | 4340 (vs. ulimit of 10000) |
modules | C: hbase-shell . U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/12308/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
-2
- fix additional rubocop complaints
- fix rubylint complaint by switching uses of Bytes in table.rb to rely on an import (which also fixes some line length stuff.)
taking out of PA. on second thought I'd rather not alter so much of table.rb
I think this is better than using v1:
-v3
- go back to not messing with most of table.rb
- make an explicit java_import for Bytes (I'm not sure why things worked without this)
- fix rubodoc complaints
Locally, this gets a clean bill of health from rubocop. ruby-lint actually complains more, but it looks like that's because it doesn't understand jruby.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 11s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 28s | Maven dependency ordering for branch |
+1 | mvninstall | 4m 25s | master passed |
+1 | javadoc | 2m 37s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 12s | Maven dependency ordering for patch |
+1 | mvninstall | 4m 4s | the patch passed |
-1 | rubocop | 0m 16s | The patch generated 10 new + 229 unchanged - 22 fixed = 239 total (was 251) |
-1 | ruby-lint | 0m 7s | The patch generated 10 new + 181 unchanged - 9 fixed = 191 total (was 190) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | javadoc | 2m 37s | the patch passed |
Other Tests | |||
-1 | unit | 115m 28s | root in the patch failed. |
+1 | asflicense | 0m 42s | The patch does not generate ASF License warnings. |
131m 27s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hbase.master.TestShutdownWithNoRegionServer |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12917752/HBASE-20276.2.patch |
Optional Tests | asflicense rubocop ruby_lint javac javadoc unit |
uname | Linux 35ee68d59daa 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / 8f6849ff02 |
maven | version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
Default Java | 1.8.0_162 |
rubocop | v0.54.0 |
rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/12314/artifact/patchprocess/diff-patch-rubocop.txt |
ruby-lint | v2.3.1 |
ruby-lint | https://builds.apache.org/job/PreCommit-HBASE-Build/12314/artifact/patchprocess/diff-patch-ruby-lint.txt |
unit | https://builds.apache.org/job/PreCommit-HBASE-Build/12314/artifact/patchprocess/patch-unit-root.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/12314/testReport/ |
Max. process+thread count | 3953 (vs. ulimit of 10000) |
modules | C: hbase-shell . U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/12314/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 12s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 14s | Maven dependency ordering for branch |
+1 | mvninstall | 5m 14s | master passed |
+1 | javadoc | 3m 14s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 12s | Maven dependency ordering for patch |
+1 | mvninstall | 4m 40s | the patch passed |
+1 | rubocop | 0m 20s | The patch generated 0 new + 245 unchanged - 6 fixed = 245 total (was 251) |
-1 | ruby-lint | 0m 7s | The patch generated 3 new + 188 unchanged - 2 fixed = 191 total (was 190) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | javadoc | 2m 43s | the patch passed |
Other Tests | |||
+1 | unit | 183m 0s | root in the patch passed. |
+1 | asflicense | 3m 17s | The patch does not generate ASF License warnings. |
203m 35s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12917766/HBASE-20276.3.patch |
Optional Tests | asflicense rubocop ruby_lint javac javadoc unit |
uname | Linux b7231140e0d9 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / 8f6849ff02 |
maven | version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
Default Java | 1.8.0_162 |
rubocop | v0.54.0 |
ruby-lint | v2.3.1 |
ruby-lint | https://builds.apache.org/job/PreCommit-HBASE-Build/12315/artifact/patchprocess/diff-patch-ruby-lint.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/12315/testReport/ |
Max. process+thread count | 4557 (vs. ulimit of 10000) |
modules | C: hbase-shell . U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/12315/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
pushed to branch-1.4+. Marking as incompatible since we're ignoring the flag and in theory folks in the 1.4.0-1.4.2 range could have started checking that we return `nil` from commands (e.g. to figure out if we're in interactive mode or not).
Results for branch branch-2
build #578 on builds.a.o: -1 overall
details (if available):
+1 general checks
– For more information see general report
-1 jdk8 hadoop2 checks
– For more information see jdk8 (hadoop2) report
-1 jdk8 hadoop3 checks
– For more information see jdk8 (hadoop3) report
+1 source release artifact
– See build output for details.
Results for branch branch-2.0
build #138 on builds.a.o: -1 overall
details (if available):
+1 general checks
– For more information see general report
+1 jdk8 hadoop2 checks
– For more information see jdk8 (hadoop2) report
+1 jdk8 hadoop3 checks
– For more information see jdk8 (hadoop3) report
+1 source release artifact
– See build output for details.
Results for branch branch-1
build #273 on builds.a.o: -1 overall
details (if available):
-1 general checks
– For more information see general report
-1 jdk7 checks
– For more information see jdk7 report
-1 jdk8 hadoop2 checks
– For more information see jdk8 (hadoop2) report
Results for branch master
build #286 on builds.a.o: -1 overall
details (if available):
+1 general checks
– For more information see general report
-1 jdk8 hadoop2 checks
– For more information see jdk8 (hadoop2) report
-1 jdk8 hadoop3 checks
– For more information see jdk8 (hadoop3) report
+1 source release artifact
– See build output for details.
Results for branch branch-1.4
build #279 on builds.a.o: -1 overall
details (if available):
-1 general checks
– For more information see general report
-1 jdk7 checks
– For more information see jdk7 report
-1 jdk8 hadoop2 checks
– For more information see jdk8 (hadoop2) report
Results for branch HBASE-19064
build #90 on builds.a.o: -1 overall
details (if available):
-1 general checks
– For more information see general report
-1 jdk8 hadoop2 checks
– For more information see jdk8 (hadoop2) report
-1 jdk8 hadoop3 checks
– For more information see jdk8 (hadoop3) report
+1 source release artifact
– See build output for details.
At least in branch-1 and branch-1.4 this broke the shell, please fix
SyntaxError: hbase/bin/../hbase-shell/src/main/ruby/hbase/table.rb:724: syntax error, unexpected tDOT
.map
{ |i| Bytes.toStringBinary(i.getRegionInfo().getStartKey) }^
require at org/jruby/RubyKernel.java:1062
(root) at /Users/apurtell/src/hbase/bin/../hbase-shell/src/main/ruby/hbase/table.rb:25
require at org/jruby/RubyKernel.java:1062
(root) at /Users/apurtell/src/hbase/bin/../hbase-shell/src/main/ruby/hbase/hbase.rb:102
require at org/jruby/RubyKernel.java:1062
(root) at /Users/apurtell/src/hbase/bin/../bin/hirb.rb:107
switching to ruby 1.8 in branch-1 shows two issues:
$ ruby -v ruby 1.8.7 (2013-06-27 patchlevel 374) [i686-darwin15.6.0] $ for script in `find hbase-shell/src/main/ruby/ -name '*.rb'`; do ruby -c ${script}; done | grep -v "Syntax OK" hbase-shell/src/main/ruby//hbase/table.rb:724: syntax error, unexpected '.', expecting kEND .map { |i| Bytes.toStringBinary... ^ hbase-shell/src/main/ruby//hbase/table.rb:725: syntax error, unexpected '.', expecting kEND .delete_if { |k| k == "" } ^ hbase-shell/src/main/ruby//shell/commands/get_splits.rb:42: syntax error, unexpected ':', expecting ')' numsplits: (splits.size + 1))) ^ hbase-shell/src/main/ruby//shell/commands/get_splits.rb:42: syntax error, unexpected ')', expecting kEND numsplits: (splits.size + 1))) ^
Apologies for the oversight. looks like no shell tests run in the default on branch-1?
$ mvn -pl hbase-shell verify 16:28:31,056 [INFO] Scanning for projects... 16:28:33,172 [INFO] 16:28:33,172 [INFO] ------------------------------------------------------------------------ 16:28:33,172 [INFO] Building Apache HBase - Shell 1.5.0-SNAPSHOT 16:28:33,172 [INFO] ------------------------------------------------------------------------ 16:28:35,194 [INFO] ... 16:28:46,120 [INFO] --- maven-surefire-plugin:2.20.1:test (default-test) @ hbase-shell --- 16:28:46,838 [INFO] 16:28:46,838 [INFO] ------------------------------------------------------- 16:28:46,839 [INFO] T E S T S 16:28:46,839 [INFO] ------------------------------------------------------- 16:28:50,146 [INFO] 16:28:50,146 [INFO] Results: 16:28:50,147 [INFO] 16:28:50,149 [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 16:28:50,150 [INFO] 16:28:50,162 [INFO] 16:28:50,163 [INFO] --- maven-surefire-plugin:2.20.1:test (secondPartTestsExecution) @ hbase-shell --- 16:28:50,169 [INFO] 16:28:50,170 [INFO] ------------------------------------------------------- 16:28:50,170 [INFO] T E S T S 16:28:50,170 [INFO] ------------------------------------------------------- 16:28:52,152 [INFO] 16:28:52,152 [INFO] Results: 16:28:52,152 [INFO] 16:28:52,152 [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 16:28:52,152 [INFO] ... 16:28:53,269 [INFO] ------------------------------------------------------------------------ 16:28:53,269 [INFO] BUILD SUCCESS 16:28:53,269 [INFO] ------------------------------------------------------------------------ 16:28:53,270 [INFO] Total time: 22.241 s 16:28:53,270 [INFO] Finished at: 2018-04-18T16:28:53-05:00 16:28:53,598 [INFO] Final Memory: 54M/757M 16:28:53,600 [INFO] ------------------------------------------------------------------------
I'll try to fix that in a follow-on issue.
I don't know who or what broke shell tests in branch-1 but a fix would definitely be appreciated!
huh. okay. branch-1 has me confused.
syntax errors fixed:
$ ruby -v ruby 1.8.7 (2013-06-27 patchlevel 374) [i686-darwin15.6.0] $ for script in `find hbase-shell/src/main/ruby/ -name '*.rb'`; do ruby -c ${script}; done | grep -v "Syntax OK" $
but tests all fail (when run with mvn -PrunAllTests -pl hbase-shell verify) with:
16:38:24,668 [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 10.458 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestShell 16:38:24,668 [ERROR] testRunShellTests(org.apache.hadoop.hbase.client.TestShell) Time elapsed: 1.686 s <<< ERROR! org.jruby.embed.EvalFailedException: (LoadError) no such file to load -- rake at org.apache.hadoop.hbase.client.TestShell.testRunShellTests(TestShell.java:36) Caused by: org.jruby.exceptions.RaiseException: (LoadError) no such file to load -- rake
Happens before my change too... digging in. I presume this means nightly is broken too.
org.jruby.embed.EvalFailedException: (LoadError) no such file to load – rake
Probably a backport that didn't get test coverage
I think this is something in my environment. I get the same error no matter how far I go back it seems; even trying rel/1.2.0 fails the same way.
apurtell busbey The patch for branch-1 in HBASE-20293 will fix the dot position errors and the hash expression error.
my local addendum works when I build and run the shell / get_splits. changes a less than the current branch-1 patch on HBASE-20293. I'm planning to review HBASE-20293 tomorrow. apurtell you have a preference between getting an addendum here now vs waiting for branch-1 on HBASE-20293?
In either case I'll try to figure out my Test*Shell* problems in a different issue.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 18s | Docker mode activated. |
Prechecks | |||
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
branch-1 Compile Tests | |||
+1 | mvninstall | 1m 29s | branch-1 passed |
+1 | javadoc | 0m 9s | branch-1 passed with JDK v1.8.0_163 |
+1 | javadoc | 0m 13s | branch-1 passed with JDK v1.7.0_171 |
Patch Compile Tests | |||
+1 | mvninstall | 1m 35s | the patch passed |
-1 | rubocop | 0m 9s | The patch generated 5 new + 313 unchanged - 2 fixed = 318 total (was 315) |
-1 | ruby-lint | 0m 2s | The patch generated 1 new + 114 unchanged - 1 fixed = 115 total (was 115) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | javadoc | 0m 8s | the patch passed with JDK v1.8.0_163 |
+1 | javadoc | 0m 10s | the patch passed with JDK v1.7.0_171 |
Other Tests | |||
+1 | unit | 8m 42s | hbase-shell in the patch passed. |
+1 | asflicense | 0m 7s | The patch does not generate ASF License warnings. |
13m 20s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12919746/HBASE-20276-branch-1.v4.patch |
Optional Tests | asflicense javac javadoc unit rubocop ruby_lint |
uname | Linux 505cd253f3fd 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | branch-1 / 03eb3d2 |
maven | version: Apache Maven 3.0.5 |
Default Java | 1.7.0_171 |
Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_163 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_171 |
rubocop | v0.54.0 |
rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/12550/artifact/patchprocess/diff-patch-rubocop.txt |
ruby-lint | v2.3.1 |
ruby-lint | https://builds.apache.org/job/PreCommit-HBASE-Build/12550/artifact/patchprocess/diff-patch-ruby-lint.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/12550/testReport/ |
Max. process+thread count | 1534 (vs. ulimit of 10000) |
modules | C: hbase-shell U: hbase-shell |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/12550/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
No preference but please let's get it wrapped up by the end of the week so we can start a 1.4 RC
Opening HBASE-20463 for branch-1 fix. Resolving this so it makes it into the RC1 of 2.0.0 release notes. Hope you don't mind lads (busbey and apurtell)
Additional complication,
HBASE-15965made it into release 1.4.0 andHBASE-19770is in 1.4.2.