[HBASE-19770] Add '--return-values' option to Shell to print return values of commands in interactive mode

• Type: Improvement
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.0.0-beta-2, 1.4.2, 2.0.0
• Component/s: shell
• Hadoop Flags: Reviewed

Release Note

Introduces a new option to the HBase shell: -r, --return-values. When the shell is in "interactive" mode (default), the return value of shell commands are not returned to the user as they dirty the console output. For those who desire this functionality, the "--return-values" option restores the old functionality of the commands passing their return value to the user.

• Assignee: Josh Elser
• Reporter: Romil Choksi
• Created: 11/Jan/18 18:15
• Updated: 24/Jun/22 18:05
• Resolved: 24/Jan/18 19:39

Description

Another good find by our Romil.

hbase(main):001:0> list
TABLE
a
1 row(s)
Took 0.8385 seconds
hbase(main):002:0> tables=list
TABLE
a
1 row(s)
Took 0.0267 seconds
hbase(main):003:0> puts tables

hbase(main):004:0> p tables
nil

The list command should be returning ['a'] but is not.

The command class itself appears to be doing the right thing – maybe the retval is getting lost somewhere else?

FYI stack.

Issue Links

• is broken by: HBASE-15965 Shell test changes. Use @shell.command instead directly calling functions in admin.rb and other libraries.
• is related to: HBASE-20304 Flip default "return-values" in shell from false to true
• is superceded by: HBASE-20276 [shell] Revert shell REPL change and document