Details
-
Bug
-
Status: Resolved
-
Critical
-
Resolution: Fixed
-
None
-
1.3.2, 2.0.0-beta-2, 1.4.2, 2.0.0, 1.2.7
-
None
-
None
-
Reviewed
Description
2018-01-27 22:51:43,794 INFO [hconnection-0x3291b443-shared-pool11-t6] client.AsyncRequestFutureImpl(778): id=5, table=testQuotaStatusFromMaster3, attempt=6/16 failed=20ops, last exception=org.apache.hadoop.hbase.client.WrongRowIOException: org.apache.hadoop.hbase.client.WrongRowIOException: The row in xxx doesn't match the original one aaa at org.apache.hadoop.hbase.client.Mutation.add(Mutation.java:776) at org.apache.hadoop.hbase.client.Put.add(Put.java:282) at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toPut(ProtobufUtil.java:642) at org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(RSRpcServices.java:952) at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:896) at org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2591) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41560) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:404) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
I noticed this bug when testing the table space quota.
When rs are converting pb mutation to hbase.mutation, the quota exception or cell exception may be thrown.
Unable to find source-code formatter for language: rsrpcservices#dobatchop.java. Available languages are: actionscript, ada, applescript, bash, c, c#, c++, cpp, css, erlang, go, groovy, haskell, html, java, javascript, js, json, lua, none, nyan, objc, perl, php, python, r, rainbow, ruby, scala, sh, sql, swift, visualbasic, xml, yaml for (ClientProtos.Action action: mutations) { MutationProto m = action.getMutation(); Mutation mutation; if (m.getMutateType() == MutationType.PUT) { mutation = ProtobufUtil.toPut(m, cells); batchContainsPuts = true; } else { mutation = ProtobufUtil.toDelete(m, cells); batchContainsDelete = true; } mutationActionMap.put(mutation, action); mArray[i++] = mutation; checkCellSizeLimit(region, mutation); // Check if a space quota disallows this mutation spaceQuotaEnforcement.getPolicyEnforcement(region).check(mutation); quota.addMutation(mutation); }
rs has caught the exception but it doesn't have the cellscanner skip the failed cells.
} catch (IOException ie) { if (atomic) { throw ie; } for (Action mutation : mutations) { builder.addResultOrException(getResultOrException(ie, mutation.getIndex())); } }
The bug results in the WrongRowIOException to remaining mutations since they refer to invalid cells.
Attachments
Attachments
- HBASE-19876.branch-1.2.v0.patch
- 18 kB
- Chia-Ping Tsai
- HBASE-19876.master.001.patch
- 9 kB
- Michael Stack
- HBASE-19876.v0.patch
- 17 kB
- Chia-Ping Tsai
- HBASE-19876.v1.patch
- 17 kB
- Chia-Ping Tsai
- HBASE-19876.v2.patch
- 17 kB
- Chia-Ping Tsai
- HBASE-19876.v3.patch
- 17 kB
- Chia-Ping Tsai
- HBASE-19876.v3.patch
- 17 kB
- Michael Stack
- HBASE-19876.v3.patch
- 17 kB
- Chia-Ping Tsai
- HBASE-19876.v3.patch
- 17 kB
- Chia-Ping Tsai
- HBASE-19876.v4.patch
- 13 kB
- Chia-Ping Tsai
- HBASE-19876.v5.patch
- 13 kB
- Chia-Ping Tsai
- HBASE-19876.v6.patch
- 24 kB
- Chia-Ping Tsai
Issue Links
- is blocked by
-
HBASE-19900 Region-level exception destroy the result of batch
- Resolved
Activity
A related issue was fixed some time back.
Skipping the cur cell which is problematic. So that might be missing for some places exception handling !!!
yep, all append/increment/doBatchOp have similar issue...
The append/increment wont do the batch so only batch of put/Delete has this issue. That makes the fix easy. Will come back soon.
Append and increment Mutation may have N Cells in that (for same row). Even if one cell is malformed, we have to fail the op. Ya that make sense. Need to verify once though. Thanks Chia.
Looks good overall
1008 // if the mArray[i] != null, it means the cell scanner has be read.
Typo: 'be'
Please remove commented out code in the test.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 15s | Docker mode activated. |
Prechecks | |||
0 | findbugs | 0m 0s | Findbugs executables are not available. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
master Compile Tests | |||
+1 | mvninstall | 4m 58s | master passed |
+1 | compile | 0m 45s | master passed |
+1 | checkstyle | 1m 8s | master passed |
+1 | shadedjars | 5m 54s | branch has no errors when building our shaded downstream artifacts. |
+1 | javadoc | 0m 31s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 4m 32s | the patch passed |
+1 | compile | 0m 43s | the patch passed |
+1 | javac | 0m 43s | the patch passed |
-1 | checkstyle | 1m 8s | hbase-server: The patch generated 2 new + 130 unchanged - 0 fixed = 132 total (was 130) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 5m 4s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 21m 15s | Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. |
+1 | javadoc | 0m 58s | the patch passed |
Other Tests | |||
-1 | unit | 38m 45s | hbase-server in the patch failed. |
+1 | asflicense | 0m 27s | The patch does not generate ASF License warnings. |
80m 23s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hbase.TestClientClusterMetrics |
hadoop.hbase.favored.TestFavoredNodeAssignmentHelper |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12908728/HBASE-19876.v1.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux e3eea62c867b 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / 9272f40a5c |
maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
Default Java | 1.8.0_151 |
checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/11316/artifact/patchprocess/diff-checkstyle-hbase-server.txt |
unit | https://builds.apache.org/job/PreCommit-HBASE-Build/11316/artifact/patchprocess/patch-unit-hbase-server.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11316/testReport/ |
Max. process+thread count | 669 (vs. ulimit of 10000) |
modules | C: hbase-server U: hbase-server |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11316/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
The failed tests are caused by new timeout rule. HBASE-19911 is dealing with them.
v2 fix the checkstyle warnings.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 10s | Docker mode activated. |
Prechecks | |||
0 | findbugs | 0m 0s | Findbugs executables are not available. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
master Compile Tests | |||
+1 | mvninstall | 3m 54s | master passed |
+1 | compile | 0m 38s | master passed |
+1 | checkstyle | 0m 55s | master passed |
+1 | shadedjars | 5m 48s | branch has no errors when building our shaded downstream artifacts. |
+1 | javadoc | 1m 7s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 7m 1s | the patch passed |
+1 | compile | 1m 19s | the patch passed |
+1 | javac | 1m 19s | the patch passed |
+1 | checkstyle | 1m 41s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 6m 33s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 22m 53s | Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. |
+1 | javadoc | 0m 26s | the patch passed |
Other Tests | |||
-1 | unit | 95m 54s | hbase-server in the patch failed. |
+1 | asflicense | 0m 20s | The patch does not generate ASF License warnings. |
141m 39s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hbase.TestFullLogReconstruction |
hadoop.hbase.client.TestPartialMalformedCells |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12908749/HBASE-19876.v2.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux 6fae00c93d03 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / 9272f40a5c |
maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
Default Java | 1.8.0_151 |
unit | https://builds.apache.org/job/PreCommit-HBASE-Build/11322/artifact/patchprocess/patch-unit-hbase-server.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11322/testReport/ |
Max. process+thread count | 5422 (vs. ulimit of 6000) |
modules | C: hbase-server U: hbase-server |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11322/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 0s | Docker mode activated. |
-1 | docker | 0m 2s | Docker failed to build yetus/hbase:tp-29582. |
Subsystem | Report/Notes |
---|---|
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12908805/HBASE-19876.v3.patch |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11330/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 2m 29s | Docker mode activated. |
Prechecks | |||
0 | findbugs | 0m 1s | Findbugs executables are not available. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
master Compile Tests | |||
+1 | mvninstall | 3m 53s | master passed |
+1 | compile | 0m 38s | master passed |
+1 | checkstyle | 0m 58s | master passed |
+1 | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. |
+1 | javadoc | 0m 26s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 3m 54s | the patch passed |
+1 | compile | 0m 40s | the patch passed |
+1 | javac | 0m 40s | the patch passed |
+1 | checkstyle | 0m 54s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 13s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 16m 24s | Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. |
+1 | javadoc | 0m 27s | the patch passed |
Other Tests | |||
-1 | unit | 98m 9s | hbase-server in the patch failed. |
+1 | asflicense | 0m 14s | The patch does not generate ASF License warnings. |
133m 28s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hbase.TestZooKeeper |
hadoop.hbase.TestFullLogReconstruction |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12908813/HBASE-19876.v3.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux 6faf42f71166 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / 9272f40a5c |
maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
Default Java | 1.8.0_151 |
unit | https://builds.apache.org/job/PreCommit-HBASE-Build/11331/artifact/patchprocess/patch-unit-hbase-server.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11331/testReport/ |
Max. process+thread count | 5828 (vs. ulimit of 20000) |
modules | C: hbase-server U: hbase-server |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11331/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 0s | Docker mode activated. |
-1 | patch | 0m 4s | |
Subsystem | Report/Notes |
---|---|
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12908874/HBASE-19876.v3.patch |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11346/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 0s | Docker mode activated. |
-1 | patch | 0m 4s | |
Subsystem | Report/Notes |
---|---|
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12908964/HBASE-19876.v3.patch |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11360/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
Thanks stack. I forget to say this issue is blocked by HBASE-19900. If HBASE-19900 is not resolved, the tests in the patch are unstable because of the region-level exception.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 2m 5s | Docker mode activated. |
Prechecks | |||
0 | findbugs | 0m 1s | Findbugs executables are not available. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
master Compile Tests | |||
+1 | mvninstall | 4m 23s | master passed |
+1 | compile | 0m 43s | master passed |
+1 | checkstyle | 1m 7s | master passed |
+1 | shadedjars | 5m 47s | branch has no errors when building our shaded downstream artifacts. |
+1 | javadoc | 0m 29s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 4m 21s | the patch passed |
+1 | compile | 0m 41s | the patch passed |
+1 | javac | 0m 41s | the patch passed |
+1 | checkstyle | 1m 8s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 44s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 18m 14s | Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. |
+1 | javadoc | 0m 27s | the patch passed |
Other Tests | |||
-1 | unit | 102m 32s | hbase-server in the patch failed. |
+1 | asflicense | 0m 19s | The patch does not generate ASF License warnings. |
141m 26s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hbase.replication.TestReplicationDroppedTables |
hadoop.hbase.TestFullLogReconstruction |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12909023/HBASE-19876.master.001.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux edd281aedb18 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh |
git revision | master / 8143d5afa4 |
maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
Default Java | 1.8.0_151 |
unit | https://builds.apache.org/job/PreCommit-HBASE-Build/11363/artifact/patchprocess/patch-unit-hbase-server.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11363/testReport/ |
Max. process+thread count | 4797 (vs. ulimit of 10000) |
modules | C: hbase-server U: hbase-server |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11363/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 16s | Docker mode activated. |
Prechecks | |||
0 | findbugs | 0m 0s | Findbugs executables are not available. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
master Compile Tests | |||
+1 | mvninstall | 3m 58s | master passed |
+1 | compile | 0m 38s | master passed |
+1 | checkstyle | 0m 56s | master passed |
+1 | shadedjars | 5m 8s | branch has no errors when building our shaded downstream artifacts. |
+1 | javadoc | 0m 25s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 4m 2s | the patch passed |
+1 | compile | 0m 38s | the patch passed |
+1 | javac | 0m 38s | the patch passed |
-1 | checkstyle | 0m 58s | hbase-server: The patch generated 2 new + 130 unchanged - 0 fixed = 132 total (was 130) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 10s | patch has no errors when building our shaded downstream artifacts. |
-1 | hadoopcheck | 6m 10s | The patch causes 10 errors with Hadoop v2.6.5. |
-1 | hadoopcheck | 8m 8s | The patch causes 10 errors with Hadoop v2.7.4. |
-1 | hadoopcheck | 10m 16s | The patch causes 10 errors with Hadoop v3.0.0. |
+1 | javadoc | 0m 25s | the patch passed |
Other Tests | |||
+1 | unit | 93m 3s | hbase-server in the patch passed. |
+1 | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
120m 15s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12909662/HBASE-19876.v4.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux afc2078b2513 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / d95940776e |
maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
Default Java | 1.8.0_151 |
checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/11438/artifact/patchprocess/diff-checkstyle-hbase-server.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11438/testReport/ |
Max. process+thread count | 5350 (vs. ulimit of 10000) |
modules | C: hbase-server U: hbase-server |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11438/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 18s | Docker mode activated. |
Prechecks | |||
0 | findbugs | 0m 0s | Findbugs executables are not available. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
master Compile Tests | |||
+1 | mvninstall | 4m 35s | master passed |
+1 | compile | 0m 42s | master passed |
+1 | checkstyle | 1m 6s | master passed |
+1 | shadedjars | 5m 49s | branch has no errors when building our shaded downstream artifacts. |
+1 | javadoc | 0m 27s | master passed |
Patch Compile Tests | |||
+1 | mvninstall | 4m 24s | the patch passed |
+1 | compile | 0m 41s | the patch passed |
+1 | javac | 0m 41s | the patch passed |
+1 | checkstyle | 1m 6s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 42s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 18m 15s | Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. |
+1 | javadoc | 0m 26s | the patch passed |
Other Tests | |||
+1 | unit | 115m 6s | hbase-server in the patch passed. |
+1 | asflicense | 0m 19s | The patch does not generate ASF License warnings. |
152m 21s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12909826/HBASE-19876.v5.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux e3a1d3476825 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / 277ce3d8a3 |
maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
Default Java | 1.8.0_151 |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11455/testReport/ |
Max. process+thread count | 5748 (vs. ulimit of 10000) |
modules | C: hbase-server U: hbase-server |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11455/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 13m 52s | Docker mode activated. |
Prechecks | |||
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
branch-1.2 Compile Tests | |||
0 | mvndep | 1m 23s | Maven dependency ordering for branch |
+1 | mvninstall | 7m 51s | branch-1.2 passed |
+1 | compile | 1m 14s | branch-1.2 passed with JDK v1.8.0_162 |
+1 | compile | 1m 11s | branch-1.2 passed with JDK v1.7.0_171 |
+1 | checkstyle | 2m 15s | branch-1.2 passed |
+1 | shadedjars | 5m 18s | branch has no errors when building our shaded downstream artifacts. |
+1 | findbugs | 3m 46s | branch-1.2 passed |
+1 | javadoc | 1m 11s | branch-1.2 passed with JDK v1.8.0_162 |
+1 | javadoc | 1m 17s | branch-1.2 passed with JDK v1.7.0_171 |
Patch Compile Tests | |||
0 | mvndep | 0m 14s | Maven dependency ordering for patch |
+1 | mvninstall | 1m 45s | the patch passed |
+1 | compile | 0m 57s | the patch passed with JDK v1.8.0_162 |
+1 | javac | 0m 57s | the patch passed |
+1 | compile | 0m 50s | the patch passed with JDK v1.7.0_171 |
+1 | javac | 0m 50s | the patch passed |
+1 | checkstyle | 0m 30s | The patch hbase-client passed checkstyle |
+1 | checkstyle | 1m 15s | hbase-server: The patch generated 0 new + 135 unchanged - 1 fixed = 135 total (was 136) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 2m 27s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 8m 12s | Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.4. |
+1 | findbugs | 3m 16s | the patch passed |
+1 | javadoc | 0m 40s | the patch passed with JDK v1.8.0_162 |
+1 | javadoc | 0m 55s | the patch passed with JDK v1.7.0_171 |
Other Tests | |||
+1 | unit | 1m 53s | hbase-client in the patch passed. |
-1 | unit | 86m 27s | hbase-server in the patch failed. |
+1 | asflicense | 0m 34s | The patch does not generate ASF License warnings. |
145m 28s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hbase.client.TestMetaCache |
hadoop.hbase.util.TestHBaseFsck |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:e77c578 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12909959/HBASE-19876.branch-1.2.v0.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux e698075b841a 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | branch-1.2 / ebdfbaf |
maven | version: Apache Maven 3.0.5 |
Default Java | 1.7.0_171 |
Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_162 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_171 |
findbugs | v3.0.0 |
unit | https://builds.apache.org/job/PreCommit-HBASE-Build/11468/artifact/patchprocess/patch-unit-hbase-server.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11468/testReport/ |
Max. process+thread count | 3465 (vs. ulimit of 10000) |
modules | C: hbase-client hbase-server U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11468/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
The failed tests pass locally...Try the patch for master. Ping for reviews also.
+1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 15s | Docker mode activated. |
Prechecks | |||
0 | findbugs | 0m 0s | Findbugs executables are not available. |
+1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
+1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
master Compile Tests | |||
0 | mvndep | 0m 21s | Maven dependency ordering for branch |
+1 | mvninstall | 4m 19s | master passed |
+1 | compile | 1m 1s | master passed |
+1 | checkstyle | 1m 36s | master passed |
+1 | shadedjars | 6m 17s | branch has no errors when building our shaded downstream artifacts. |
+1 | javadoc | 0m 47s | master passed |
Patch Compile Tests | |||
0 | mvndep | 0m 13s | Maven dependency ordering for patch |
+1 | mvninstall | 4m 22s | the patch passed |
+1 | compile | 1m 2s | the patch passed |
+1 | javac | 1m 2s | the patch passed |
+1 | checkstyle | 1m 41s | the patch passed |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
+1 | shadedjars | 4m 49s | patch has no errors when building our shaded downstream artifacts. |
+1 | hadoopcheck | 19m 14s | Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. |
+1 | javadoc | 0m 55s | the patch passed |
Other Tests | |||
+1 | unit | 3m 1s | hbase-client in the patch passed. |
+1 | unit | 115m 15s | hbase-server in the patch passed. |
+1 | asflicense | 0m 51s | The patch does not generate ASF License warnings. |
160m 1s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12910018/HBASE-19876.v6.patch |
Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
uname | Linux 7387a76c9d23 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | master / 32f235abee |
maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
Default Java | 1.8.0_151 |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/11473/testReport/ |
Max. process+thread count | 4811 (vs. ulimit of 10000) |
modules | C: hbase-client hbase-server U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/11473/console |
Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
Took a look. This is tricky stuff. Thanks for diving in.
This comment is a little confusing:
890 // TODO doBatchOp has handled the IOE for all non-atomic operations
891 // Catching IOE here may confuse readers in the future
It is in a catch for an IOE so ... should we remove the catch block this comment is in?
I was trying to see if you could get rid of the cycle looking for Gets in checkAndRowMutate now it has been added to doBatchOp but couldn't figure it; an optimization for another time (smile).
On below, I agree.
1011 // The atomic ops use the global exception although I feel it is ok to add the exception
1012 // to each action.
We need an issue for the below?
184 * The invalid cells is in rm. The rm should fail but the subsequent mutations should succeed.
185 * Currently, we have no client api to submit the request consisting of condition-rm and mutation.
186 * Hence, this test build the request manually.
We need to make it so it is easy to stand up a RegionServer w/o a Master so you don't have to do the below. This should be easier now... since HBASE-18846. Let me work on it....
218 ClientProtos.MultiResponse response = rs.getRSRpcServices().multi(controller, request);
Great tests chia7712
This patch is super important stuff.
+1 to commit.
It is in a catch for an IOE so ... should we remove the catch block this comment is in?
The non-atomic doBatchOp won't throw IOE....The catch here is weird but it won't be used. We can do a minor refactor for it later.
I was trying to see if you could get rid of the cycle looking for Gets in checkAndRowMutate now it has been added to doBatchOp but couldn't figure it; an optimization for another time (smile).
ya, another refactor....
On below, I agree.
1011 // The atomic ops use the global exception although I feel it is ok to add the exception
1012 // to each action.
Oh...I forgot to remove the comment. After HBASE-19900, our client can handle both of region exception and action exception accurately. Only adding the region exception can reduce the memory consumption (it is similar to HBASE-19715).
We need an issue for the below?
Agreed. It would be a nice feature for 2.0.
We need to make it so it is easy to stand up a RegionServer w/o a Master so you don't have to do the below.
The test is necessary for both of branch-1.3 and branch-1.2 as we won't add the such client APIs to them I guess. By contrast, if the impl can be introduced to client APIs for branch-1.4+, we can substitute the real use case for the hacky test.
+1 to commit.
I'm on my travels so I will commit the patch on Monday. Thanks for the reviews stack
The non-atomic doBatchOp won't throw IOE....The catch here is weird but it won't be used. We can do a minor refactor for it later.
Agree. On commit add in the above line?
Otherwise all good. Makes sense that the test be portable but I should make it so standing up a RegionServer is easy in test; will cut down test times.
+1 on commit Monday.
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #348 (See https://builds.apache.org/job/HBase-1.3-IT/348/)
HBASE-19876 The exception happening in converting pb mutation to (chia7712: rev e36dca55bcd5ad95cd99a19a3630d6c143acfcab)
- (add) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMalformedCellFromClient.java
- (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
- (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1068 (See https://builds.apache.org/job/HBase-1.2-IT/1068/)
HBASE-19876 The exception happening in converting pb mutation to (chia7712: rev b59c3151dfe41926d242c5c581a248e272834aa1)
- (add) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMalformedCellFromClient.java
- (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
- (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4579 (See https://builds.apache.org/job/HBase-Trunk_matrix/4579/)
HBASE-19876 The exception happening in converting pb mutation to (chia7712: rev 2f48fdbb26ff555485b4aa3393d835b7dd8797a0)
- (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
- (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMalformedCellFromClient.java
- (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
A related issue was fixed some time back.. Skipping the cur cell which is problematic. So that might be missing for some places exception handling !!!