Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15214

Valid mutate Ops fail with RPC Codec in use and region moves across

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.98.0
    • Fix Version/s: 1.2.0, 1.3.0, 1.1.4, 1.0.4, 0.98.18, 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Test failures in HBASE-15198 lead to this bug. Till now we are not doing cell block (codec usage) for write requests. (Client -> server) Once we enabled Codec usage by default, aw this issue.
      A multi request came to RS with mutation for different regions. One of the region which was in this RS got unavailable now. In RsRpcServices#multi, we will fail that entire RegionAction (with N mutations in it) in that MultiRequest. Then we will continue with remaining RegionActions. Those Regions might be available. (The failed RegionAction will get retried from client after fetching latest region location). This all works fine in pure PB requests world. When a Codec is used, we wont convert the Mutation Cell to PB Cells and pack them in PB Message. Instead we will pass all Cells serialized into one byte[] cellblock. Using Decoder we will iterate over these cells at server side. Each Mutation PB will know only the number of cells associated with it. As in above case when an entire RegionAction was skipped, there might be N Mutations under that which might have corresponding Cells in the cellblock. We are not doing the skip in that Iterator. This makes the later Mutations (for other Regions) to refer to invalid Cells and try to put those into the a different region. This will make HRegion#checkRow() to throw which will be treated as Sanity check failure and so throwing back a DNRIOE to client. So the op will get failed for the user code.

        Attachments

        1. HBASE-15214_V2.patch
          7 kB
          Anoop Sam John
        2. HBASE-15214_V3.patch
          7 kB
          Anoop Sam John
        3. HBASE-15214.patch
          7 kB
          Anoop Sam John
        4. HBASE-15214-0.98.patch
          6 kB
          Anoop Sam John
        5. HBASE-15214-branch-1.0.patch
          7 kB
          Anoop Sam John
        6. HBASE-15214-branch-1.1.patch
          7 kB
          Anoop Sam John
        7. HBASE-15214-branch-1.patch
          7 kB
          Anoop Sam John

          Activity

            People

            • Assignee:
              anoop.hbase Anoop Sam John
              Reporter:
              anoop.hbase Anoop Sam John

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment