Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-19640

Change in filterAllRemaining() impl for FilterListWithOR

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-beta-1
    • Fix Version/s: None
    • Component/s: Filters
    • Labels:
      None

      Description

      filterAllRemaining() in FilterListWithOR will now return false if the filter list is empty whereas earlier it used to return true for Operator.MUST_PASS_ONE.
      In HBase-2.0

       @Override
        public boolean filterAllRemaining() throws IOException {
          if (isEmpty()) {
            return super.filterAllRemaining();//false
          }
          for (int i = 0, n = filters.size(); i < n; i++) {
            if (!filters.get(i).filterAllRemaining()) {
              return false;
            }
          }
          return true;
        }
      

      Earlier versions(1.3.1 atleast):-

      @Override
        public boolean filterAllRemaining() throws IOException {
          int listize = filters.size();
          for (int i = 0; i < listize; i++) {
            if (filters.get(i).filterAllRemaining()) {
              if (operator == Operator.MUST_PASS_ALL) {
                return true;
              }
            } else {
              if (operator == Operator.MUST_PASS_ONE) {
                return false;
              }
            }
          }
          return operator == Operator.MUST_PASS_ONE;
        }
      

      IMO, the current implementation seems to be right, but probably this change requires a release note at least as some people might have implemented the filters considering the old semantics.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                openinx Zheng Hu
                Reporter:
                ankit@apache.org Ankit Singhal
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: