[HBASE-19502] Make sure we have closed all StoreFileScanners if we fail to open any StoreFileScanners

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.2, 1.4.1, 2.0.0, 1.2.7
• Component/s: regionserver, Scanners
• Hadoop Flags: Reviewed
• Assignee: Chia-Ping Tsai
• Reporter: Chia-Ping Tsai
• Created: 13/Dec/17 06:37
• Updated: 01/Jul/22 20:27
• Resolved: 22/Dec/17 19:28

Description

StoreFileScanner.java

  public static List<StoreFileScanner> getScannersForStoreFiles(Collection<StoreFile> files,
      boolean cacheBlocks, boolean usePread, boolean isCompaction, boolean canUseDrop,
      ScanQueryMatcher matcher, long readPt, boolean isPrimaryReplica) throws IOException {
    List<StoreFileScanner> scanners = new ArrayList<StoreFileScanner>(files.size());
    List<StoreFile> sorted_files = new ArrayList<>(files);
    Collections.sort(sorted_files, StoreFile.Comparators.SEQ_ID);
    for (int i = 0; i < sorted_files.size(); i++) {
      StoreFile.Reader r = sorted_files.get(i).createReader(canUseDrop);
      r.setReplicaStoreFile(isPrimaryReplica);
      StoreFileScanner scanner = r.getStoreFileScanner(cacheBlocks, usePread, isCompaction, readPt,
        i, matcher != null ? !matcher.hasNullColumnInQuery() : false);
      scanners.add(scanner);
    }
    return scanners;
  }

The missed decrement of ref count will obstruct the cleanup of compacted files.