Details
-
Task
-
Status: Closed
-
Major
-
Resolution: Fixed
-
None
-
None
-
None
-
Removed the hbase-native-client module from branch-1 (it is still in Master). It is not complete. Look for a finished C++ client in the near future which may be backported to branch-1 at that point.
Description
We have an hbase-native-client subdirectory in the source tree that isn't hooked up to the Maven build. It hasn't been updated in two years. (Last update Fri Jul 31 11:22:50 2015 -0700.) I propose to remove it from our source distribution. It can be moved to GitHub as a separate project. Dropping it doesn't represent a compatibility problem as it isn't hooked up to the build and seems unlikely anyone is depending on it given we haven't had a single change nor issue reported against it for two years.
Attachments
Attachments
- HBASE-19419-branch-1.patch
- 103 kB
- Andrew Kyle Purtell
Issue Links
- is related to
-
HBASE-24422 Remove hbase-native-client code from the master branch
- Closed
Activity
Thanks mdrob. Updated fixVersions accordingly and will apply the branch-1 patch to branch-1 and branch-1.4 using the same rationale unless objection.
per this thread https://lists.apache.org/thread.html/451020b925ae7af04e37dad57686b7ad01551289d4e123338da51400@%3Cdev.hbase.apache.org%3E I think appy is covering for branch-1.2
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 16m 22s | Docker mode activated. |
Prechecks | |||
0 | shelldocs | 0m 7s | Shelldocs was not available. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
branch-1 Compile Tests | |||
+1 | mvninstall | 2m 0s | branch-1 passed |
+1 | compile | 1m 33s | branch-1 passed with JDK v1.8.0_152 |
+1 | compile | 1m 36s | branch-1 passed with JDK v1.7.0_161 |
Patch Compile Tests | |||
+1 | compile | 1m 31s | the patch passed with JDK v1.8.0_152 |
+1 | cc | 1m 31s | the patch passed |
+1 | compile | 1m 41s | the patch passed with JDK v1.7.0_161 |
+1 | cc | 1m 41s | the patch passed |
+1 | shellcheck | 0m 0s | The patch generated 0 new + 0 unchanged - 40 fixed = 0 total (was 40) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
Other Tests | |||
-1 | unit | 121m 12s | root in the patch failed. |
+1 | asflicense | 1m 10s | The patch does not generate ASF License warnings. |
147m 24s |
Reason | Tests |
---|---|
Failed junit tests | hadoop.hbase.master.TestMasterBalanceThrottling |
hadoop.hbase.master.TestMasterMetrics |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:36a7029 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12900538/HBASE-19419-branch-1.patch |
Optional Tests | asflicense cc unit shellcheck shelldocs compile |
uname | Linux dad228f90514 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19 15:49:21 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
git revision | branch-1 / 9d481b1 |
maven | version: Apache Maven 3.0.5 |
shellcheck | v0.4.6 |
unit | https://builds.apache.org/job/PreCommit-HBASE-Build/10211/artifact/patchprocess/patch-unit-root.txt |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/10211/testReport/ |
modules | C: . U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/10211/console |
Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
-1 overall |
Vote | Subsystem | Runtime | Comment |
---|---|---|---|
0 | reexec | 0m 11s | Docker mode activated. |
Prechecks | |||
0 | shelldocs | 0m 3s | Shelldocs was not available. |
+1 | @author | 0m 0s | The patch does not contain any @author tags. |
-1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
master Compile Tests | |||
+1 | mvninstall | 5m 37s | master passed |
+1 | compile | 5m 32s | master passed |
Patch Compile Tests | |||
+1 | compile | 4m 40s | the patch passed |
+1 | cc | 4m 40s | the patch passed |
+1 | shellcheck | 0m 0s | The patch generated 0 new + 0 unchanged - 40 fixed = 0 total (was 40) |
+1 | whitespace | 0m 0s | The patch has no whitespace issues. |
Other Tests | |||
+1 | unit | 167m 57s | root in the patch passed. |
+1 | asflicense | 0m 27s | The patch does not generate ASF License warnings. |
184m 42s |
Subsystem | Report/Notes |
---|---|
Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
JIRA Issue | |
JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12900539/HBASE-19419.patch |
Optional Tests | asflicense cc unit shellcheck shelldocs compile |
uname | Linux 523a7bae1038 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux |
Build tool | maven |
Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh |
git revision | master / aafaba448d |
maven | version: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
shellcheck | v0.4.4 |
Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/10210/testReport/ |
modules | C: . U: . |
Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/10210/console |
Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
Test failures are not related. This patch only removes files and those files are not used during a build. Going to commit this to branch-1.4 and branch-1 shortly unless objection.
Pushed to branch-1 and branch-1.4
There was support for this removal on dev@hbase on a thread with the subject "Removing hbase-native-client (HBASE-19419)"
FAILURE: Integrated in Jenkins build HBase-1.4 #1049 (See https://builds.apache.org/job/HBase-1.4/1049/)
HBASE-19419 Remove hbase-native-client from branch-1 (apurtell: rev cfa4cbe769663110cb23131ac530c44185911eef)
- (delete) hbase-native-client/src/async/hbase_errno.h
- (delete) hbase-native-client/CMakeLists.txt
- (delete) hbase-native-client/src/sync/hbase_connection.cc
- (delete) hbase-native-client/src/async/hbase_result.cc
- (delete) hbase-native-client/src/async/hbase_client.cc
- (delete) hbase-native-client/src/core/hbase_types.h
- (delete) hbase-native-client/src/core/connection_attr.h
- (delete) hbase-native-client/src/core/delete.h
- (delete) hbase-native-client/src/sync/hbase_admin.cc
- (delete) hbase-native-client/src/core/put.cc
- (delete) hbase-native-client/src/core/put.h
- (delete) hbase-native-client/src/core/mutation.cc
- (delete) hbase-native-client/src/async/hbase_scanner.cc
- (delete) hbase-native-client/src/async/hbase_get.h
- (delete) hbase-native-client/src/core/client.h
- (delete) hbase-native-client/src/sync/hbase_admin.h
- (delete) hbase-native-client/src/core/admin.cc
- (delete) hbase-native-client/src/core/connection.h
- (delete) hbase-native-client/src/core/scanner.h
- (delete) hbase-native-client/src/core/delete.cc
- (delete) hbase-native-client/src/core/hbase_connection_attr.cc
- (delete) hbase-native-client/src/core/get.h
- (delete) hbase-native-client/bin/build-thirdparty.sh
- (delete) hbase-native-client/src/async/mutations-test.cc
- (delete) hbase-native-client/src/async/hbase_scanner.h
- (delete) hbase-native-client/src/core/client.cc
- (delete) hbase-native-client/src/core/mutation.h
- (delete) hbase-native-client/src/core/hbase_connection_attr.h
- (delete) hbase-native-client/src/core/scanner.cc
- (delete) hbase-native-client/src/async/CMakeLists.txt
- (delete) hbase-native-client/src/sync/CMakeLists.txt
- (delete) hbase-native-client/src/async/hbase_mutations.h
- (delete) hbase-native-client/src/async/get-test.cc
- (delete) hbase-native-client/bin/download-thirdparty.sh
- (delete) hbase-native-client/src/async/hbase_get.cc
- (delete) hbase-native-client/src/async/hbase_admin.cc
- (delete) hbase-native-client/bin/build-all.sh
- (delete) hbase-native-client/src/core/connection.cc
- (delete) hbase-native-client/src/core/get.cc
- (delete) hbase-native-client/bin/hbase-client-env.sh
- (delete) hbase-native-client/src/core/hbase_macros.h
- (delete) hbase-native-client/src/async/hbase_admin.h
- (delete) hbase-native-client/src/async/hbase_result.h
- (delete) hbase-native-client/cmake_modules/FindGTest.cmake
- (delete) hbase-native-client/src/core/CMakeLists.txt
- (delete) hbase-native-client/.gitignore
- (delete) hbase-native-client/README.md
- (delete) hbase-native-client/src/async/hbase_connection.cc
- (delete) hbase-native-client/src/async/hbase_connection.h
- (delete) hbase-native-client/src/sync/hbase_connection.h
- (delete) hbase-native-client/src/core/admin.h
- (delete) hbase-native-client/src/async/hbase_client.h
- (delete) hbase-native-client/src/async/hbase_mutations.cc
- (delete) hbase-native-client/cmake_modules/FindLibEv.cmake
- (delete) hbase-native-client/src/rpc/CMakeLists.txt
I think this is fine for branch-1.1. We've never supported the native client on that release line and indeed, it's not available in the src tarball.
What say you appy mantonov
At this time I intend to remove this from all branches back through to branch-1.1. Please speak up if you object
+1
i was gonna have a quick look when i started jira gardening (this was on my list), but if it's gone from lower and higher branches, go for it.
thanks
+1 , thanks for the ping apurtell and sorry for being late in here. Seems like removing it is warranted.
HBASE-19176?