Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-24422

Remove hbase-native-client code from the master branch

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 3.0.0-alpha-1
    • None
    • None

    Description

      Per recent discussions in the slack channel, there is not much value
      in having this code in the master branch. This code has it's dedicated
      git repo at https://github.com/apache/hbase-native-client.

      It was already removed from branch-1 (HBASE-19419) and branch-2
      (HBASE-19176)

      Attachments

        Issue Links

          Activity

            elserj busbey stack There was a discussion from you folks (2y old) in HBASE-19176 whether to delete this from the master branch. I think, at that point in time we didn't have a dedicated git repo for native-client. Now that we have one, I think we can get rid of this code from the master branch. Its a little confusing to see two native client implementations.

            bharathv Bharath Vissapragada added a comment - elserj busbey stack There was a discussion from you folks (2y old) in HBASE-19176 whether to delete this from the master branch. I think, at that point in time we didn't have a dedicated git repo for native-client. Now that we have one, I think we can get rid of this code from the master branch. Its a little confusing to see two native client implementations.
            busbey Sean Busbey added a comment -

            Totally agree! I was planning to propose this same change tonight.

            busbey Sean Busbey added a comment - Totally agree! I was planning to propose this same change tonight.
            stack Michael Stack added a comment -

            bharathv yes. would be good to see if anything in branch that is missing from repo before delete if possible?

            stack Michael Stack added a comment - bharathv yes. would be good to see if anything in branch that is missing from repo before delete if possible?

            stack Yes, I verified that. So the least common ancestor commit for both the client implementations (master vs git repo) is at this commit

            I checked out this commit from the git repo implementation and diff'ed the contents in both the directories.

            HBase master repo:

            git log --oneline
            c303f9d329 (origin/master, origin/HEAD) HBASE-24408 Introduce a general 'local region' to store data on master (#1753)
            a9fefd7f53 HBASE-24297 release scripts should be able to use a custom git repo
            8ff8e70edf HBASE-24296 install yetus as a part of building the rm docker image.
            

            hbase-native-client git repo

            89dda63 (HEAD -> div) HBASE-14087 Ensure correct ASF headers for docs/code
            2e8bfb8 HBASE-10302 Fix rat check issues in hbase-native-client.
            920676a HBASE-9977 Define C interface of HBase Client Asynchronous APIs
            

            diff

            diff -q hbase/hbase-native-client/ hbase-native-client/
            Common subdirectories: hbase/hbase-native-client/bin and hbase-native-client/bin
            Common subdirectories: hbase/hbase-native-client/cmake_modules and hbase-native-client/cmake_modules
            Only in hbase-native-client/: .git
            Only in hbase-native-client/: NOTICE
            Common subdirectories: hbase/hbase-native-client/src and hbase-native-client/src
            

            So hbase-native-client git repo is strictly a superset of the contents in hbase/hbase-native-client.

            bharathv Bharath Vissapragada added a comment - stack Yes, I verified that. So the least common ancestor commit for both the client implementations (master vs git repo) is at this commit I checked out this commit from the git repo implementation and diff'ed the contents in both the directories. HBase master repo: git log --oneline c303f9d329 (origin/master, origin/HEAD) HBASE-24408 Introduce a general 'local region' to store data on master (#1753) a9fefd7f53 HBASE-24297 release scripts should be able to use a custom git repo 8ff8e70edf HBASE-24296 install yetus as a part of building the rm docker image. hbase-native-client git repo 89dda63 (HEAD -> div) HBASE-14087 Ensure correct ASF headers for docs/code 2e8bfb8 HBASE-10302 Fix rat check issues in hbase-native-client. 920676a HBASE-9977 Define C interface of HBase Client Asynchronous APIs diff diff -q hbase/hbase-native-client/ hbase-native-client/ Common subdirectories: hbase/hbase-native-client/bin and hbase-native-client/bin Common subdirectories: hbase/hbase-native-client/cmake_modules and hbase-native-client/cmake_modules Only in hbase-native-client/: .git Only in hbase-native-client/: NOTICE Common subdirectories: hbase/hbase-native-client/src and hbase-native-client/src So hbase-native-client git repo is strictly a superset of the contents in hbase/hbase-native-client.
            hudson Hudson added a comment -

            Results for branch master
            build #1736 on builds.a.o: -1 overall


            details (if available):

            +1 general checks
            – For more information see general report

            -1 jdk8 hadoop2 checks
            – For more information see jdk8 (hadoop2) report

            -1 jdk8 hadoop3 checks
            – For more information see jdk8 (hadoop3) report

            +1 jdk11 hadoop3 checks
            – For more information see jdk11 report

            +1 source release artifact
            – See build output for details.

            +1 client integration test

            hudson Hudson added a comment - Results for branch master build #1736 on builds.a.o : -1 overall details (if available): +1 general checks – For more information see general report -1 jdk8 hadoop2 checks – For more information see jdk8 (hadoop2) report -1 jdk8 hadoop3 checks – For more information see jdk8 (hadoop3) report +1 jdk11 hadoop3 checks – For more information see jdk11 report +1 source release artifact – See build output for details. +1 client integration test
            elserj Josh Elser added a comment -

            Sounds good to me to clean up the remaining stuff in the main tree. Thanks for your eyes, Bharath!

            elserj Josh Elser added a comment - Sounds good to me to clean up the remaining stuff in the main tree. Thanks for your eyes, Bharath!

            People

              bharathv Bharath Vissapragada
              bharathv Bharath Vissapragada
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: